http://bugs.winehq.org/show_bug.cgi?id=28369
Summary: WinRar 3.93 installer crashes after starting Product: Wine Version: 1.3.26 Platform: x86 URL: http://www.rarlab.com/rar/wrar393.exe OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: mshtml AssignedTo: wine-bugs@winehq.org ReportedBy: gyebro69@gmail.com CC: jacek@codeweavers.com Regression SHA1: 908d8333a8f03ae3c143dc613696791815571aaf
Created an attachment (id=36370) --> (http://bugs.winehq.org/attachment.cgi?id=36370) terminal output
The installer for WinRar 3.93 (which is actually a self-extracting rar archive) crashes right after starting.
Workaround: winetricks ie6.
The installer worked normally in Wine-1.3.25:
908d8333a8f03ae3c143dc613696791815571aaf is the first bad commit commit 908d8333a8f03ae3c143dc613696791815571aaf Author: Jacek Caban jacek@codeweavers.com Date: Sun Jul 31 13:24:23 2011 +0200
ieframe: Moved classes registration to ieframe.
:040000 040000 22cfb8d0d133bfd951d3266c6c4311966fee6574 3924679c77a077bbdad1b4f3c81170eb81c5acdb M dlls :040000 040000 d62bb5d308c6743de8b58d027b452ff3d232c90b 0ae327758571c5930a481f9f4d741e6fc36b17b3 M tools
The patch cannot be reverted cleanly, but git checkout 908d8333a8f03ae3c143dc613696791815571aaf >> the installer crashes git reset --hard HEAD^ >> the installer starts correctly
Fedora 15 x86 wine-1.3.28-86-g9b729bb GCC-4.6.0
http://bugs.winehq.org/show_bug.cgi?id=28369
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=28369
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kennybobs@o2.co.uk
http://bugs.winehq.org/show_bug.cgi?id=28369
Reinhard Berger geist1@sms.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |geist1@sms.at
--- Comment #1 from Reinhard Berger geist1@sms.at 2011-09-16 12:27:26 CDT --- Same as WinRar 4.x under Wine 1.3.28
http://bugs.winehq.org/show_bug.cgi?id=28369
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Component|mshtml |-unknown Ever Confirmed|0 |1
--- Comment #2 from Ken Sharp kennybobs@o2.co.uk 2011-09-25 19:34:14 CDT --- Confirming although it worked fine the first two times I tried it, now I get this error every time (clean prefix every time).
http://bugs.winehq.org/show_bug.cgi?id=28369
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11364, 14601, 27382, 27085, | |23113
http://bugs.winehq.org/show_bug.cgi?id=28369
jhgf bernhardloos@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bernhardloos@googlemail.com
--- Comment #3 from jhgf bernhardloos@googlemail.com 2011-09-30 06:18:26 CDT --- This is some kind of COM refcounting snafu. Basically, the DocHost ref count drops to zero and it is deleted, but the HTMLDocumentObj is still around and holds a reference to the DocHost over HTMLDocumentObj->frame. This is used during the window proc of the document:
#0 0x70ff9f31 in set_statustext (doc=0x161640, id=7550, arg=0x1c294a0) at main.c:122 #1 0x7101d6d5 in set_downloading_proc (_task=0x117abd0) at persist.c:167 #2 0x7102b816 in hidden_proc (hwnd=0x20020, msg=32776, wParam=0, lParam=0) at task.c:275 #3 0x685a2f8a in WINPROC_wrapper () from /home/asdf/wine-git/dlls/user32/user32.dll.so #4 0x685a3666 in call_window_proc (hwnd=0x20020, msg=32776, wp=0, lp=0, result=0x33f978, arg=0x7102b790) at winproc.c:242 #5 0x685a5e12 in WINPROC_call_window (hwnd=0x20020, msg=32776, wParam=0, lParam=0, result=0x33f978, unicode=1, mapping=WMCHAR_MAP_DISPATCHMESSAGE) at winproc.c:908 #6 0x6856771f in DispatchMessageW (msg=0x33fa20) at message.c:3809 #7 0x6a60097f in ?? () #8 0x6a62557a in ?? ()
At this point, the memory where DocHost was is already allocated for soemthing else and the result is a crash. Noteable, the refcount of HTMLDocumentObj is 1 at this point, so there is probably only a single Release missing, but this code is rather complex, so figuring out, where it belongs is a rather hard exercise for somebody who doesn't know it.
http://bugs.winehq.org/show_bug.cgi?id=28369
--- Comment #4 from Jacek Caban jacek@codeweavers.com 2011-10-03 11:22:52 CDT --- http://source.winehq.org/patches/data/79492 should fix it
http://bugs.winehq.org/show_bug.cgi?id=28369
--- Comment #5 from GyB gyebro69@gmail.com 2011-10-03 11:49:05 CDT --- (In reply to comment #4)
http://source.winehq.org/patches/data/79492 should fix it
The patch indeed fixes the problem. Tried with WinRar 3.93 and 4.01.
http://bugs.winehq.org/show_bug.cgi?id=28369
--- Comment #6 from jhgf bernhardloos@googlemail.com 2011-10-03 12:08:45 CDT --- (In reply to comment #4)
http://source.winehq.org/patches/data/79492 should fix it
Yes, it does. It still behaves slightly odd: It shows an empty window with the title "License" for a very short time before the actual installer gui comes up. It's probably not noticeable on a faster system. But I guess this should go into a different bug report.
http://bugs.winehq.org/show_bug.cgi?id=28369
Jacek Caban jacek@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #7 from Jacek Caban jacek@codeweavers.com 2011-10-04 09:02:44 CDT --- Reported fixed.
http://bugs.winehq.org/show_bug.cgi?id=28369
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6cfa962922df52a46f222744774 | |3015635ed60e4
http://bugs.winehq.org/show_bug.cgi?id=28369
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org 2011-10-10 13:12:53 CDT --- Closing bugs fixed in 1.3.30.
-
wine-bugs＠winehq.org