http://bugs.winehq.org/show_bug.cgi?id=34372
Bug #: 34372 Summary: Add missing function AllocateAndGetTcpExTableFromStack() to iphlpapi.dll Product: Wine Version: 1.6 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: iphlpapi AssignedTo: wine-bugs@winehq.org ReportedBy: ralf.habacker@freenet.de Classification: Unclassified
Created attachment 45753 --> http://bugs.winehq.org/attachment.cgi?id=45753 Implementation for AllocateAndGetTcpExTableFromStack()
The appended patch adds the missing function AllocateAndGetTcpExTableFromStack() to iphlpapi.dll
This missing function has been detected while testing of cross compiled dbus http://dbus.freedesktop.org under wine.
http://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com 2013-08-27 12:50:50 CDT --- Hi, thanks for your work. Patches are not picked from the bugzilla, please follow the instructions from http://wiki.winehq.org/SubmittingPatches
http://bugs.winehq.org/show_bug.cgi?id=34372
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |00cpxxx@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=34372
Ralf Habacker ralf.habacker@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #2 from Ralf Habacker ralf.habacker@freenet.de 2013-08-29 01:10:38 CDT --- Patch has been submitted
http://bugs.winehq.org/show_bug.cgi?id=34372
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | Ever Confirmed|0 |1
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2013-08-29 01:13:48 CDT --- It wasn't accepted yet.
http://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #4 from Ralf Habacker ralf.habacker@freenet.de 2013-08-29 02:08:56 CDT --- (In reply to comment #1)
Hi, thanks for your work. Patches are not picked from the bugzilla, please follow the instructions from http://wiki.winehq.org/SubmittingPatches
Just a note: I was misleaded by a comment in the Attachments section of the bug tracker, which means
Add an attachment (back traces, logs, *proposed patch*, testcase, etc.)
http://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2013-08-29 02:22:37 CDT --- Attached patches are supposed to be used for testing only, to proof or disproof something. If it's good enough to be included it should be submitted to a list, it's the only way. But I agree, that line could sound misleading.
https://bugs.winehq.org/show_bug.cgi?id=34372
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=34372
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|REOPENED |NEW URL| |http://sourceforge.net/proj | |ects/spammonitor/files/spam | |monitor/0.20/spammon-englis | |h.zip/download CC| |focht@gmx.net Summary|Add missing function |Multiple applications need |AllocateAndGetTcpExTableFro |AllocateAndGetTcpExTableFro |mStack() to iphlpapi.dll |mStack (cross compiled | |dbus, spamMonitor)
--- Comment #6 from Anastasius Focht focht@gmx.net --- Hello folks,
I found another application which makes use of this API: 'spamMonitor'
Download: http://spamcleaner.org/en/spammonitor/
Source: http://spamcleaner.org/en/spammonitor/spammon_asm.html
--- snip --- $ WINEDEBUG=+tid,+seh,+relay wine ./spammon.exe >>log.txt 2>&1 ... 0023:Call KERNEL32.LoadLibraryA(00402039 "iphlpapi.dll") ret=00401056 0023:Call PE DLL (proc=0x7e35f7f0,module=0x7e350000 L"iphlpapi.dll",reason=PROCESS_ATTACH,res=(nil)) ... 0023:Ret KERNEL32.LoadLibraryA() retval=7e350000 ret=00401056 0023:Call KERNEL32.GetProcAddress(7e350000,0040207c "AllocateAndGetTcpExTableFromStack") ret=00401082 0023:Ret KERNEL32.GetProcAddress() retval=00000000 ret=00401082 0023:Call KERNEL32.GetProcAddress(7e350000,0040209e "GetExtendedTcpTable") ret=004010ae 0023:Ret KERNEL32.GetProcAddress() retval=7e353e28 ret=004010ae --- snip ---
$ sha1sum spammon-english.zip eff73e4c30464e808f13f35994f1bae6edfee381 spammon-english.zip
$ du -sh spammon-english.zip 24K spammon-english.zip
$ wine --version wine-1.7.36
Regards
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #7 from Sebastian Lackner sebastian@fds-team.de --- An improved version of the patch is part of wine-staging since quite some time: https://github.com/wine-compholio/wine-staging/tree/master/patches/iphlpapi-...
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #8 from Anastasius Focht focht@gmx.net --- Hello Sebastian,
--- quote --- An improved version of the patch is part of wine-staging since quite some time --- quote ---
Good to know .. but what is the problem with upstream then?
Maybe I made a mistake but a quick search of wine-patches history since Jul 2014 reveals there wasn't a single attempt to get this in.
Regards
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #9 from Austin English austinenglish@gmail.com --- I've sent a stub: https://source.winehq.org/patches/data/108989
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #10 from Anastasius Focht focht@gmx.net --- Hello folks,
obviously still present as of Wine 1.7.44
Regards
https://bugs.winehq.org/show_bug.cgi?id=34372
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |STAGED CC| |michael@fds-team.de Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/iphlpapi-TCP_T | |able
https://bugs.winehq.org/show_bug.cgi?id=34372
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #11 from Anastasius Focht focht@gmx.net --- Hello folks,
revisiting, still present.
--- snip --- ... 004d:Ret PE DLL (proc=0x7e29b38e,module=0x7e280000 L"iphlpapi.dll",reason=PROCESS_ATTACH,res=(nil)) retval=1 004d:Ret KERNEL32.LoadLibraryA() retval=7e280000 ret=00401056 004d:Call KERNEL32.GetProcAddress(7e280000,0040207c "AllocateAndGetTcpExTableFromStack") ret=00401082 004d:Ret KERNEL32.GetProcAddress() retval=00000000 ret=00401082 004d:Call KERNEL32.GetProcAddress(7e280000,0040209e "GetExtendedTcpTable") ret=004010ae 004d:Ret KERNEL32.GetProcAddress() retval=7e28fdd8 ret=004010ae ... --- snip ---
https://svwh.dl.sourceforge.net/project/spammonitor/spammonitor/0.20/spammon...
$ wine --version wine-2.1-126-g06c5a9a
Regards
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #12 from Hans Leidekker hans@meelstraat.net --- (In reply to Anastasius Focht from comment #11)
Hello folks,
revisiting, still present.
--- snip --- ... 004d:Ret PE DLL (proc=0x7e29b38e,module=0x7e280000 L"iphlpapi.dll",reason=PROCESS_ATTACH,res=(nil)) retval=1 004d:Ret KERNEL32.LoadLibraryA() retval=7e280000 ret=00401056 004d:Call KERNEL32.GetProcAddress(7e280000,0040207c "AllocateAndGetTcpExTableFromStack") ret=00401082 004d:Ret KERNEL32.GetProcAddress() retval=00000000 ret=00401082 004d:Call KERNEL32.GetProcAddress(7e280000,0040209e "GetExtendedTcpTable") ret=004010ae 004d:Ret KERNEL32.GetProcAddress() retval=7e28fdd8 ret=004010ae
Looks like it falls back to GetExtendedTcpTable though. Does the app really need AllocateAndGetTcpExTableFromStack?
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #13 from Anastasius Focht focht@gmx.net --- Hello Hans,
--- quote --- Looks like it falls back to GetExtendedTcpTable though. Does the app really need AllocateAndGetTcpExTableFromStack? --- quote ---
No, it doesn't need it (puts itself into systray after startup).
For me it was easier to find another pre-built app using that API call instead of going through the hassle of cross-compiling the stuff from OP's initial comment (very little info provided, not even instructions how to exactly reproduce).
One could argue to change the bug title to "want" instead of "need" though.
Regards
https://bugs.winehq.org/show_bug.cgi?id=34372
Erich E. Hoover erich.e.hoover@wine-staging.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |erich.e.hoover@wine-staging | |.com
--- Comment #14 from Erich E. Hoover erich.e.hoover@wine-staging.com --- (In reply to Hans Leidekker from comment #12)
... Looks like it falls back to GetExtendedTcpTable though. Does the app really need AllocateAndGetTcpExTableFromStack?
There are probably other apps that were discontinued before Vista that would want the routine. I honestly don't remember what I was testing when I ran into this originally. Unfortunately it wasn't either one of these apps and I didn't add it to the bug :/
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #15 from Hans Leidekker hans@meelstraat.net --- (In reply to Erich E. Hoover from comment #14)
(In reply to Hans Leidekker from comment #12)
... Looks like it falls back to GetExtendedTcpTable though. Does the app really need AllocateAndGetTcpExTableFromStack?
There are probably other apps that were discontinued before Vista that would want the routine. I honestly don't remember what I was testing when I ran into this originally. Unfortunately it wasn't either one of these apps and I didn't add it to the bug :/
Then let's wait until we find one. Adding this function can cause apps to take a different path on Wine.
https://bugs.winehq.org/show_bug.cgi?id=34372
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/iphlpapi-TCP_T |er/patches/iphlpapi-TCP_Tab |able |le
https://bugs.winehq.org/show_bug.cgi?id=34372
Marcus Meissner marcus@jet.franken.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcus@jet.franken.de
https://bugs.winehq.org/show_bug.cgi?id=34372
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest@gmail.com
--- Comment #16 from Vijay Kamuju infyquest@gmail.com --- any applications that need this api? I cannot download the application that's specified in this bug.
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #17 from Ralf Habacker ralf.habacker@freenet.de --- A portable dbus package could be downloaded from https://download.opensuse.org/repositories/home:/rhabacker:/branches:/window...
The mentioned function is used at https://github.com/d-bus/dbus/blob/master/dbus/dbus-sysdeps-win.c#L109 and following.
See https://github.com/d-bus/dbus/commit/2fd9e2c2559991295649635969464772bb6fd1e... for the reason this function has been added.
https://bugs.winehq.org/show_bug.cgi?id=34372
--- Comment #18 from Ralf Habacker ralf.habacker@freenet.de --- (In reply to Ralf Habacker from comment #17)
A portable dbus package could be downloaded from https://download.opensuse.org/repositories/home:/rhabacker:/branches:/ windows:/mingw:/win32/openSUSE_Leap_42.3/noarch/mingw32-dbus-1-portable-1.12. 12.77c650f41.12.10-37.1.noarch.rpm
After unpacking the rpm file with 7z on Windows and opening a command shell, running the command 'qdbus' should trigger the related code (with WINXP SP2 compatibility set)
https://bugs.winehq.org/show_bug.cgi?id=34372
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |05fca48ebc1321984a74ed11dc9 | |c1f13a2cfd1ee Resolution|--- |FIXED Status|STAGED |RESOLVED CC| |leslie_alistair@hotmail.com
--- Comment #19 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=05fca48ebc1321984a74ed11d...
https://bugs.winehq.org/show_bug.cgi?id=34372
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.8.