[Bug 57072] New: Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

Bug ID: 57072
           Summary: Window is flashing when painting transluent effects
           Product: Wine
           Version: 9.15
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 46c8a637525d0f1cf67830295fb460c819b800b6
      Distribution: ---

An application that I have here draws transluent effects when mouse moves over
some of its text items and that leads to huge flashing. It looks like top level
window is constantly recreated. This is a regression caused by

commit 46c8a637525d0f1cf67830295fb460c819b800b6
Author: Elizabeth Figura 
Date:   Fri Jan 20 16:23:42 2023 -0600

winex11: Separately store the internal pixel format set by
WGL_WINE_pixel_format_passthrough.

Reverting just single line of this commit

@@ -1402,12 +1402,12 @@ static BOOL set_win_format( HWND hwnd, const struct
wgl_
pixel_format *format, BO
     XFlush( gdi_display );
     release_gl_drawable( gl );

-    win32u_set_window_pixel_format( hwnd, pixel_format_index( format ), FALSE
)
;
+    win32u_set_window_pixel_format( hwnd, pixel_format_index( format ),
interna
l );

completely fixes the problem. Could that be an inadvertent change or oversight?

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

--- Comment #1 from Zeb Figura  ---
No, that's pretty much the point of the change. Specifically, as described in
https://gitlab.winehq.org/wine/wine/-/merge_requests/2217, we want wined3d to
be able to set the "internal" pixel format while still knowing whether the
application has set the "public" pixel format.

I can try to debug from a +gdi,+wgl,+d3d,+ddraw,+d3d8,+d3d9,+d3d11 log,
although without access to the application I'm not sure I'll be able to figure
out what's wrong.

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

--- Comment #2 from Dmitry Timoshkov  ---
(In reply to Zeb Figura from comment #1)
> No, that's pretty much the point of the change. Specifically, as described
> in https://gitlab.winehq.org/wine/wine/-/merge_requests/2217, we want
> wined3d to be able to set the "internal" pixel format while still knowing
> whether the application has set the "public" pixel format.
>
> I can try to debug from a +gdi,+wgl,+d3d,+ddraw,+d3d8,+d3d9,+d3d11 log,
> although without access to the application I'm not sure I'll be able to
> figure out what's wrong.

I could privately provide an archive with the application and instructions how
to setup a prefix. Just let me know how to share it with you.

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

--- Comment #3 from Zeb Figura  ---
(In reply to Dmitry Timoshkov from comment #2)
> (In reply to Zeb Figura from comment #1)
> > No, that's pretty much the point of the change. Specifically, as described
> > in https://gitlab.winehq.org/wine/wine/-/merge_requests/2217, we want
> > wined3d to be able to set the "internal" pixel format while still knowing
> > whether the application has set the "public" pixel format.
> >
> > I can try to debug from a +gdi,+wgl,+d3d,+ddraw,+d3d8,+d3d9,+d3d11 log,
> > although without access to the application I'm not sure I'll be able to
> > figure out what's wrong.
>
> I could privately provide an archive with the application and instructions
> how to setup a prefix. Just let me know how to share it with you.

Sure, if email works for you please go ahead and send me one. Alternatively I
can at least give the log a try first.

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

--- Comment #4 from Zeb Figura  ---
The application is constantly rendering to two different swapchains on two
different windows. wined3d keeps track of whether it has set the internal pixel
format on a swapchain, but that's a per-context flag and when the context
switches windows it needs to be invalidated.

We should avoid redundantly setting the pixel format, or at least recreating
the GL drawable when the pixel format is set redundantly. I'm not sure that
explains why flickering happens though; I'd only expect it to have performance
implications?

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8923eb51ea56329bfccd572b95b
                   |                            |80175352d3b55
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Dmitry Timoshkov  ---
After 8923eb51ea56329bfccd572b95b80175352d3b55 I can't reproduce flickering.

[Bug 57072] Window is flashing when painting transluent effects

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57072

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 9.22.