[Bug 17436] New: Missing funtionality prevents any RDP client from working.

http://bugs.winehq.org/show_bug.cgi?id=17436

Summary: Missing funtionality prevents any RDP client from
                    working.
           Product: Wine
           Version: 1.1.14
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I have attempted to run a couple of RDP clients and they all fail with the same
error being repeated a few thousand times. Obviously this stub needs to be
fleshed out.

I wish I could do it myself but I can't.

fixme:winsock:WSALookupServiceNextW ((nil) 0x00000ff0 0x7c1b3688 0x5a9d7b8)
Stub!

[Bug 17436] Missing funtionality prevents any RDP client from working.

http://bugs.winehq.org/show_bug.cgi?id=17436

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

--- Comment #1 from Jeff Zaroyko   2009-02-17 16:58:28 ---
Not critical.  http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity

Which application is this?

[Bug 17436] Missing funtionality prevents any RDP client from working.

http://bugs.winehq.org/show_bug.cgi?id=17436

--- Comment #2 from Tim Uckun   2009-02-17 19:08:12 ---
I tried it with both mRemote and Terminals.

Both of them failed in the same spot with the same message being repeated over
and over again.

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.mremote.org/wiki/
                   |                            |Downloads.ashx
           Keywords|                            |download
            Summary|Missing funtionality        |mRemote does not work
                   |prevents any RDP client from|
                   |working.                    |

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

--- Comment #3 from Tim Uckun   2009-02-18 14:50:44 ---
For terminals see

http://www.codeplex.com/Terminals

BTW I had to manually install the terminal server client into wine. That was a
bit of a pain but I did a while back so I don't remember everything I did.

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

--- Comment #4 from Austin English  2010-09-09 02:14:06 CDT ---
Still a stub.

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Michael Schreiner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Michael Schreiner  2010-10-24 14:29:32 CDT ---
I just tried RDP V7 from recent Windows 7 32 bit on Wine 1.2.1 and got the same
error.

To reproduce just copy:
system32\dwmapi.dll
system32\mstsc.exe
system32\mstscax.dll
system32<LANG_NAME>\mstsc.exe.mui
system32<LANG_NAME>\mstscax.dll.mui

and start mstsc.exe

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Louis Lenders  2010-10-25 13:48:55 CDT ---
(In reply to comment #5)
> I just tried RDP V7 from recent Windows 7 32 bit on Wine 1.2.1 and got the same
> error.
>
> To reproduce just copy:
> system32\dwmapi.dll
> system32\mstsc.exe
> system32\mstscax.dll
> system32<LANG_NAME>\mstsc.exe.mui
> system32<LANG_NAME>\mstscax.dll.mui
>
> and start mstsc.exe

Is there a way we can test this? I copied the files and now a need a computer
to connect to, to reproduce the bug. Anyone know one?
Also there's a crash in unimplemented function in dwmapi. I'll send a patch for
that

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

--- Comment #7 from Louis Lenders  2010-10-26 15:40:26 CDT ---
(In reply to comment #5)
> I just tried RDP V7 from recent Windows 7 32 bit on Wine 1.2.1 and got the same
> error.
>
> To reproduce just copy:
> system32\dwmapi.dll

The native dwmapi is not necessary anymore, i stubbed out the unimplemented
function.

Hi Michael, could you describe what exactly the error now is? I have an address
of a server from my work where i can logon and test, and I also see a lot of
calls to WSALookupServiceNextW, but I was able to login and work on the remote
desktop anyway. Apart from that it works, WSALookupServiceNext should return a
SOCKET_ERROR after a few calls anyway, as from the description on msdn and some
code bits i found, this is called in a while-loop, until all data is retrieved,
and than it should return SOCKET_ERROR with LastError WSA_E_NO_MORE

The patch below fakes this. I'll see if i can write some tests better stub for
this function

There's also a bug closing the app, then it runs into 2 other unimplemented
fundtions. I'll see if i can stub these out as well

diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c
index 66726a7..9b60d54 100644
--- a/dlls/ws2_32/socket.c
+++ b/dlls/ws2_32/socket.c
@@ -6340,9 +6340,10 @@ INT WINAPI WSALookupServiceNextA( HANDLE lookup, DWORD
fl
  *              WSALookupServiceNextW                       (WS2_32.63)
  */
 INT WINAPI WSALookupServiceNextW( HANDLE lookup, DWORD flags, LPDWORD len,
LPWS
-{
+{   static int i=0;
+    
     FIXME( "(%p 0x%08x %p %p) Stub!\n", lookup, flags, len, results );
-    return 0;
+    if(!i) {i++; return 0;} else {WSASetLastError(WSA_E_NO_MORE); return
SOCKET
 }

/***********************************************************************
(END)

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Louis Lenders  2010-10-28 17:59:03 CDT ---
commit cb65dbf3d84f64d8275d853bb75e17fbf64b23c7
 prevents the remote desktop app from running into the infinite loop. The
application mstsc.exe works fine for me afaics.

As i didn't get any response to my questions about further problems with the
app , I'm resolving this as fixed; if anyone still runs into trouble please
reopen or open a new bugreport

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2010-10-29 12:58:42 CDT ---
Closing bugs fixed in 1.3.6.

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.x

[Bug 17436] mRemote does not work

http://bugs.winehq.org/show_bug.cgi?id=17436

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.2.x                       |---

--- Comment #10 from Alexandre Julliard  2010-12-03 12:51:54 CST ---
Removing 1.2.x milestone from bugs included in 1.2.2.