[Bug 41627] New: MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

Bug ID: 41627
           Summary: MS Word 2010 crash when exiting on Wine stable 1.8.5.
           Product: Wine
           Version: 1.8.5
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: msctf
          Assignee: [e-mail]
          Reporter: [e-mail]
   Regression SHA1: 18eda5e82a5b92a5f22ccfcfd446ed288341fc1bmsc
      Distribution: ---

Created attachment 55987
  --> https://bugs.winehq.org/attachment.cgi?id=55987
Log with +tid+msctf+richedit+eventlog channel.

This is a regression in Wine 1.8.5, it is fine when 1.8.4.

Steps for reproducing:
1. Install MS Office 2010 when Wine 1.8.5 and set riched20.dll as 'using native
first';
2. Run Word and try to exit it or save a file. And it will crash.

By a `git bisect` I find this was included by
18eda5e82a5b92a5f22ccfcfd446ed288341fc1b.
And this bug can't be reproduced by current Wine development.

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=14980
                 CC|                            |[e-mail]

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|18eda5e82a5b92a5f22ccfcfd44 |18eda5e82a5b92a5f22ccfcfd44
                   |6ed288341fc1bmsc            |6ed288341fc1b

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

--- Comment #1 from Michael Stefaniuc  ---
I don't have MS Office 2010 so could you please try to cherry pick this commit
that Nikolay recommended?

commit 79025d0e6af8189fd6c3360c5bd335954124c205
Author: Jacek Caban 
Date:   Fri May 27 18:35:24 2016 +0200

msctf: Don't call ITextStoreACP::UnadviseSink in context destructor.

I don't see a crash in the attached log but I see tons of Context_Destructor()
calls and the above patch is for that function.
Sadly the test that Jacek added for the above commit doesn't crashes without
that patch.

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

--- Comment #2 from Jactry Zeng  ---
Hi,
(In reply to Michael Stefaniuc from comment #1)
> I don't have MS Office 2010 so could you please try to cherry pick this
> commit that Nikolay recommended?
>
> commit 79025d0e6af8189fd6c3360c5bd335954124c205
> Author: Jacek Caban 
> Date:   Fri May 27 18:35:24 2016 +0200
> msctf: Don't call ITextStoreACP::UnadviseSink in context destructor.
>
>
> I don't see a crash in the attached log but I see tons of
> Context_Destructor() calls and the above patch is for that function.
> Sadly the test that Jacek added for the above commit doesn't crashes without
> that patch.

Yes, Jacek's patch can fix this bug.

Thanks!

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

--- Comment #3 from Michael Stefaniuc  ---
Thanks for testing! I have staged the patch for 1.8.6.

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.x

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6a1ac3e31c43debc83d8689f974
                   |                            |0a6565402e51a
             Status|NEW                         |RESOLVED

--- Comment #4 from Michael Stefaniuc  ---
The fix is included in 1.8.6 as 6a1ac3e31c43debc83d8689f9740a6565402e51a

[Bug 41627] MS Word 2010 crash when exiting on Wine stable 1.8.5.

https://bugs.winehq.org/show_bug.cgi?id=41627

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Michael Stefaniuc  ---
Closing bugs fixed in 1.8.6.