https://bugs.winehq.org/show_bug.cgi?id=40112
Bug ID: 40112 Summary: kernel32:time regression Product: Wine Version: 1.9.3 Hardware: x86 OS: Windows Status: NEW Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
The commit below does not take locale into account and thus introduced a test failure on non-English systems such as fg-acer64.
Failures: time.c:965: Test failed: Expected StandardName L"Greenland Standard Time", got L"Groenland" time.c:972: Test failed: Expected DaylightName L"Greenland Daylight Time", got L"Groenland (heure d\2019\00e9t\00e9)"
kernel32:time results on test.winehq.org: https://test.winehq.org/data/tests/kernel32:time.html
commit 2e3ce3a37d08c022ddfbfb751432c2ed37354429 Author: Vincent Povirk vincent@codeweavers.com Date: Fri Jan 29 14:31:26 2016 -0600
kernel32/tests: Add tests for GetTimeZoneInformationForYear.
Signed-off-by: Vincent Povirk vincent@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=40112
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source, testcase URL| |https://test.winehq.org/dat | |a/tests/kernel32:time.html Regression SHA1| |2e3ce3a37d08c022ddfbfb75143 | |2c2ed37354429
https://bugs.winehq.org/show_bug.cgi?id=40112
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
--- Comment #1 from Vincent Povirk madewokherd@gmail.com --- I wasn't expecting the string to be localized.
This isn't really the important part of the test, since it's not dependent on year, so maybe we can limit this particular check to English locale, or remove it? Or, we could check that the names for two different years in this timezone match.
Thoughts?
https://bugs.winehq.org/show_bug.cgi?id=40112
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=40112
--- Comment #2 from Vincent Povirk madewokherd@gmail.com --- Can someone try this on a non-English Windows 8 or Windows 10? http://testbot.winehq.org/JobDetails.pl?Key=20335
https://bugs.winehq.org/show_bug.cgi?id=40112
--- Comment #3 from François Gouget fgouget@codeweavers.com --- That works:
time.c:263: tz_id 1 (TIME_ZONE_ID_STANDARD) time.c:271: bias -60, Paris, Madrid - Paris, Madrid (heure d��t�) time.c:272: standard (d/m/y): 5/10/0000 day of week 0 3:00:00.000 bias 0 time.c:278: daylight (d/m/y): 5/03/0000 day of week 0 2:00:00.000 bias -60 time.c:847: Number of Processors : 4 time.c:765: Dyn TimeZoneKeyName L"Romance Standard Time" time: 886 tests executed (0 marked as todo, 0 failures), 0 skipped.
https://bugs.winehq.org/show_bug.cgi?id=40112
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #4 from Sebastian Lackner sebastian@fds-team.de --- This should be fixed with http://source.winehq.org/git/wine.git/commit/82a55e7bf8c8fb15950c29b108e336e....
https://bugs.winehq.org/show_bug.cgi?id=40112
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #5 from Wylda wylda@volny.cz --- (In reply to Sebastian Lackner from comment #4)
This should be fixed with ...
François?
https://bugs.winehq.org/show_bug.cgi?id=40112
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #6 from François Gouget fgouget@codeweavers.com --- Yes, this is fixed.
https://bugs.winehq.org/show_bug.cgi?id=40112
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |82a55e7bf8c8fb15950c29b108e | |336e0b686739b
https://bugs.winehq.org/show_bug.cgi?id=40112
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.9.
https://bugs.winehq.org/show_bug.cgi?id=40112
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x CC| |mstefani@redhat.com
https://bugs.winehq.org/show_bug.cgi?id=40112
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |---
--- Comment #8 from Michael Stefaniuc mstefani@redhat.com --- Removing 1.8.x milestone from bugs included in 1.8.7.
-
wine-bugs＠winehq.org