https://bugs.winehq.org/show_bug.cgi?id=43740
Bug ID: 43740 Summary: Just Cause 2 GenerateMips fails Product: Wine-staging Version: 2.17 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: byi5000@gmail.com CC: erich.e.hoover@wine-staging.com, michael@fds-team.de, sebastian@fds-team.de Distribution: ---
(Since this is about a wine-staging patch, i selected wine-staging)
Since 2.17-staging we have this patch (https://dev.wine-staging.com/patches/190/). It fixed the GenerateMips for (some,most?) directx11 games, but it is missing for directx10. Just Cause 2 reports fixme:d3d11:d3d10_device_GenerateMips iface 0x3625c24, shader_resource_view 0xc61eb74 stub!
It *should* be very much the same function just with other structs i guess the missing dx10 function is at https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/d3d11/device.c#l4175
we already have unsafe_impl_from_ID3D10ShaderResourceView at https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/d3d11/view.c#l2338
but i wasn't able to locate the equivalent of device_from_immediate_ID3D11DeviceContext (at https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/d3d11/device.c#l42) for directx10
but i gonna leave that to the real programmers anyway ;)
https://bugs.winehq.org/show_bug.cgi?id=43740
Michael Müller michael@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |directx-d3d Product|Wine-staging |Wine Summary|Just Cause 2 GenerateMips |GenerateMips not |fails |implemented for d3d10 (Just | |Cause 2)
--- Comment #1 from Michael Müller michael@fds-team.de --- I think the Wine product is more suitable, as this bug affects the development version as well as the staging version. Both codebases simply do not implement the feature for d3d10 and the linked patch does not really change this.
Anyway, as you mentioned the patch should make it pretty trivial to add the necessary code for d3d10. I will take a look at this later and provide a link to a patch that you can test.
https://bugs.winehq.org/show_bug.cgi?id=43740
--- Comment #2 from BieHDC byi5000@gmail.com --- (In reply to Michael Müller from comment #1)
I think the Wine product is more suitable, as this bug affects the development version as well as the staging version. Both codebases simply do not implement the feature for d3d10 and the linked patch does not really change this.
Anyway, as you mentioned the patch should make it pretty trivial to add the necessary code for d3d10. I will take a look at this later and provide a link to a patch that you can test.
ok, i am going to remember that for future cases
thank you
https://bugs.winehq.org/show_bug.cgi?id=43740
--- Comment #3 from Michael Müller michael@fds-team.de --- You can test https://dev.wine-staging.com/patches/191/. Just apply the patch on top of Wine Staging 2.17.
https://bugs.winehq.org/show_bug.cgi?id=43740
--- Comment #4 from BieHDC byi5000@gmail.com --- (In reply to Michael Müller from comment #3)
You can test https://dev.wine-staging.com/patches/191/. Just apply the patch on top of Wine Staging 2.17.
can we please do it like last time where you let the build bot generate the custom wine-staging version? that worked pretty well.
https://bugs.winehq.org/show_bug.cgi?id=43740
--- Comment #5 from BieHDC byi5000@gmail.com --- (In reply to Michael Müller from comment #3)
You can test https://dev.wine-staging.com/patches/191/. Just apply the patch on top of Wine Staging 2.17.
ok, i finally got my stuff together and compiled it. Works fine for Just Cause 2 and you can feel the improvement. Thank you!
https://bugs.winehq.org/show_bug.cgi?id=43740
--- Comment #6 from Gijs Vermeulen gijsvrm@gmail.com --- This was fixed upstream by: https://source.winehq.org/git/wine.git/commitdiff/bb3b55ce22f96d443c2053f6b1...
https://bugs.winehq.org/show_bug.cgi?id=43740
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |bb3b55ce22f96d443c2053f6b1e | |b24e087ca1377 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED CC| |joseph.kucia@gmail.com
--- Comment #7 from Józef Kucia joseph.kucia@gmail.com --- Fixed.
https://bugs.winehq.org/show_bug.cgi?id=43740
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.3.
-
wine-bugs＠winehq.org