https://bugs.winehq.org/show_bug.cgi?id=43256
Bug ID: 43256 Summary: Civilization V in-game font corrupted Product: Wine Version: 2.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 Assignee: wine-bugs@winehq.org Reporter: olelukoie@mail.ru Distribution: ---
Created attachment 58574 --> https://bugs.winehq.org/attachment.cgi?id=58574 The «good» screenshot with proper font rendering
I had not played Windows version of Civ5 under WINE for some time but recently started it and discovered that the font in the game is completely broken and mostly unreadable (at least Russian font).
git bisect showed me that the corruption occurred back in 2014, was introduced in two steps by the following commits.
The first one (causes slight mostly unnoticed font breakage):
e9188970a78336358c7f160d78c5705ab230c974 is the first bad commit commit e9188970a78336358c7f160d78c5705ab230c974 Author: Akihiro Sagawa sagawa.aki@gmail.com Date: Fri Jan 10 20:29:54 2014 +0900
gdi32: Fix sub-pixel shift calculations for vertical writing.
:040000 040000 1cf54dfea5297e2d8da3cc7fd584ac0253705791 da7d8759bed1313f48e668a7040fba21ba66778a M dlls
The second one (causes hard font breakage):
e06d2dbc6772bf4f038847f2c7825ecdefcf4b90 is the first bad commit commit e06d2dbc6772bf4f038847f2c7825ecdefcf4b90 Author: Akihiro Sagawa sagawa.aki@gmail.com Date: Fri Jan 24 01:47:54 2014 +0900
gdi32: Fix regression due to sub-pixel shift calculations fixes.
:040000 040000 9fb50c914ef8feb1e6c3d4dd19604afe3497d337 9daba6ef96a68d36c1646c75bc8e03b6b63dbb81 M dlls
See the attached screenshots for demonstration. The first screenshot shows the proper font rendering in WINE 1.6. The second one shows slight corruption after the first commit (look at the bottom-left corner of Russian letter «д» in the bottom text «Нажмите, чтобы продолжить»: the vertical bottom stroke is missing). The third one is a picture of current font rendering caused by the second commit. All the right vertical strokes in all glyphs are completely missing.
https://bugs.winehq.org/show_bug.cgi?id=43256
olelukoie olelukoie@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |olelukoie@mail.ru
--- Comment #1 from olelukoie olelukoie@mail.ru --- Created attachment 58575 --> https://bugs.winehq.org/attachment.cgi?id=58575 Screenshot with slight font corruption after the first commit
https://bugs.winehq.org/show_bug.cgi?id=43256
--- Comment #2 from olelukoie olelukoie@mail.ru --- Created attachment 58576 --> https://bugs.winehq.org/attachment.cgi?id=58576 The «bad» screenshot with broken font rendering
https://bugs.winehq.org/show_bug.cgi?id=43256
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #3 from winetest@luukku.com --- Could you also check bug 24518? It's so closely related to this. Also checking other civilization bugs while you have the game still installed would help.
https://bugs.winehq.org/show_bug.cgi?id=43256
olelukoie olelukoie@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Other Regression SHA1| |e06d2dbc6772bf4f038847f2c78 | |25ecdefcf4b90
https://bugs.winehq.org/show_bug.cgi?id=43256
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gijsvrm@gmail.com, | |sagawa.aki+winebugs@gmail.c | |om
https://bugs.winehq.org/show_bug.cgi?id=43256
--- Comment #4 from Sagawa sagawa.aki+winebugs@gmail.com --- Thanks for reporting. I'll take a look. However, I don't have Civ5. Is Russian demo available to download?
https://bugs.winehq.org/show_bug.cgi?id=43256
--- Comment #5 from olelukoie olelukoie@mail.ru --- (In reply to Sagawa from comment #4)
Is Russian demo available to download?
No, I think demo only supports English, German, Spanish, Italian and French. All the other languages (Russian, Polish, Chinese, Korean, Japanese) were added later to the full game but demo was not updated.
https://bugs.winehq.org/show_bug.cgi?id=43256
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=43256
--- Comment #6 from Sagawa sagawa.aki+winebugs@gmail.com --- Created attachment 60282 --> https://bugs.winehq.org/attachment.cgi?id=60282 proposed patch
Could you try this patch before my submission? I found out the cause of this issue at last. It seems to be a regression in f6bc356860a1ea2e5b4aed43e38ddf8b7d24a8b0.
Actually, I found another issue about this procedure. So, I'll prepare an additional patch in this weekend and send both of them in the first half of the next week.
https://bugs.winehq.org/show_bug.cgi?id=43256
--- Comment #7 from Sagawa sagawa.aki+winebugs@gmail.com --- I made a revised patch and sent it: https://source.winehq.org/patches/data/141157
https://bugs.winehq.org/show_bug.cgi?id=43256
--- Comment #8 from olelukoie olelukoie@mail.ru --- I've tested current git snapshot of WINE and it seems like the problem is fixed. All glyphs are drawn correctly.
Thank you very much!
https://bugs.winehq.org/show_bug.cgi?id=43256
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2a402a427a7d3bad1ea8043b9d7 | |db011727cbc6b Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #9 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to olelukoie from comment #8)
I've tested current git snapshot of WINE and it seems like the problem is fixed. All glyphs are drawn correctly.
Thank you very much!
Glad it works now, thanks for reporting back :)
https://bugs.winehq.org/show_bug.cgi?id=43256
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 3.2.
https://bugs.winehq.org/show_bug.cgi?id=43256
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x
https://bugs.winehq.org/show_bug.cgi?id=43256
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---
--- Comment #11 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bugs included in 3.0.1.
-
wine-bugs＠winehq.org