[Bug 28557] New: Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Bug #: 28557
           Summary: Notepad++ does not receive drag+drop files in KDE,
                    seems to work in GNOME
           Product: Wine
           Version: 1.3.28
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

When trying to drag+drop files into notepad++, it doesn't open the file... it
just sits there. Currently using Ubuntu 11.10 with KDE Plasma installed. Some
debugging output..

WINEDEBUG=+channel1,+channel2 wine notepad++.exe 
fixme:xdnd:X11DRV_XDND_DROPEFFECTToXdndAction unknown drop effect 0, assuming
XdndActionCopy
fixme:xdnd:X11DRV_XDND_DROPEFFECTToXdndAction unknown drop effect 0, assuming
XdndActionCopy

[the preceding lines happens many many times]

Thanks!

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] 2012-07-27 21:59:28 CDT ---
Confirmable/reproducable in wine 1.5.9

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Simon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

kendzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from kendzi  ---
Drag and drop is not working with Ubuntu 13.10 and Unity.

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://notepad-plus-plus.or
                   |                            |g/download/
           Severity|normal                      |minor

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |integration, source

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Brandon Corujo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1

--- Comment #3 from Damjan Jovanovic  ---
Confirming. With WINEDEBUG='+xdnd' we see how Notepad++ only looks for
CF_UNICODETEXT and CF_TEXT, which is why dragging text into it works, but
dragging a file doesn't. Neither Thunar, Caja nor Konqueror work for me.

But why?

The source seems to show it using CF_HDROP in only one place, but it does use
WM_DROPFILES. A +shell trace shows it calling:
trace:shell:DragQueryPoint
which is called from PowerEditor/src/Notepad_plus.cpp:
--snip--
void Notepad_plus::dropFiles(HDROP hdrop)
{
        if (hdrop)
        {
                // Determinate in which view the file(s) is (are) dropped
                POINT p;
                ::DragQueryPoint(hdrop, &p);
                HWND hWin =
::RealChildWindowFromPoint(_pPublicInterface->getHSelf(), p);
                if (!hWin) return;

if ((_mainEditView.getHSelf() == hWin) ||
(_mainDocTab.getHSelf() == hWin))
                        switchEditViewTo(MAIN_VIEW);
                else if ((_subEditView.getHSelf() == hWin) ||
(_subDocTab.getHSelf() == hWin))
                        switchEditViewTo(SUB_VIEW);
                else
                {
                        ::SendMessage(hWin, WM_DROPFILES, (WPARAM)hdrop, 0);
                        return;
                }

int filesDropped = ::DragQueryFile(hdrop, 0xffffffff, NULL, 0);
--snip--

Since we see DragQueryPoint() getting called, but not DragQueryFile(), maybe
the point is wrong and the function returns early?

Indeed: since Notepad++ ignores the return value of DragQueryPoint(), and
passes the returned point directly to RealChildWindowFromPoint(), the point
must be in client coordinates. Patching Wine to send WM_DROPFILES with
DROPFILES.pt in client coordinates and fNC set to false fixes this bug, see the
patch at http://source.winehq.org/patches/data/105219 which I've already
submitted.

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

http://bugs.winehq.org/show_bug.cgi?id=28557

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |846a8f6c8dcf7ad0bc72437d7ea
                   |                            |79cc9e00c8ab7
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Damjan Jovanovic  ---
Resolving FIXED by commit 846a8f6c8dcf7ad0bc72437d7ea79cc9e00c8ab7.

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

https://bugs.winehq.org/show_bug.cgi?id=28557

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.23.

[Bug 28557] Notepad++ does not receive drag+drop files in KDE, seems to work in GNOME

https://bugs.winehq.org/show_bug.cgi?id=28557

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |winex11.drv