[Bug 32277] New: No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Bug #: 32277
           Summary: No sound in Star Wars: Knights of the Old Republic
           Product: Wine
           Version: 1.5.18
          Platform: x86
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dsound
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

After upgrading to 1.5.18 (I've also tried a new prefix), there is no sound in
Star Wars: Knights of the Old Republic (Steam version); sound worked in 1.5.17
and 1.5.16.

Additionally, the following line only appears in the console on 1.5.18:

fixme:dsound:DSOUND_WaveFormat Limiting channels to 2 due to lack of
multichannel support

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Dan Kegel  2012-11-23 22:31:02 CST ---
If you can rebuild wine from sources, please do a regression test to find
out which commit broke sound.
http://wiki.winehq.org/RegressionTesting

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

--- Comment #2 from [e-mail] 2012-11-24 00:11:35 CST ---
It was broken in 605cd62c7dc84ef86cbd260139c6875cd0ed8d60.
(http://source.winehq.org/git/wine.git/commit/605cd62c7dc84ef86cbd260139c6875...)

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |605cd62c7dc84ef86cbd260139c
                   |                            |6875cd0ed8d60

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Maarten Lankhorst  2012-11-24 10:16:42 CST ---
Wee got to love not having the full dsound series applied in 1 go, ok.. lets
see what broke here..

WINEDEBUG=tid,dsound

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

--- Comment #4 from [e-mail] 2012-11-24 14:52:40 CST ---
Created attachment 42603
  --> http://bugs.winehq.org/attachment.cgi?id=42603
+tid,+dsound

Here's a log of going through the opening videos, main menu, and walking around
for a bit in a saved game.

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1

--- Comment #5 from Maarten Lankhorst  2012-11-26 03:50:59 CST ---
Looks like IsFormatSupported for winecoreaudio is too strict. From my testing
it should support dwChannelMask having more channels set than used.

For example if dwChannels = 2 and dwChannelMask = SPEAKER_FRONT_LEFT |
SPEAKER_FRONT_RIGHT | SPEAKER_FRONT_CENTER it's valid, and only first 2
speakers should be used.

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

--- Comment #6 from Maarten Lankhorst  2012-11-26 03:51:39 CST ---
Created attachment 42623
  --> http://bugs.winehq.org/attachment.cgi?id=42623
winecoreaudio patch

This should fix it..

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

--- Comment #7 from [e-mail] 2012-11-26 16:31:35 CST ---
(In reply to comment #6)
> Created attachment 42623 [details]
> winecoreaudio patch
>
> This should fix it..

Confirmed, that does indeed fix it! I also tried testing an unpatched 1.5.18
with a 2-channel layout instead of 6 and it also worked, so it looks like your
analysis was correct. Thanks!

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

--- Comment #8 from [e-mail] 2012-11-26 16:34:18 CST ---
As a side note, I'm still getting the AQMixerDevice::SetMixerChannelLayout:
scope 2, element 0, layout: tag=0x650002: error -10851 thing in the console
with a 6 channel layout, but not a 2-channel layout. Maybe wine is mapping
something wrong in the coreaudio driver? I tried playing some 6-channel movies
in VirtualDub and the layout seemed correct, so I'm not really sure where the
error is there (although that doesn't use dsound afaik).

Either way, it seems benign; just thought it'd make a note of it.

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Maarten Lankhorst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |32297

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |79084be3c176e169d4f45391a7a
                   |                            |566867c9c8f7d
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Austin English  2012-11-27 15:08:25 CST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Created attachment 42623 [details]
> > winecoreaudio patch
> >
> > This should fix it..
>
> Confirmed, that does indeed fix it! I also tried testing an unpatched 1.5.18
> with a 2-channel layout instead of 6 and it also worked, so it looks like your
> analysis was correct. Thanks!

http://source.winehq.org/git/wine.git/commitdiff/79084be3c176e169d4f45391a7a...

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

http://bugs.winehq.org/show_bug.cgi?id=32277

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  2012-12-07 13:36:12 CST ---
Closing bugs fixed in 1.5.19.

[Bug 32277] No sound in Star Wars: Knights of the Old Republic

https://bugs.winehq.org/show_bug.cgi?id=32277
Bug 32277 depends on bug 32297, which changed state.

Bug 32297 Summary: dwChannelMask, nAvgBytesPerSec and nBlockAlign handled incorrectly by mmdevapi drivers in IsFormatSupported.
https://bugs.winehq.org/show_bug.cgi?id=32297

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED