https://bugs.winehq.org/show_bug.cgi?id=48087
Bug ID: 48087 Summary: Firestorm viewer can't login to Second Life grid since 4.19 Product: Wine Version: 4.19 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: randrianasulu@gmail.com Distribution: ---
Created attachment 65645 --> https://bugs.winehq.org/attachment.cgi?id=65645 bisect log
Regression happened, but I had few older versions of wine around. Bisect point at:
0a89a699135802b083d142130d3b0ef618485478 is the first bad commit commit 0a89a699135802b083d142130d3b0ef618485478 Author: Erich E. Hoover erich.e.hoover@gmail.com Date: Wed Oct 16 16:09:16 2019 -0600
msvcrt: Fix fscanf return when EOF is immediately after an end of line.
Signed-off-by: Erich E. Hoover erich.e.hoover@gmail.com Signed-off-by: Piotr Caban piotr@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
:040000 040000 0ab968b592ecea82a446a1f9ea6726a164fd5327 8e66c58dd2bee2820b3ab2b619a0f0e402472657 M dlls
I have this info as reported by Firestorm:
Firestorm 6.3.2.58052 (Firestorm-Release 32bit) Заметки о выпуске
CPU: AMD FX(tm)-4300 Quad-Core Processor (3800.11 MHz) Память RAM: 11877 MB Версия ОС: Microsoft Windows 10 32-bit (Build 17134) Производитель видеокарты: nouveau Видеокарта: NV92
Версия графического драйвера Windows: 1.0 Версия OpenGL: 3.3 (Compatibility Profile) Mesa 20.0.0-devel (git-bc80900b6c)
I also tried to leave profile at win7-32bit, or start from fresh profile.
https://bugs.winehq.org/show_bug.cgi?id=48087
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |0a89a699135802b083d142130d3 | |b0ef618485478 CC| |erich.e.hoover@gmail.com, | |piotr@codeweavers.com Component|-unknown |msvcrt Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #1 from Erich E. Hoover erich.e.hoover@gmail.com --- Andrew,
Thanks for doing a bisect, that's very helpful! There's a couple possibilities here: 1) your application is using one of the msvcrt versions that's "broken" and I didn't catch that case 2) the string your application is passing has some sort of other special case in it
With respect to the first one, would you mind using Dependency Walker (http://www.dependencywalker.com/) to see which msvcr* library the program is using? (usually this is something like msvcr90 or msvcr100, but it can also be ucrtbase)
With the second case you should be able to run the application with WINEDEBUG="+msvcrt" and look for scanf. For example: WINEDEBUG="+msvcrt" wine myprogram.exe 2>&1 | grep scanf
Hopefully this will give us enough to figure out what's going on and I can take it from there :)
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #2 from Andrew Randrianasulu randrianasulu@gmail.com --- Created attachment 65648 --> https://bugs.winehq.org/attachment.cgi?id=65648 Dependency Walker log (txt xz)
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #3 from Andrew Randrianasulu randrianasulu@gmail.com --- (In reply to Erich E. Hoover from comment #1)
Andrew,
Thanks for fast reply!
With respect to the first one, would you mind using Dependency Walker (http://www.dependencywalker.com/) to see which msvcr* library the program is using? (usually this is something like msvcr90 or msvcr100, but it can also be ucrtbase)
It seems to use MSVCR120.DLL and MSVCP120.DLL
With the second case you should be able to run the application with WINEDEBUG="+msvcrt" and look for scanf. For example: WINEDEBUG="+msvcrt" wine myprogram.exe 2>&1 | grep scanf
On broken or working case? I already applied patch revert to 4.19, and this one works ...
Hopefully this will give us enough to figure out what's going on and I can take it from there :)
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #4 from Andrew Randrianasulu randrianasulu@gmail.com --- Created attachment 65649 --> https://bugs.winehq.org/attachment.cgi?id=65649 WINEDEBUG="+msvcrt,+msvcrt120" log (xz compressed)
will uncompress into 15 Mb file This case was _working_ login with wine 4.19 + revert
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #5 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Andrew Randrianasulu from comment #3)
... On broken or working case? I already applied patch revert to 4.19, and this one works ... ...
Honestly, if you can give both that makes it easier.
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #6 from Andrew Randrianasulu randrianasulu@gmail.com --- Created attachment 65652 --> https://bugs.winehq.org/attachment.cgi?id=65652 WINEDEBUG="+msvcrt,+msvcrt120" from non-working wine git
xz compressed. Wine up to "commit 292b728908563952f56b0585d072f3d7a08e93b2"
There was wine prefix auto-update at the beginning, but main problem arises around
0046:trace:msvcrt:MSVCRT_vsscanf_l "https://login.agni.lindenlab.com/cgi-bin/login.cgi" ("%15[^\n/:]:%3[/]%[^\n/?#]%[^\n]") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 4 0046:trace:msvcrt:MSVCRT_vsscanf_l "login.agni.lindenlab.com" ("[%*45[0123456789abcdefABCDEF:.]%c") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 0
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #7 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Andrew Randrianasulu from comment #6)
... 0046:trace:msvcrt:MSVCRT_vsscanf_l "https://login.agni.lindenlab.com/cgi-bin/login.cgi" ("%15[^\n/:]:%3[/]%[^\n/?#]%[^\n]") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 4 0046:trace:msvcrt:MSVCRT_vsscanf_l "login.agni.lindenlab.com" ("[%*45[0123456789abcdefABCDEF:.]%c") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 0
Are you _sure_? The change that I made should only be capable of giving a return value of _EOF_RET (-1).
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #8 from Andrew Randrianasulu randrianasulu@gmail.com --- (In reply to Erich E. Hoover from comment #7)
(In reply to Andrew Randrianasulu from comment #6)
... 0046:trace:msvcrt:MSVCRT_vsscanf_l "https://login.agni.lindenlab.com/cgi-bin/login.cgi" ("%15[^\n/:]:%3[/]%[^\n/?#]%[^\n]") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 4 0046:trace:msvcrt:MSVCRT_vsscanf_l "login.agni.lindenlab.com" ("[%*45[0123456789abcdefABCDEF:.]%c") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 0
Are you _sure_? The change that I made should only be capable of giving a return value of _EOF_RET (-1).
Hm, trace ends here, no? I think ntdll called into mscrt120 and timed out on this ... I tried to wait for 60 seconds - but nothing happened.
Note, this is 32-bit program and 32-bit wine build on x86_64 kernel (shouldn't matter much, because it was working before)
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #9 from Andrew Randrianasulu randrianasulu@gmail.com --- (In reply to Erich E. Hoover from comment #7)
(In reply to Andrew Randrianasulu from comment #6)
... 0046:trace:msvcrt:MSVCRT_vsscanf_l "https://login.agni.lindenlab.com/cgi-bin/login.cgi" ("%15[^\n/:]:%3[/]%[^\n/?#]%[^\n]") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 4 0046:trace:msvcrt:MSVCRT_vsscanf_l "login.agni.lindenlab.com" ("[%*45[0123456789abcdefABCDEF:.]%c") 0046:trace:msvcrt:MSVCRT_vsscanf_l returning 0
Are you _sure_? The change that I made should only be capable of giving a return value of _EOF_RET (-1).
Line from usual application log:
003a:err:ntdll:RtlpWaitForCriticalSection section 0x7d344954 "../msvcrt/lock.c: LOCKTABLEENTRY.crit" wait timed out in thread 003a, blocked by 0009, retrying (60 sec)
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #10 from Erich E. Hoover erich.e.hoover@gmail.com --- Created attachment 65653 --> https://bugs.winehq.org/attachment.cgi?id=65653 Hopefully fix locking
(In reply to Andrew Randrianasulu from comment #9)
... Line from usual application log:
003a:err:ntdll:RtlpWaitForCriticalSection section 0x7d344954 "../msvcrt/lock.c: LOCKTABLEENTRY.crit" wait timed out in thread 003a, blocked by 0009, retrying (60 sec)
Try the attached patch.
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #11 from Andrew Randrianasulu randrianasulu@gmail.com --- (In reply to Erich E. Hoover from comment #10)
Created attachment 65653 [details] Hopefully fix locking
(In reply to Andrew Randrianasulu from comment #9)
Try the attached patch.
It worked, I can log in!
https://bugs.winehq.org/show_bug.cgi?id=48087
--- Comment #12 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Andrew Randrianasulu from comment #11)
... It worked, I can log in!
Awesome, then this should be fixed by commit 925a88d1f701da76974eb967fd799152b25d6613.
https://bugs.winehq.org/show_bug.cgi?id=48087
Andrew Randrianasulu randrianasulu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #13 from Andrew Randrianasulu randrianasulu@gmail.com --- (In reply to Erich E. Hoover from comment #12)
(In reply to Andrew Randrianasulu from comment #11)
... It worked, I can log in!
Awesome, then this should be fixed by commit 925a88d1f701da76974eb967fd799152b25d6613.
and sure it fixed! (tested with wine version wine-4.19-334-ga63a98c388)
https://bugs.winehq.org/show_bug.cgi?id=48087
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |925a88d1f701da76974eb967fd7 | |99152b25d6613
https://bugs.winehq.org/show_bug.cgi?id=48087
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.21.
-
WineHQ Bugzilla