[Bug 54441] New: windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

Bug ID: 54441
           Summary: windows.media.speech:speech - test_Recognition()
                    sometimes gets unexpected recognizer state on Windows
                    10
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

windows.media.speech:speech - test_Recognition() sometimes gets unexpected
recognizer state on Windows 10:

speech.c:1775: Test failed: recog_state was 0.

See https://test.winehq.org/data/patterns.html#windows.media.speech:speech

This failure started on 2023-01-25.

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
    Regression SHA1|                            |b36871b85a40c0da6c56f8d9f06
                   |                            |303d42ce75095

--- Comment #1 from François Gouget  ---
This failure started on Windows the day after the test was added in the commit
below:

commit b36871b85a40c0da6c56f8d9f06303d42ce75095
Author:     Bernhard Kölbl 
AuthorDate: Mon May 16 18:40:22 2022 +0200

windows.media.speech/tests: Test the recognizer state.

Signed-off-by: Bernhard Kölbl

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

--- Comment #2 from Bernhard Kölbl  ---
Yeah, this test is pretty flakey. Probably needs to be relaxed a little.

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

--- Comment #3 from François Gouget  ---
I don't know anything about that dll so I'm counting on you :-)

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

--- Comment #4 from Bernhard Kölbl  ---
So there would be two solutions:

1. Just allow the state to be SpeechRecognizerState_Idle (0) for that test,
which sort of contradicts the docs (?), because according to them, this state
seemingly means the recognizer is not doing anything even though we started it
(ISpeechContinuousRecognitionSession_StartAsync) and waited for it to finish
starting. (?)

https://learn.microsoft.com/en-us/uwp/api/windows.media.speechrecognition.sp...

2. Mark the test as flaky.

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

--- Comment #5 from François Gouget  ---
Flaky would mean it's an unavoidable behavior caused by external factors which,
if I understand correctly, does not seem to be the case here.

This sounds like more of a Windows bug (particularly since it seems only
specific Windows versions exhibit it) or at least an undesirable behavior, so 
broken() may be more appropriate.

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

--- Comment #6 from Bernhard Kölbl  ---
This has been fixed for a while now.

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4f824a507afecc43c2543c0c544
                   |                            |48a523142d0b6
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from François Gouget  ---
Right. This last happened on 2023-03-24 and was fixed by:

commit 4f824a507afecc43c2543c0c54448a523142d0b6
Author:     Bernhard Kölbl 
AuthorDate: Sat Mar 25 22:02:59 2023 +0100

windows.media.speech/tests: Allow recognizer state to be idle during active
recognition session.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54441
    Signed-off-by: Bernhard Kölbl

Thanks for the fix!

[Bug 54441] windows.media.speech:speech - test_Recognition() sometimes gets unexpected recognizer state on Windows 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54441

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 8.18.