[Bug 40473] New: wine stops to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Bug ID: 40473
           Summary: wine stops to compile with >=glibc-2.23
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I'm using gentoo distribution and with unstable amd64 arch tree branch,
so I'm glad to test early version of wine. ;)
some of user reported build issue, and i made patch to this below link

https://bugs.gentoo.org/show_bug.cgi?id=580046

and we should test which is working well or not.

so please help me to test my patch to eliminate compile stopping issue with
=glibc-2.23

Thank you for advance.

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

--- Comment #2 from Seong-ho Cho  ---
Created attachment 54230
  --> https://bugs.winehq.org/attachment.cgi?id=54230
This patch is following autoconf manual given by Mike Frysinger, Thanks.

I modified a patch from initially submitted one to the gentoo bugzilla.

[Bug 40473] wine stops to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Mike Frysinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Mike Frysinger  ---
the build failure is semi-specific to Gentoo at this time.  the plan is to
deprecate these things in mainline glibc.  other C libraries have dropped it
(or never had it in the first place), although i'm guessing wine doesn't cover
glibc too much atm.

the AC_HEADER_MAJOR autoconf macro is designed to support this.

https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Particu...

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|wine stops to compile with  |wine fails to compile with
                   |>=glibc-2.23                |>=glibc-2.23

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

--- Comment #3 from Mike Frysinger  ---
not sure if there's a more central location to put these (not terribly familiar
w/wine codebase), but if there isn't, that patch looks good.  thanks!

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Sebastian Lackner  ---
Patches have to be submitted to the wine-patches mailing list for inclusion,
see https://wiki.winehq.org/Submitting_Patches.

The proposed solution also looks good to me, but it doesn't apply cleanly on
current Wine git. Make sure that the patch applies without --fuzz before
sending it. Also, you might want to add a space inbetween of "#" and "include",
like in the other lines above and below, but thats a minor issue. ;)

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

--- Comment #5 from Seong-ho Cho  ---
(In reply to Sebastian Lackner from comment #4)
> Patches have to be submitted to the wine-patches mailing list for inclusion,
> see https://wiki.winehq.org/Submitting_Patches.
>
> The proposed solution also looks good to me, but it doesn't apply cleanly on
> current Wine git. Make sure that the patch applies without --fuzz before
> sending it. Also, you might want to add a space inbetween of "#" and
> "include", like in the other lines above and below, but thats a minor issue.
> ;)

Thank you for telling about how to submit patch.

I sent my patch to [e-mail] via 'git send-email' 
I don't know that my patch is really good, and it goes well into the mail
server.
because, it's just my first patch submission *(-_-)*

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
           Keywords|                            |download, source

--- Comment #6 from Austin English  ---
(In reply to Seong-ho Cho from comment #5)
> (In reply to Sebastian Lackner from comment #4)
> > Patches have to be submitted to the wine-patches mailing list for inclusion,
> > see https://wiki.winehq.org/Submitting_Patches.
> >
> > The proposed solution also looks good to me, but it doesn't apply cleanly on
> > current Wine git. Make sure that the patch applies without --fuzz before
> > sending it. Also, you might want to add a space inbetween of "#" and
> > "include", like in the other lines above and below, but thats a minor issue.
> > ;)
>
> Thank you for telling about how to submit patch.
>
> I sent my patch to [e-mail] via 'git send-email' 
> I don't know that my patch is really good, and it goes well into the mail
> server.
> because, it's just my first patch submission *(-_-)*

It will show here:
https://source.winehq.org/patches/

once it's gone through moderation (assuming you haven't subscribed to
wine-patches@).

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
This should be fixed now? All the 3 patches were committed.

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |ca8a08606d3f0900b3f4aa8f2e6
                   |                            |547882a22dba8
         Resolution|---                         |FIXED

--- Comment #8 from Austin English  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/ca8a08606d3f0900b3f4aa8f2e...

Thanks Seong-ho!

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

--- Comment #9 from Seong-ho Cho  ---
Thank you for helping me everyone :D !!

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.9.

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.x
                 CC|                            |[e-mail]

[Bug 40473] wine fails to compile with >=glibc-2.23

https://bugs.winehq.org/show_bug.cgi?id=40473

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #11 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.3.