https://bugs.winehq.org/show_bug.cgi?id=46658
Bug ID: 46658 Summary: Far Cry configurator: reduced height of comboboxes Product: Wine Version: 3.15 Hardware: x86 OS: Linux Status: NEW Keywords: regression Severity: minor Priority: P2 Component: user32 Assignee: wine-bugs@winehq.org Reporter: gyebro69@gmail.com CC: dark.shadow4@web.de Regression SHA1: 3d0be0bad8eca72e67199ebfb451150d58494ba3 Distribution: ---
Created attachment 63591 --> https://bugs.winehq.org/attachment.cgi?id=63591 screenshot showing the difference
Far Cry configuration tool allows to tweak certain game settings. When I open any of the comboboxes, the drop-down list shows only 2 items. It should display more items as it is the case after reverting commit 3d0be0bad8eca72e67199ebfb451150d58494ba3. See attached screenshot for comparison.
Plain terminal output yields nothing and the free demo doesn't include the configurator tool. Please let me know if you need debug logs.
Tested in Wine 4.2 with the GOG.com version of the game.
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- First, can you check if the program uses the comctl32 version or user32 version of the combobox? You can tell my looking at the manifest that's embedded as resource into the exe file.
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #2 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Fabian Maurer from comment #1)
First, can you check if the program uses the comctl32 version or user32 version of the combobox? You can tell my looking at the manifest that's embedded as resource into the exe file.
How can I achieve that manifest thing? At least native comctl32.dll doesn't fix the problem.
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #3 from Fabian Maurer dark.shadow4@web.de --- You can use a program like "Resource Hacker" to look at the resources of an exe, the manifest is one of them. Also, can you provide a screenshot how it looks on windows?
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #4 from Béla Gyebrószki gyebro69@gmail.com --- Created attachment 63593 --> https://bugs.winehq.org/attachment.cgi?id=63593 what I found with Resource Hacker
I have never used ResHack so pardon me if that's not what you were asking for.
On Windows 7 the expanded comboboxes show exactly 3 items.
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #5 from Fabian Maurer dark.shadow4@web.de --- Created attachment 63597 --> https://bugs.winehq.org/attachment.cgi?id=63597 Test program
First, thanks for providing the needed information.
There is a problem with CBS_OWNERDRAWFIXED, where comboboxes are rendered too small. I attached a sample program.
There is no regression though, this seems to never have properly worked.
If I find time I'll look into it.
Sidenote: There seem to be minor issues with CBS_OWNERDRAWVARIABLE too.
https://bugs.winehq.org/show_bug.cgi?id=46658
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|3d0be0bad8eca72e67199ebfb45 | |1150d58494ba3 | Keywords|regression |source
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #6 from Fabian Maurer dark.shadow4@web.de --- Created attachment 63659 --> https://bugs.winehq.org/attachment.cgi?id=63659 Patch to fix the issue
Does the attached patch fix the issue?
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #7 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Fabian Maurer from comment #6)
Created attachment 63659 [details] Patch to fix the issue
Does the attached patch fix the issue?
It resembles more to the Windows 7 look than before, so yes it does.
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #8 from Fabian Maurer dark.shadow4@web.de --- Great, thank you. I've just sent in a related fix, after that I'll send in a slightly modified fix for this bug.
https://bugs.winehq.org/show_bug.cgi?id=46658
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #9 from joaopa jeremielapuree@yahoo.fr --- Does the bug still occur with wine-5.14?
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #10 from Fabian Maurer dark.shadow4@web.de --- I didn't figure out how to fix it, and then left it be. I had the configuration tool once, but I don't have it anymore. Can I get that anywhere without owning the game?
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #11 from Fabian Maurer dark.shadow4@web.de --- Anyone still got a download for that tool?
https://bugs.winehq.org/show_bug.cgi?id=46658
--- Comment #12 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Fabian Maurer from comment #11)
Anyone still got a download for that tool?
Still present in wine-9.0-rc4-14-g4054795ff19.
The demo version doesn't contain the configurator.
I have a legit copy of the game on GOG.com and uploaded FarCryConfigurator.exe and FarCryConfigEng.dll here: https://drive.google.com/file/d/1G6WIlY8ItmoqC69bsutvtVnKuyTQu9jy/view?usp=d...
That's all you need, can be used even when FC1 is not installed.
FarCryConfigurator.exe md5: 60a66a7a131526b9790d6a7aeef9c16d
FarCryConfigEng.dll md5: cc26a4f49b4cea0d7f4fce9816fb232f
https://bugs.winehq.org/show_bug.cgi?id=46658
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |https://web.archive.org/web | |/20240111064959/https://dri | |ve.usercontent.google.com/d | |ownload?id=1G6WIlY8ItmoqC69 | |bsutvtVnKuyTQu9jy&export=do | |wnload&authuser=0
--- Comment #13 from Fabian Maurer dark.shadow4@web.de --- Thanks, added a permanent download link. On Windows there's 3 items visible, on Wine just 2. The problem is that that Wine calculates the size a few pixels off, but this is hard to fix since it's dependent on the font size as well. I hope I can look into it soon.