[Bug 34681] New: Prime World launcher usually stops downloading (Update failed)

Bug #: 34681 Summary: Prime World launcher usually stops downloading (Update failed) Product: Wine Version: 1.7.3 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: sikon@ubuntu.com Classification: Unclassified

Created attachment 46229 --> http://bugs.winehq.org/attachment.cgi?id=46229 Console output (stderr)

This error is random, but most of the time (in about 80% of all launches), the Prime World launcher will refuse to update the game, or interrupt a pending update. The launcher window simply says "Update failed".

Meanwhile, stderr reports a C++ exception caused, apparently, by the application failing to download a file by HTTP from playpw.com. (Search for "exception" in the attached log.)

This problem does not occur under Windows.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

8 Oct 8 Oct

3:11 p.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

Maia Kozheva sikon@ubuntu.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |sikon@ubuntu.com

wine-bugs＠winehq.org

3:11 p.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #1 from Maia Kozheva sikon@ubuntu.com 2013-10-08 10:11:58 CDT --- Created attachment 46230 --> http://bugs.winehq.org/attachment.cgi?id=46230 Screenshot (Update failed)

wine-bugs＠winehq.org

9:50 p.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #2 from Austin English austinenglish@gmail.com 2013-10-08 16:50:50 CDT --- Does 'winetricks vcrun2008' help? It may need a different version, not sure what version of the visual C runtimes it's using.

wine-bugs＠winehq.org

9 Oct 9 Oct

2:51 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #3 from Maia Everett maia@lucidfox.org 2013-10-08 21:51:40 CDT --- It doesn't. It does indeed use the 2008 MSVC runtime (msvcp90), but the problem isn't missing functions. Running the launcher in a clean wineprefix with winetricks vcrun2008 displays the same result.

wine-bugs＠winehq.org

10 Nov 10 Nov

7 p.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

Anastasius Focht focht@gmx.net changed:

--- Comment #4 from Anastasius Focht focht@gmx.net 2013-11-10 13:00:56 CST --- Hello folks,

confirming.

The game launcher makes heavy use of QT 4.8.x Network library and Boost C++ library (threading, signals, ...).

Fortunately the game is very verbose in what it does, write log files and uses OutputDebugString().

Launcher output when the problem occurs:

--- snip --- .\Net\Detail\HttpImpl.cpp(274): Throw in function void __thiscall Net::Detail::HttpImpl::OnFinished(class QNetworkReply *) Dynamic exception type: class boost::exception_detail::clone_impl<class Net::HttpError> std::exception::what: HTTP Error: #2, Connection closed (200), url: http://cdn.en.playpw.com/updates/PC/en-US/Client/Client/patches/00000_00010/... --- snip ---

Relevant part of trace log with +winsock:

--- snip --- ... 003a:trace:winsock:WS2_recv_base socket 06a8, wsabuf 0xa56c4fc, nbufs 1, flags 0, from (nil), fromlen -1, ovl (nil), func (nil) 003a:trace:winsock:WS2_recv_base fd=54, options=0 003a:trace:winsock:WS2_recv_base -> 1001 bytes 003a:trace:winsock:WSAAsyncSelect 6a8, hWnd 0x30086, uMsg 00000400, event 00000029 003a:trace:winsock:WSAIoctl 1704, 0x4004667f, 0xa56c59c, 4, 0xa56c594, 4, 0xa56c598, (nil), (nil) 003a:trace:winsock:WSAAsyncSelect 6a8, hWnd 0x30086, uMsg 00000000, event 00000000 003a:trace:winsock:WSAIoctl 1704, 0x4004667f, 0xa56c620, 4, 0xa56c618, 4, 0xa56c61c, (nil), (nil) 003a:trace:winsock:WSAIoctl 1704, 0x4004667f, 0xa56c580, 4, 0xa56c578, 4, 0xa56c57c, (nil), (nil) 003a:trace:winsock:WSAAsyncSelect 6a8, hWnd 0x30086, uMsg 00000400, event 00000029

003a:trace:winsock:WS2_recv_base socket 06a8, wsabuf 0xa56c554, nbufs 1, flags 0, from (nil), fromlen -1, ovl (nil), func (nil) 003a:trace:winsock:WS2_recv_base fd=54, options=0 003a:trace:winsock:WS2_recv_base -> 0 bytes

003a:trace:winsock:WSAAsyncSelect 6a8, hWnd 0x30086, uMsg 00000000, event 00000000

003a:trace:winsock:WS_closesocket socket 06a8 (http_impl) 13:18:14.687 W: HTTP error: #2: Connection closed, url: http://cdn.en.playpw.com/updates/PC/en-US/Client/Client/patches/00000_00010/...

0035:warn:debugstr:OutputDebugStringA "(http_impl) 13:18:14.687 W: HTTP error: #2: Connection closed, url: http://cdn.en.playpw.com/updates/PC/en-US/Client/Client/patches/00000_00010/..." (http_impl) 13:18:14.687 d: HttpImpl Finished. err: #2, code: 200, url: http://cdn.en.playpw.com/updates/PC/en-US/Client/Client/patches/00000_00010/...

0035:warn:debugstr:OutputDebugStringA "(http_impl) 13:18:14.687 d: HttpImpl Finished. err: #2, code: 200, url: http://cdn.en.playpw.com/updates/PC/en-US/Client/Client/patches/00000_00010/..." --- snip ---

The problem occurs when the connection was closed by server -> bytes read = 0 (not a socket error).

There is a bug entry on QT bugtracker which explains a similar problem for QT's own QHttpSocketEngine in detail: https://bugreports.qt-project.org/browse/qtbug-21351

The game implements HTTP protocol handling on its own, on top of Boost C++ classes. QT C++ network classes are used for low level socket handling.

"HTTP error: #2" is "RemoteHostClosedError":

--- snip --- class QNetworkReplyPrivate; class Q_NETWORK_EXPORT QNetworkReply: public QIODevice { Q_OBJECT Q_ENUMS(NetworkError) public: enum NetworkError { NoError = 0,

// network layer errors [relating to the destination server] (1-99): ConnectionRefusedError = 1, RemoteHostClosedError, HostNotFoundError, TimeoutError, OperationCanceledError, SslHandshakeFailedError, TemporaryNetworkFailureError, UnknownNetworkError = 99, --- snip ---

Small launcher code snippet that seems to be responsible for error handling (annotated):

--- snip --- ... 004ADE68 mov ecx, edi 004ADE6A call ebp ; QNetworkReply::error(void) 004ADE6C test eax, eax 004ADE6E jz loc_4AE00C 004ADE74 mov ecx, edi 004ADE76 call ebp ; QNetworkReply::error(void) 004ADE78 cmp eax, 5 ; OperationCanceledError 004ADE7B jnz 004ADF01 004ADE81 push ... ; "User has aborted the request" ... 004ADFD7 mov ... ; "void __thiscall Net::Detail::HttpImpl::" 004ADFE2 mov ... ; ".\Net\Detail\HttpImpl.cpp" 004ADFED mov ..., 112h ; line number 274 004ADFF8 call throw_cpp_exc ; .\Net\Detail\HttpImpl.cpp(274): Throw in function void __thiscall Net::Detail::HttpImpl::OnFinished(class QNetworkReply *) --- snip ---

Lower layer error codes 0 and 5 are explicitly handled while all others are generically handled as error (C++ exception thrown).

Anyway, "remote closed" might be a legitimate case and could be handled as such. I patched the executable to handle RemoteHostClosedError (#2) more gracefully. It reduced the error frequency but still encountered situations where some data/files were too short/corrupted.

Reducing the concurrency by modifying "app.config.xml" in "app" directory didn't really help, there were still failures.

"Proceed download queue: 0 [max=1]"

--- snip --- <MaxNumOfSimultaneousDownloads>1</MaxNumOfSimultaneousDownloads> --- snip ---

One thing to investigate is why "remote closed connection" (bytes read = 0) doesn't happen with the launcher on Windows (otherwise people would see similar failure/error propagation). If this situation could be prevented the launcher might actually succeed at all downloads.

QT Network code for reference (just to see lower layer socket API usage):

--- snip --- $ git clone git://gitorious.org/qt/qt.git -b v4.8.3 --- snip ---

$ sha1sum PWSetup.exe 4678e218e4c3d095c9f8075303f6c507e5fd59fd PWSetup.exe

$ du -sh PWSetup.exe 12M PWSetup.exe

$ wine --version wine-1.7.6-109-g917d303

Regards

wine-bugs＠winehq.org

4 Jan 4 Jan

11:58 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #5 from Anastasius Focht focht@gmx.net --- *** Bug 34682 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5 Jan 5 Jan

3 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #6 from Bruno Jesus 00cpxxx@gmail.com --- By using wireshark it's possible to see wine receives matches all packets sent by the server. After the last packet the server sends the FIN packet (as expected from http protocol).

I can confirm it works in Windows XP, wireshark shows a very similiar output.

The problem here is the same from bug 31438, patch https://bugs.winehq.org/attachment.cgi?id=50384&action=diff fixes the issue for me. Probably duplicate.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

8:31 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

Anastasius Focht focht@gmx.net changed:

--- Comment #7 from Anastasius Focht focht@gmx.net --- Hello folks,

resolving as per Bruno's comment #6 Thanks for testing.

Regards

*** This bug has been marked as a duplicate of bug 31438 ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:04 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

Javi wyre12@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |wyre12@gmail.com

--- Comment #8 from Javi wyre12@gmail.com --- I can't find 'socket.c' to edit it :(

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:09 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #9 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to Javi from comment #8)

I can't find 'socket.c' to edit it :(

After downloading the wine source you can find this file at: dlls/ws2_32/socket.c

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:12 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #10 from Javi wyre12@gmail.com --- (In reply to Bruno Jesus from comment #9)

(In reply to Javi from comment #8)

...
I can't find 'socket.c' to edit it :(

After downloading the wine source you can find this file at: dlls/ws2_32/socket.c

But... should i recompile Wine? ... i prefer to wait for an update from Debian, repos, ain't it more correct?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

11:19 a.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #11 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to Javi from comment #10)

But... should i recompile Wine? ... i prefer to wait for an update from Debian, repos, ain't it more correct?

To be able to play right now you have to compile wine manually. The easiest way is to wait for wine to get fixed and a new release made. CC yourself to bug 31438 and you will be notified when the bug is closed and what wine version fixed it.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1:09 p.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)

--- Comment #12 from Javi wyre12@gmail.com --- (In reply to Bruno Jesus from comment #11)

(In reply to Javi from comment #10)

...
But... should i recompile Wine? ... i prefer to wait for an update from Debian, repos, ain't it more correct?

To be able to play right now you have to compile wine manually. The easiest way is to wait for wine to get fixed and a new release made. CC yourself to bug 31438 and you will be notified when the bug is closed and what wine version fixed it.

Anyway ... we are using diferent Wine's version, ... in https://bugs.winehq.org/show_bug.cgi?id=31438 they are using 1.5.10, here you are using 1.7.3 and i'm using 1.7.29 ... Which Wine version will be patched? xD

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

12 Jan 12 Jan

12:05 p.m.

New subject: [Bug 34681] Prime World launcher usually stops downloading (Update failed)