[Bug 47395] New: bug 44255 revisited: app fall into critical section lock upon quiting

https://bugs.winehq.org/show_bug.cgi?id=47395

Bug ID: 47395
           Summary: bug 44255 revisited: app fall into critical section
                    lock upon quiting
           Product: Wine
           Version: 4.10
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I'm not quite sure when it happened, but I think it was between 4.8 and 4.10.

The symptoms are pretty much the same as in bug 44255: start the app, try to
quit the app, get a perma-lock.

Yet, this time it doesn't seem to be quartz, as native override doesn't help.
Also, while I've tried to follow Focht's procedure from the former bug, I
couldn't get a thread calling to RtlpWaitForCriticalSection...

Though that might be just a shortcoming of winedbg - not supporting separate
compressed debug sections.

[Bug 47395] bug 44255 revisited: app fall into critical section lock upon quiting

https://bugs.winehq.org/show_bug.cgi?id=47395

--- Comment #1 from Rafał Mużyło  ---
Created attachment 64742
  --> https://bugs.winehq.org/attachment.cgi?id=64742
backtraces I did get

[Bug 47395] bug 44255 revisited: app fall into critical section lock upon quiting

https://bugs.winehq.org/show_bug.cgi?id=47395

Rafał Mużyło  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-dsound

--- Comment #2 from Rafał Mużyło  ---
So, native dsound fixes the hang, changing the component then.
More tests may follow.

[Bug 47395] Wolf RPG Editor hangs on exit

https://bugs.winehq.org/show_bug.cgi?id=47395

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|bug 44255 revisited: app    |Wolf RPG Editor hangs on
                   |fall into critical section  |exit
                   |lock upon quiting           |

[Bug 47395] Wolf RPG Editor hangs on exit

https://bugs.winehq.org/show_bug.cgi?id=47395

--- Comment #3 from Rafał Mużyło  ---
Going by eu-addr2line (as the plain one also doesn't seem to support
splitdebug):

DirectSoundCaptureCreate8+0x6d6 is directsound_destroy in
IDirectSound8Impl_Release
DirectSoundCaptureCreate8+0x405 is WaitForSingleObject(device->thread,
INFINITE); in DirectSoundDevice_Release

Now, I've got this wild idea about why device->thread is never signaled...
I'll probably share it after a few tests.

[Bug 47395] Wolf RPG Editor hangs on exit

https://bugs.winehq.org/show_bug.cgi?id=47395

--- Comment #4 from Rafał Mużyło  ---
...tentatively, fixed in 4.11, but I'll wait one more release before confirming
it definitely. Cause I can't point to a commit that would have fixed it, even
if I suspect one of those clock commits to direct music (engine loads that dll
too and given how interdependent that set is...).

Cause if it wasn't that, things get really murky.

[Bug 47395] Wolf RPG Editor hangs on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47395

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEEDINFO

--- Comment #5 from Alistair Leslie-Hughes  ---
(In reply to Rafał Mużyło from comment #4)
> ...tentatively, fixed in 4.11, but I'll wait one more release before
> confirming it definitely. Cause I can't point to a commit that would have
> fixed it, even if I suspect one of those clock commits to direct music
> (engine loads that dll too and given how interdependent that set is...).
>
> Cause if it wasn't that, things get really murky.

Can you please confirm if this has been fixed?

[Bug 47395] Wolf RPG Editor hangs on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47395

Rafał Mużyło  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Rafał Mużyło  ---
...oops...
Thanks for the reminder and sorry for the delay.

Confirmed.

[Bug 47395] Wolf RPG Editor hangs on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47395

--- Comment #7 from Rafał Mużyło  ---
On a not quite related note: it *feels* to me that recent switch of the mp3
decoder to full gstreamer has caused minor regressions wrt. looping, but
nothing I can point my finger at.

[Bug 47395] Wolf RPG Editor hangs on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47395

--- Comment #8 from Rafał Mużyło  ---
...also, pity that neither regression commit nor its fix have been identified.

[Bug 47395] Wolf RPG Editor hangs on exit

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47395

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 4.18.