https://bugs.winehq.org/show_bug.cgi?id=55177
Bug ID: 55177 Summary: Hatching not printed in Framemaker 8 Product: Wine Version: 8.8 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wineps.drv Assignee: wine-bugs@winehq.org Reporter: ulrich.gemkow@ikr.uni-stuttgart.de Distribution: ---
Hatchings are no longer printed in Framemaker 8 after commit
d98cd8d28bc40c808a4058e8af4afac75fe63390 is the first bad commit commit d98cd8d28bc40c808a4058e8af4afac75fe63390 Author: Piotr Caban piotr@codeweavers.com Date: Sat May 6 11:17:02 2023 +0200
wineps: Use printer DC in print processor.
dlls/wineps.drv/builtin.c | 43 --------------- dlls/wineps.drv/printproc.c | 131 ++------------------------------------------ dlls/wineps.drv/psdrv.h | 2 - 3 files changed, 4 insertions(+), 172 deletions(-)
To reproduce
- Install Framemaker 8 from the given URL
- Open the attached document hatching.fm
- print the document (to file or to printer)
the area with the hatching is empty.
https://bugs.winehq.org/show_bug.cgi?id=55177
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |d98cd8d28bc40c808a4058e8af4 | |afac75fe63390 CC| |piotr@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=55177
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |ftp://ftp.adobe.com/pub/ado | |be/framemaker/win/8.x/Adobe | |FrameMaker80_extract.exe Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=55177
--- Comment #1 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Created attachment 74766 --> https://bugs.winehq.org/attachment.cgi?id=74766 Example file with hatching
https://bugs.winehq.org/show_bug.cgi?id=55177
--- Comment #2 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Created attachment 74767 --> https://bugs.winehq.org/attachment.cgi?id=74767 Log file for succesful printing the hatching in wine 8.7
https://bugs.winehq.org/show_bug.cgi?id=55177
--- Comment #3 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Created attachment 74768 --> https://bugs.winehq.org/attachment.cgi?id=74768 Log file for failed printing the hatching in wine 8.11
https://bugs.winehq.org/show_bug.cgi?id=55177
--- Comment #4 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Comparing the two log files shows that in the "good" case in wine 8.7 the line (near the end)
00d8:trace:psdrv:PSDRV_WriteDIBPatternDict size 8x-8x1
appears. In the "bad" case in wine 8.11 at the same region shows the line
00d8:fixme:psdrv:hmf_proc unhandled object type 0
So it seems the WriteDIB got lost in the conversion from the old to the new printing code.
General question: It seems that the transition from the "old" to the "new" printing code introduced some bugs (which is not avoidable).
Bisecting does not really help - it leads to the commits which made the "big switch" from "old" to "new".
It seems that it was not possible to really test the "new" printing code transferred from "old" to "new" because the "new" code was only active after the "big switch".
Are there ideas howto find the bugs in the "new" code? Thanks!
https://bugs.winehq.org/show_bug.cgi?id=55177
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=55177
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com
--- Comment #5 from Piotr Caban piotr.caban@gmail.com --- I've created MR that fixes printing hatching.fm file that was attached to the bug (the view in application and print result looks different - stripes direction differs). I didn't look into that since printed document matches with the old code.
Regarding the question about finding bugs in "new" code - I agree that bisecting is not really helpful. It's best to create a bug, mark it as regression if it worked in older version of wine and attach log with following debug channels: seh,gdi,enhmetafile,winspool,localspl,psdrv
It's also helpful to describe how to reproduce the bug if possible.
https://bugs.winehq.org/show_bug.cgi?id=55177
--- Comment #6 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Your patch fixes the issue. Thanks a lot!
We never noticed that the stripes direction is wrong :-) I will further investigate...
https://bugs.winehq.org/show_bug.cgi?id=55177
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |ef7b1839846d3ed3d4ebf826f92 | |d50dbf52b29df
--- Comment #7 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Fixed in wine 8.12. Thanks again!
https://bugs.winehq.org/show_bug.cgi?id=55177
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 8.13.
-
WineHQ Bugzilla