https://bugs.winehq.org/show_bug.cgi?id=36165
Bug ID: 36165 Summary: msvcrt/string tests fail under valgrind Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs@winehq.org Reporter: austinenglish@gmail.com
string.c:1570: Test failed: d = 1000000000000000482416141386308708571867933472627945326741491900144172904106310050588962644037102476595408159456210748972770600252972845262058045244417464426905986489749230528825980973749133650163621397243851020732242333839884529407361024.000000 ... string.c:2475: Test failed: d.x = 0.000000e+000, expected 0 string.c:2478: Test failed: d.x = 0.000000e+000, expected 0
wine-1.7.17-129-gb84e112 / valgrind-3.9.0
http://bugs.winehq.org/show_bug.cgi?id=36165
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com
--- Comment #1 from Piotr Caban piotr.caban@gmail.com --- This is a valgrind bug. Strtod uses long double during computations.
Valgrind has the following limitations in its implementation of x86/AMD64 floating point relative to IEEE754.
Precision: There is no support for 80 bit arithmetic. Internally, Valgrind represents all such "long double" numbers in 64 bits, and so there may be some differences in results. Whether or not this is critical remains to be seen. Note, the x86/amd64 fldt/fstpt instructions (read/write 80-bit numbers) are correctly simulated, using conversions to/from 64 bits, so that in-memory images of 80-bit numbers look correct if anyone wants to see.
https://bugs.winehq.org/show_bug.cgi?id=36165
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |UPSTREAM
--- Comment #2 from Austin English austinenglish@gmail.com --- (In reply to Piotr Caban from comment #1)
This is a valgrind bug. Strtod uses long double during computations.
From http://www.valgrind.org/docs/manual/manual-core.html:
Valgrind has the following limitations in its implementation of x86/AMD64 floating point relative to IEEE754.
Precision: There is no support for 80 bit arithmetic. Internally, Valgrind represents all such "long double" numbers in 64 bits, and so there may be some differences in results. Whether or not this is critical remains to be seen. Note, the x86/amd64 fldt/fstpt instructions (read/write 80-bit numbers) are correctly simulated, using conversions to/from 64 bits, so that in-memory images of 80-bit numbers look correct if anyone wants to see.
Okay, thanks.
https://bugs.winehq.org/show_bug.cgi?id=36165
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Austin English austinenglish@gmail.com --- Closing.
https://bugs.winehq.org/show_bug.cgi?id=36165
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED
--- Comment #4 from Austin English austinenglish@gmail.com --- This was inadvertently caught up in my unclosed bugs filter. NOTOURBUG should only be closed when fixed upstream.
Setting back to RESOLVED NOTOURBUG.
Sorry for the spam.
https://bugs.winehq.org/show_bug.cgi?id=36165
--- Comment #5 from Piotr Caban piotr.caban@gmail.com --- I've retested this bug since we no longer use long doubles. There are still test failures under valgrind. glibc pow results are affected by valgrind.
https://bugs.winehq.org/show_bug.cgi?id=36165
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ff4d7edc338b35dce3274dd6887 | |dbaf55cf86513 Resolution|NOTOURBUG |FIXED
--- Comment #6 from Piotr Caban piotr.caban@gmail.com --- It works for me now. Marking as fixed.
https://bugs.winehq.org/show_bug.cgi?id=36165
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.11.