http://bugs.winehq.org/show_bug.cgi?id=33723
Bug #: 33723 Summary: EA Origin needs job objects Product: Wine Version: 1.5.31 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll AssignedTo: wine-bugs@winehq.org ReportedBy: ariscop@gmail.com Classification: Unclassified
It uses job objects + completion ports to determine if a game is running or has exited. as it doesn't notice a game being closed, you cannot relaunch the game without restarting origin.
fixme:ntdll:NtCreateJobObject stub: 0xa32e83c 1f001f <null> fixme:ntdll:NtSetInformationJobObject stub: 0xdead 9 0xa32e890 112 trace:ntdll:NtCreateIoCompletion (0xa32e83c, 1f0003, (nil), 0) fixme:ntdll:NtSetInformationJobObject stub: 0xdead 7 0xa32e934 8 fixme:ntdll:NtAssignProcessToJobObject stub: 0xdead 0xc70
http://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #1 from Andrew Cook ariscop@gmail.com 2013-06-06 02:22:12 CDT --- https://github.com/ariscop/wine/tree/JobObject it keeps origin happy, but is a bit of a hack, only need it to test a game on origin.
http://bugs.winehq.org/show_bug.cgi?id=33723
Berillions berillions@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |berillions@gmail.com
--- Comment #2 from Berillions berillions@gmail.com 2013-06-29 09:40:12 CDT --- It's not possible to implement this hack correctly in Wine ? Quit&Re-launch Origin to play at other game is not very cool
Thanks, Max
http://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #3 from Andrew Cook ariscop@gmail.com 2013-10-17 17:24:39 CDT --- Created attachment 46340 --> http://bugs.winehq.org/attachment.cgi?id=46340 Patch implementing job objects for wine 1.7.4
Upstream does not seem interested in this patch, leaving it here for now
http://bugs.winehq.org/show_bug.cgi?id=33723
Cùran debian@carbon-project.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |debian@carbon-project.org
--- Comment #4 from Cùran debian@carbon-project.org --- (In reply to comment #3)
Upstream does not seem interested in this patch, leaving it here for now
Have you sent the patch series to wine-patches? Maybe you need to send a ping and the series has fallen through the cracks, if you sent the patch (series). Otherwise you might want to check out http://wiki.winehq.org/SubmittingPatches.
Thanks for your work.
http://bugs.winehq.org/show_bug.cgi?id=33723
Adam Bolte abolte@systemsaviour.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |abolte@systemsaviour.com
http://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #5 from Adam Bolte abolte@systemsaviour.com --- I see this bug is still marked as unconfirmed. I can confirm both the problem, and that the attached patch works as advertised (with a minor tweak since it doesn't apply cleanly to 1.7.19).
https://bugs.winehq.org/show_bug.cgi?id=33723
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #6 from Austin English austinenglish@gmail.com --- (In reply to Adam Bolte from comment #5)
I see this bug is still marked as unconfirmed. I can confirm both the problem, and that the attached patch works as advertised (with a minor tweak since it doesn't apply cleanly to 1.7.19).
Confirming.
http://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #7 from Adam Bolte abolte@systemsaviour.com --- Created attachment 48637 --> http://bugs.winehq.org/attachment.cgi?id=48637 Patch implementing job objects for wine 1.7.19
Updated Andrew's patch for 1.7.19, as the original does not apply cleanly.
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #8 from Austin English austinenglish@gmail.com --- *** Bug 29876 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=33723
Luke Bratch l_bratch@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |l_bratch@yahoo.co.uk
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #9 from Berillions berillions@gmail.com --- (In reply to Adam Bolte from comment #7)
Created attachment 48637 [details] Patch implementing job objects for wine 1.7.19
Updated Andrew's patch for 1.7.19, as the original does not apply cleanly.
The 1.7.4 patch still works on Wine if you DISABLE the tests compilation (./configure --disable-tests) during the build.
http://bugs.winehq.org/show_bug.cgi?id=33723
Terry wearenotamused@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wearenotamused@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=33723
jre.winesim@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jre.winesim@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=33723
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |harald.nigg@web.de
--- Comment #10 from Hans Leidekker hans@meelstraat.net --- *** Bug 37571 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=33723
mrdeathjr28@yahoo.es changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrdeathjr28@yahoo.es
https://bugs.winehq.org/show_bug.cgi?id=33723
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=33723
Brendan Orr brendan.a.orr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan.a.orr@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #11 from mrdeathjr28@yahoo.es --- Problem stay present on wine 1.7.35
https://bugs.winehq.org/show_bug.cgi?id=33723
Apo apoenacc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |apoenacc@gmail.com
--- Comment #12 from Apo apoenacc@gmail.com --- Hi guys. I`m a complete noob at patching wine, so I may ask a stupid question.
How to I patch the text attachments that you guys put in here?
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #13 from Adam Bolte abolte@systemsaviour.com --- (In reply to Apo from comment #12)
Hi guys. I`m a complete noob at patching wine, so I may ask a stupid question.
You may, but this isn't the place to ask support questions. Please use the forums for that in future.
How to I patch the text attachments that you guys put in here?
A quick search would indicate that this information is already on the wiki.
http://wiki.winehq.org/Patching
https://bugs.winehq.org/show_bug.cgi?id=33723
Andrew Cook ariscop@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #46340|0 |1 is obsolete| | CC| |ariscop@gmail.com
--- Comment #14 from Andrew Cook ariscop@gmail.com --- Created attachment 50895 --> https://bugs.winehq.org/attachment.cgi?id=50895 Patch implementing job objects for 1.7.37
Starting to work on this again, shouldn't behave too differently from the previous patch though some of it was rewritten.
Yet to try it with origin but it passes the tests for behaviour origin needs.
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #15 from Andrew Cook ariscop@gmail.com --- Job object support has been added to wine-staging, will try upstream it soon
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #16 from Andrew Cook ariscop@gmail.com --- Should be fixed in 1.7.40
https://bugs.winehq.org/show_bug.cgi?id=33723
Andrew Cook ariscop@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #17 from Andrew Cook ariscop@gmail.com --- Fixed in 1.7.40
https://bugs.winehq.org/show_bug.cgi?id=33723
--- Comment #18 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to Andrew Cook from comment #17)
Fixed in 1.7.40
Please select the most relevant commit and add as Fixed SHA1 field. http://source.winehq.org/git/wine.git/search?s=Andrew+Cook;st=author
https://bugs.winehq.org/show_bug.cgi?id=33723
Andrew Cook ariscop@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |47ffeaee7406e41708d9d552330 | |8e3b2f4850f9c
https://bugs.winehq.org/show_bug.cgi?id=33723
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #19 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.41.