[Bug 50987] New: dinput8:device fails on the w10pro64_fr TestBot VM

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50987

Bug ID: 50987
           Summary: dinput8:device fails on the w10pro64_fr TestBot VM
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-dinput
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The following test failure happens specifically on the w10pro64_fr TestBot VM:

device.c:110: Test failed: Retrieval of action failed uAppData=4294967295
expected=4

See: https://test.winehq.org/data/tests/dinput8:device.html

This test regression was introduced by the following commit:

commit 8d206333fd50347cb45a8db72ecb191aa787ddb9
Author: Arkadiusz Hiler 
Date:   Mon Mar 8 14:36:11 2021 +0200

dinput: Implement DIPROP_APPDATA.

This fixes not working analog inputs on game controllers in Slay the Spire.

Signed-off-by: Arkadiusz Hiler 
    Signed-off-by: Alexandre Julliard

[Bug 50987] dinput8:device fails on the w10pro64_fr TestBot VM

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50987

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |8d206333fd50347cb45a8db72ec
                   |                            |b191aa787ddb9
           Keywords|                            |download, source, testcase

[Bug 50987] dinput8:device fails on the w10pro64_fr TestBot VM

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50987

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Linux                       |Windows

[Bug 50987] dinput8:device fails on the w10pro64_fr TestBot VM

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50987

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6b777d0b20270aff3c7296f9ca1
                   |                            |6f2e0a7866fe6
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
This was fixed by the commit below:

commit 6b777d0b20270aff3c7296f9ca16f2e0a7866fe6
Author:     Arkadiusz Hiler 
AuthorDate: Wed May 26 14:10:58 2021 +0300

dinput8: Use scan codes to test uAppData.

Virtual key codes are layout dependant while direct input works with
    scan codes.

Using virtual key code for 'A' with AZERTY layout resulted in scan code
    for 'Q' being sent out, which in turn made the tests fail.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50987
    Signed-off-by: Arkadiusz Hiler 
    Signed-off-by: Alexandre Julliard

[Bug 50987] dinput8:device fails on the w10pro64_fr TestBot VM

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50987

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 6.10.