http://bugs.winehq.org/show_bug.cgi?id=29707
Bug #: 29707 Summary: Mac: Wine "trashes" files by moving them to ~/.local/share/Trash/files Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: fgouget@codeweavers.com Classification: Unclassified
Reposting one of Ken's bug descriptions verbatim here because I really don't see anything to change.
--- In certain circumstances, Wine attempts to move a file to the Recycle Bin. For example, this happens if you select a file in a file dialog and hit the Delete key.
Wine's current implementation adheres to the freedesktop.org specification regarding the Trash, and ends up moving the file to ~/.local/share/Trash/files. On the Mac, this is as bad as permanently deleting the file for most users, except that the file's space isn't even recovered. There's approximately zero chance they'd ever be able to find it again.
This needs to be reimplemented to move the files to the Mac Trash. The right function is probably FSPathMoveObjectToTrashSync().
The Finder maintains sufficient information to put the file back, but it's in the opaque .DS_Store file. So, we may want to add a "org.winehq.trashinfo" extended attribute to the file to preserve the original name and location. Ideally, adding the attribute wouldn't change the file's mtime. ---
As far as I can tell there is no alternative Mac-specific path up to Wine 1.3.37.
http://bugs.winehq.org/show_bug.cgi?id=29707
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|shell32 |-unknown Version|unspecified |1.3.37 Severity|normal |enhancement
http://bugs.winehq.org/show_bug.cgi?id=29707
--- Comment #1 from François Gouget fgouget@codeweavers.com 2012-01-26 03:31:41 CST --- I'm not sure why this was moved to 'Component: -unknown'. The bad code is in dlls/shell32/trash.c. Also I don't think this is an enhancement: on the Mac the files are neither put in the Trash nor deleted (i.e. the disk space is not freed). So I think this qualifies as a bug. Not having an implementation at all would be better on the Mac.
http://bugs.winehq.org/show_bug.cgi?id=29707
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Mac: Wine "trashes" files |Files moved to |by moving them to |~/.local/share/Trash/files |~/.local/share/Trash/files |are "trashed" OS/Version|Linux |Mac OS X Severity|enhancement |minor
--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru 2012-01-26 05:25:34 CST --- Sounds like a bug in the underlying system which doesn't follow the freedesktop.org specification.
http://bugs.winehq.org/show_bug.cgi?id=29707
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #3 from Jerome Leclanche adys.wh@gmail.com 2012-01-26 05:56:12 CST --- (In reply to comment #2) No, Apple does not follow fd.o and they never have. As nice as it would be for them to, you can't possibly be suggesting to keep the fd.o code on osx?
http://bugs.winehq.org/show_bug.cgi?id=29707
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |integration Severity|minor |normal
--- Comment #4 from Jerome Leclanche adys.wh@gmail.com 2012-01-26 05:57:18 CST --- Bumping to normal at the very least, this affects any app that has a "move to trash" function (which is effectively almost every app), and it makes the file impossible to find for users.
http://bugs.winehq.org/show_bug.cgi?id=29707
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |shell32 Target Milestone|--- |1.4.0
http://bugs.winehq.org/show_bug.cgi?id=29707
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.4.0 |---
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2012-01-26 13:52:09 CST --- Not a 1.4 bug.
http://bugs.winehq.org/show_bug.cgi?id=29707
Gaurav Jain gaurav@gauravjain.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gaurav@gauravjain.org
http://bugs.winehq.org/show_bug.cgi?id=29707
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |teloiv@gmail.com
--- Comment #6 from Jerome Leclanche adys.wh@gmail.com 2012-02-23 15:35:27 CST --- *** Bug 12606 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=29707
--- Comment #7 from Jerome Leclanche adys.wh@gmail.com 2012-03-16 16:33:48 CDT --- cd454fdc2ed6c4a8b432dd4617fb61949c786087 should help
http://bugs.winehq.org/show_bug.cgi?id=29707
--- Comment #8 from Nikolay Sivov bunglehead@gmail.com 2013-09-10 00:12:49 CDT --- Francois, Ken, is there anything left to be done? Trash s supported now for a some time, not sure fully or not though.
http://bugs.winehq.org/show_bug.cgi?id=29707
Ken Thomases ken@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ken@codeweavers.com
--- Comment #9 from Ken Thomases ken@codeweavers.com 2013-09-10 00:50:21 CDT --- The implementation is not complete. It doesn't yet support enumerating the trash items or restoring them.
On the other hand, files are no longer effectively lost, which was the primary subject of this bug.
https://bugs.winehq.org/show_bug.cgi?id=29707
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
--- Comment #10 from Austin English austinenglish@gmail.com --- Is this still an issue in current (1.7.36 or newer) wine? If so, please attach terminal output.
-
wine-bugs＠winehq.org