[Bug 28280] New: Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

Summary: Silent Hill V: Homecoming: brightness adjustment no
                    longer works
           Product: Wine
           Version: 1.3.27
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

After upgrading to 1.3.27 from 1.3.26 the brightness slide no longer works and
defaults to the middle level.

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from André H.  2011-09-05 06:12:57 CDT ---
A trace with WINEDEBUG=+xvidmode would be a good start.
See also
http://wiki.winehq.org/FAQ#head-16da35b6327024d6ea576e3678488b16862d0f5e

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #2 from amdfanboy  2011-09-05 16:09:22 CDT ---
Created an attachment (id=36245)
 --> (http://bugs.winehq.org/attachment.cgi?id=36245)
winedebug

here it is the output

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #3 from Austin English  2011-09-06 05:16:38 CDT ---
Regression test?
http://wiki.winehq.org/RegressionTesting

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #4 from André H.  2011-09-06 12:01:19 CDT ---
(In reply to comment #3)
> Regression test?
> http://wiki.winehq.org/RegressionTesting

That won't help much here. I'll have a look at the problem.

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #5 from André H.  2011-09-06 13:10:38 CDT ---
Created an attachment (id=36258)
 --> (http://bugs.winehq.org/attachment.cgi?id=36258)
tracing patch

could you please apply that patch and attach a trace with WINEDEBUG=+xvidmode
again

see also:
http://wiki.winehq.org/FAQ#head-ce0f398b298dc31add49d49671b302b020e234bb

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #6 from amdfanboy  2011-09-06 22:39:24 CDT ---
Created an attachment (id=36265)
 --> (http://bugs.winehq.org/attachment.cgi?id=36265)
make

I get an error while compiling using debian sid

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #7 from André H.  2011-09-07 09:52:43 CDT ---
you have a broken compiler, do what the message says and report that to gcc

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #8 from amdfanboy  2011-09-08 08:29:10 CDT ---
Created an attachment (id=36285)
 --> (http://bugs.winehq.org/attachment.cgi?id=36285)
new winedebug=+xvidmode

I setup a new installation just for this, here it is the new output with the
patch, the other bug apparently was already reported on gcc.

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

--- Comment #9 from Kol  2011-09-17 01:14:24 CDT ---
Created an attachment (id=36423)
 --> (http://bugs.winehq.org/attachment.cgi?id=36423)
Revert some changes in xvidmode.c in Wine 1.3.27

I observed this regression with any application which try to set gamma.
Comparing the code of dlls/winex11.drv/xvidmode.c in 1.3.26 and 1.3.27,
I saw that the logical structure of X11DRV_XF86VM_SetGammaRamp was changed.
So I wrote a patch partly reverted changes in this function. With this
patch applied to Wine 1.3.27 I can again adjust brightness in all games.

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

Kol  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from André H.  2011-09-19 14:48:40 CDT ---
should be fixed by
http://source.winehq.org/git/wine.git/commitdiff/321224d2f680f2b78bf2f3e53d9...

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  2011-09-23 12:59:48 CDT ---
Closing bugs fixed in 1.3.29.

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |321224d2f680f2b78bf2f3e53d9
                   |                            |77a51d82d136a

[Bug 28280] Silent Hill V: Homecoming: brightness adjustment no longer works

http://bugs.winehq.org/show_bug.cgi?id=28280

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |winex11.drv