[Bug 52075] New: dinput8:device, dinput8:dinput and dinput8:hid cannot run on Windows 7 anymore
https://bugs.winehq.org/show_bug.cgi?id=52075
Bug ID: 52075 Summary: dinput8:device, dinput8:dinput and dinput8:hid cannot run on Windows 7 anymore Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: directx-dinput Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
dinput8:device, dinput8:dinput and dinput8:hid cannot run on Windows 7 anymore because they now need GetOverlappedResultEx() which is not available.
https://test.winehq.org/data/patterns.html#dinput8:device https://test.winehq.org/data/patterns.html#dinput8:dinput https://test.winehq.org/data/patterns.html#dinput8:hid
Before that the tests could run on Windows 7 and even succeeded. The call to GetOverlappedResultEx() was introduced in the commit below:
commit 3f110402f6a503d7c312694092e25fc48737c980 Author: Rémi Bernon rbernon@codeweavers.com Date: Wed Nov 17 11:51:48 2021 +0100
dinput8/tests: Add some HID device gain report tests.
Signed-off-by: Rémi Bernon rbernon@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=52075
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source, | |testcase Regression SHA1| |3f110402f6a503d7c312694092e | |25fc48737c980
https://bugs.winehq.org/show_bug.cgi?id=52075
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon@codeweavers.com
--- Comment #1 from Rémi Bernon rbernon@codeweavers.com --- Ah, sorry about that. I guess it could be loaded dynamically.
Then the patch missed the failure when submitted because win7 isn't tested anymore. Do we then care about the compatibility? Shouldn't we test win7 during patch submission if it's the case?
https://bugs.winehq.org/show_bug.cgi?id=52075
--- Comment #2 from François Gouget fgouget@codeweavers.com --- Windows 7 is part of the platforms that patches are tested against.
However a missing API is not strictly a failure: there are cases where nothing can be tested if the API is missing and so it's fine to not load it dynamically.
The TestBot cannot know whether it makes sense to load an API dynamically so at least some tests can be run and thus does not report missing APIs as a test failure.
These issues get caught when I notice a new set of 'eee' entries in the failure patterns. Also note that once a line is full of 'e's, it stops being included in the failure pattern: in effect it's only the transitions _to_ 'e' results that are considered (potential) failures on that page.
https://bugs.winehq.org/show_bug.cgi?id=52075
--- Comment #3 from Rémi Bernon rbernon@codeweavers.com --- I think it'd be better to have a failure when submitting a patch that uses an API that is missing on a Windows version we support. And if the tests don't make sense without the API, they should explicitly skip them.
Otherwise we could very well add tests to a file that isn't actually tested on Win7, thinking that it is and assuming the tests are passing as the testbot doesn't report any error. Or like here, start using an API that makes the whole tests to be silently skipped, possibly ending up in a situation where if the tests were run they would fail in a way it's hard to later fix on Win7.
https://bugs.winehq.org/show_bug.cgi?id=52075
--- Comment #4 from François Gouget fgouget@codeweavers.com --- I agree but I believe the Wine community made the opposite decision at some point. Or maybe I'm confusing it with the case of missing dlls where the situation is clearer. Maybe this should be brought up on wine-devel.
https://bugs.winehq.org/show_bug.cgi?id=52075
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |1560f6df5f10c67bffef519cfbd | |9e7392baaec01 Status|NEW |RESOLVED
--- Comment #5 from Rémi Bernon rbernon@codeweavers.com --- Marking as fixed.
https://bugs.winehq.org/show_bug.cgi?id=52075
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.23.
-
WineHQ Bugzilla