[Bug 57067] New: build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

Bug ID: 57067
           Summary: build broken in dlls/mshtml: undefined reference to
                    `IWineJSDispatchHost_GetJSDispatch'
           Product: Wine
           Version: 9.15
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: download, regression, source
          Severity: critical
          Priority: P2
         Component: mshtml
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

Created attachment 76934
  --> https://bugs.winehq.org/attachment.cgi?id=76934
build log

/usr/bin/x86_64-w64-mingw32-ld: dlls/mshtml/x86_64-windows/htmlwindow.o: in
function `WindowDispEx_GetJSDispatch':
/home/austin/wine-git/wine64/../dlls/mshtml/htmlwindow.c:3425:(.text+0xf39):
undefined reference to `IWineJSDispatchHost_GetJSDispatch'

Regression introduced by:
commit ac889d36a65eb0161b6158941b3cea7e64cac7dd
Author: Jacek Caban 
Date:   Mon Jul 8 14:22:14 2024 +0200

mshtml: Implement jscript IWineJSDispatchHost.

Based on patch by Gabriel Ivăncescu.

dlls/mshtml/dispex.c                 | 102 ++++++++++++++++++++++++++++++++++-
 dlls/mshtml/htmlwindow.c             |  55 +++++++++++++++++++
 dlls/mshtml/mshtml_private.h         |   1 +
 dlls/mshtml/mshtml_private_iface.idl |  10 ----
 4 files changed, 156 insertions(+), 12 deletions(-)

$ x86_64-w64-mingw32-gcc -v
Using built-in specs.
COLLECT_GCC=x86_64-w64-mingw32-gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-w64-mingw32/13-win32/lto-wrapper
Target: x86_64-w64-mingw32
Configured with: ../../src/configure --build=x86_64-linux-gnu --prefix=/usr
--includedir='/usr/include' --mandir='/usr/share/man'
--infodir='/usr/share/info' --sysconfdir=/etc --localstatedir=/var
--disable-option-checking --disable-silent-rules
--libdir='/usr/lib/x86_64-linux-gnu' --libexecdir='/usr/lib/x86_64-linux-gnu'
--disable-maintainer-mode --disable-dependency-tracking --prefix=/usr
--enable-shared --enable-static --disable-multilib --with-system-zlib
--libexecdir=/usr/lib --without-included-gettext --libdir=/usr/lib
--enable-libstdcxx-time=yes --with-tune=generic --with-headers
--enable-version-specific-runtime-libs --enable-fully-dynamic-string
--enable-libgomp --enable-languages=c,c++,fortran,objc,obj-c++,ada --enable-lto
--enable-threads=win32 --program-suffix=-win32
--program-prefix=x86_64-w64-mingw32- --target=x86_64-w64-mingw32
--with-as=/usr/bin/x86_64-w64-mingw32-as
--with-ld=/usr/bin/x86_64-w64-mingw32-ld --enable-libatomic
--enable-libstdcxx-filesystem-ts=yes --enable-dependency-tracking SED=/bin/sed
Thread model: win32
Supported LTO compression algorithms: zlib zstd
gcc version 13-win32 (GCC)

[Bug 57067] build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57067] build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |ac889d36a65eb0161b6158941b3
                   |                            |cea7e64cac7dd

[Bug 57067] build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

--- Comment #1 from Jacek Caban  ---
It looks like jsdisp.h is somehow outdated. It's supposed to be generated from
jsdisp.idl. Does it help if you explicitly run 'make depend'? Do you perhaps
have dlls/jscript/jsdisp.h in your source directory (as opposed to your build
directory)?

[Bug 57067] build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Austin English  ---
(In reply to Jacek Caban from comment #1)
> It looks like jsdisp.h is somehow outdated. It's supposed to be generated
> from jsdisp.idl. Does it help if you explicitly run 'make depend'? Do you
> perhaps have dlls/jscript/jsdisp.h in your source directory (as opposed to
> your build directory)?

Yes, that was the problem, thanks (I thought my build script did a clean first,
but apparently it wasn't :().

Sorry for the noise.

[Bug 57067] build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

--- Comment #3 from Austin English  ---
Closing.

[Bug 57067] build broken in dlls/mshtml: undefined reference to `IWineJSDispatchHost_GetJSDispatch'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57067

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Austin English  ---
Actually closing.