[Bug 45428] New: Crash Bandicoot N. Sane Trilogy crashes while entering main menu in NtGetContextThread

https://bugs.winehq.org/show_bug.cgi?id=45428

Bug ID: 45428
           Summary: Crash Bandicoot N. Sane Trilogy crashes while entering
                    main menu in NtGetContextThread
           Product: Wine
           Version: 3.11
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ntdll
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 61752
  --> https://bugs.winehq.org/attachment.cgi?id=61752
Patch to fix the crash in NtGetContextThread

The application calls NtGetContextThread with the context being set to NULL.

This bug may already be resolved, please see the attached patch.

I will try to submit this to wine-devel in the coming days.

[Bug 45428] Crash Bandicoot N. Sane Trilogy crashes while entering main menu in NtGetContextThread

https://bugs.winehq.org/show_bug.cgi?id=45428

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Crash Bandicoot N. Sane     |Crash Bandicoot N. Sane
                   |Trilogy crashes while       |Trilogy (Steam) crashes
                   |entering main menu in       |while entering main menu in
                   |NtGetContextThread          |ntdll.NtGetContextThread()
                   |                            |with NULL context
                URL|                            |https://store.steampowered.
                   |                            |com/app/731490
                 CC|                            |[e-mail]

--- Comment #1 from Anastasius Focht  ---
Hello folks,

is that with the legit Steam version?
I'm curious because some users reported it running without any patches:

https://www.reddit.com/r/wine_gaming/comments/8w3iv2/crash_bandicoot_n_sane_...

--- quote ---
Seems to run exceptionally well. Thanks for sharing.
--- quote ---

Some experience a crash:

https://github.com/doitsujin/dxvk/issues/483 (legit Steam version)

https://www.reddit.com/r/wine_gaming/comments/8vjdvc/crash_bandicoot_n_sane_...
(non-legit Steam version)

A call to 'ntdll.NtGetContextThread()' with NULL context doesn't make much
sense. Is that part of the DRM scheme?
Do you have any trace/relay log with some additional context information?

Regards

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

--- Comment #2 from Johannes Brandstätter  ---
This patch is a fix for the official Steam version.

The crash was the same as this one:
https://www.reddit.com/r/wine_gaming/comments/8vjdvc/crash_bandicoot_n_sane_...

I don't have any backtraces or logs of the crash.
But the backtrace did walk over kernel32's GetThreadContext to ntdll's
NtGetContextThread.

I did not dig deeper what the application was trying to do, I just tried what
is now in the patch and that fixed it for me.

Maybe it is some left over code used for debugging the game?

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ec418e7f55f5e38f8825187ae5d
                   |                            |fe33fec31689b
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Gijs Vermeulen  ---
Fixed by: ec418e7f55f5e38f8825187ae5dfe33fec31689b

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 3.13.

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.0.x

[Bug 45428] Crash Bandicoot N. Sane Trilogy (Steam) crashes while entering main menu in ntdll.NtGetContextThread() with NULL context

https://bugs.winehq.org/show_bug.cgi?id=45428

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.0.x                       |---

--- Comment #5 from Michael Stefaniuc  ---
Removing the 3.0.x milestone from bugs included in 3.0.3.