[Bug 34948] New: Chessmaster 10th Edition: title bar covers part of the player login window (Mac OS X only bug)

http://bugs.winehq.org/show_bug.cgi?id=34948

Bug #: 34948
           Summary: Chessmaster 10th Edition: title bar covers part of the
                    player login window (Mac OS X only bug)
           Product: Wine
           Version: 1.7.6
          Platform: x86
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 46571
  --> http://bugs.winehq.org/attachment.cgi?id=46571
Chessmaster 10 Log

See the screenshot.

On Ubuntu it looks fine. The problem can be reproduced in the demo (check out
the link).

Mac OS X 10.9, ATI HD 2600 Pro, Mac Driver

[Bug 34948] Chessmaster 10th Edition: title bar covers part of the player login window (Mac OS X only bug)

http://bugs.winehq.org/show_bug.cgi?id=34948

--- Comment #1 from WineBuG  2013-11-19 09:12:11 CST ---
Created attachment 46572
  --> http://bugs.winehq.org/attachment.cgi?id=46572
Player Login Window

[Bug 34948] Chessmaster 10th Edition: title bar covers part of the player login window (Mac OS X only bug)

http://bugs.winehq.org/show_bug.cgi?id=34948

WineBuG  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.fileplanet.com/1
                   |                            |42269/download/Chessmaster-
                   |                            |10th-Edition-Trial-Client
                 CC|                            |[e-mail]

[Bug 34948] Chessmaster 10th Edition: title bar covers part of the player login window (Mac OS X only bug)

http://bugs.winehq.org/show_bug.cgi?id=34948

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Ken Thomases  2013-11-20 17:14:02 CST ---
The issue here is that the app is custom drawing the window's non-client area
(its frame).  This is a situation where Wine often has problems.  The app
doesn't do anything to "tell" Wine that it's going to do this, so the graphics
drivers assume that they should replace the non-client area with
platform-specific window decorations.

It is more or less a fluke that this doesn't happen with the X11 driver.  The
app sets the WS_EX_TOOLWINDOW extended style on the window and the X11 driver
doesn't support that.  (I think because many X11 window managers don't handle
tool windows well.)  Because it doesn't support it, the X11 driver simply
disables window manager decorations on such windows and lets user32 draw the
non-client area.  The app intercedes and user32 never gets the chance.

So, the X11 driver's WS_EX_TOOLWINDOW limitation happens to hide the fact that
it doesn't cope well with apps which do custom drawing of the non-client area.

The Mac driver doesn't cope any better with apps which do custom drawing of the
non-client area but it does support WS_EX_TOOLWINDOW windows.  So, it doesn't
turn off window decorations and that conflicts with the app's custom drawing.

I have submitted a patch http://source.winehq.org/patches/data/100585 to add
support for a new registry setting to the Mac driver.  Once that patch is
applied, if you set:

[HKEY_CURRENT_USER\Software\Wine\Mac Driver]
"DisableWindowDecorations"="1"

then the Mac driver won't decorate the window and it will look like it should. 
As usual, you can also set that per-app by using the key
[HKEY_CURRENT_USER\Software\Wine\AppDefaults<whatever>.exe\Mac Driver]
instead.

This registry setting is similar to the X11-centric "Allow the window manager
to decorate the windows" setting in winecfg, but they don't interact.  Some day
winecfg needs to be modified so that it has settings for the Mac driver, too.

[Bug 34948] Chessmaster 10th Edition: title bar covers part of the player login window (Mac OS X only bug)

http://bugs.winehq.org/show_bug.cgi?id=34948

--- Comment #3 from Ken Thomases  2013-11-21 14:52:16 CST ---
The previous patch is being superseded by
http://source.winehq.org/patches/data/100610.  That changes the registry key
from "DisableWindowDecorations" which you would set to "1" to disable
decorations to "Decorated" which you would set to "0" to disable decorations.

[Bug 34948] Chessmaster 10th Edition: title bar covers part of the player login window (Mac OS X only bug)

http://bugs.winehq.org/show_bug.cgi?id=34948

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2013-11-22 12:50:26 CST ---
Closing bugs fixed in 1.7.7.