[Bug 24332] New: WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Summary: WoW: Cataclysm crashes on startup (needs
                    GetUserDefaultLocaleName impl)
           Product: Wine
           Version: 1.3.2
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

In Cataclysm build 12942, opening wow outputs the following, instantly followed
by the dbghelp crash from bug 24068.

fixme:process:GetLogicalProcessorInformation ((nil),0x11efd24): stub
fixme:process:GetLogicalProcessorInformation (0x11ef640,0x11efc40): stub
fixme:nls:GetUserDefaultLocaleName (0x11efad4, 85) stub!
wine: Unhandled page fault on read access to 0x00000000 at address 0x7bfcb4ac
(thread 0009), starting debugger...
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code
(0x7bfcb4ac).

Overriding dbghelp with WoW's native dbghelp confirms that
GetUserDefaultLocaleName is needed:

ERROR #134 (0x85100086) Fatal Condition
Program:    Z:\home\adys\wow\cata\wow.exe
File:    .\W32\Locale.cpp
Line:    832

Failed to get locale name: Success

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #1 from Jerome Leclanche  2010-09-10 00:56:52 CDT ---
Changing GetUserDefaultLocaleName to return 1 is enough to make WoW run.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download                    |

--- Comment #2 from Jerome Leclanche  2010-09-10 02:06:28 CDT ---
(-download actually since this is cataclysm)

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #3 from Rudi Mayerhofer  2010-09-10 07:27:06 CDT ---
Created an attachment (id=30676)
 --> (http://bugs.winehq.org/attachment.cgi?id=30676)
Simple GetUserDefaultLocaleName Impl

Created a quick and simple implementation for GetUserDefaultLocaleName
using GetUserDefaultLCID() and LCIDToLocaleName().

Tested and working with Cataclysm Beta 12942.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Jerome Leclanche  2010-09-10 07:30:18 CDT ---
(In reply to comment #3)
> Created an attachment (id=30676)

--> (http://bugs.winehq.org/attachment.cgi?id=30676) [details]
> Simple GetUserDefaultLocaleName Impl
>
> Created a quick and simple implementation for GetUserDefaultLocaleName
> using GetUserDefaultLCID() and LCIDToLocaleName().
>
> Tested and working with Cataclysm Beta 12942.

Looks good. MSDN also specifies:

ERROR_INSUFFICIENT_BUFFER. A supplied buffer size was not large enough, or it
was incorrectly set to NULL.

You might want to check for this? Of course MSDN is shoddy at best and it might
require a test..

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Rudi Mayerhofer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Rudi Mayerhofer  2010-09-10 07:39:24 CDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=30676)

--> (http://bugs.winehq.org/attachment.cgi?id=30676) [details] [details]
> > Simple GetUserDefaultLocaleName Impl
> >
> > Created a quick and simple implementation for GetUserDefaultLocaleName
> > using GetUserDefaultLCID() and LCIDToLocaleName().
> >
> > Tested and working with Cataclysm Beta 12942.
>
> Looks good. MSDN also specifies:
>
> ERROR_INSUFFICIENT_BUFFER. A supplied buffer size was not large enough, or it
> was incorrectly set to NULL.
>
> You might want to check for this? Of course MSDN is shoddy at best and it might
> require a test..

The ERROR_INSUFFICIENT_BUFFER should be handled by LCIDToLocaleName() already,
MSDN specifies that case for LCIDToLocaleName() as well.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dmitry Timoshkov  2010-09-10 08:16:46 CDT ---
*** Bug 24335 has been marked as a duplicate of this bug. ***

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #7 from Jerome Leclanche  2010-09-10 12:41:33 CDT ---
(In reply to comment #5)
> The ERROR_INSUFFICIENT_BUFFER should be handled by LCIDToLocaleName() already,
> MSDN specifies that case for LCIDToLocaleName() as well.

Sounds good. You should send it to [e-mail].

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24068

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from [e-mail] 2010-09-13 02:05:08 CDT ---
*** This bug has been confirmed by popular vote. ***

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Bug 24332 depends on bug 24068, which changed state.

Bug 24068 Summary: Crash in dbghelp (WoW)
http://bugs.winehq.org/show_bug.cgi?id=24068

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

JK Wood  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from JK Wood  2010-09-13 17:43:04 CDT ---
The attached patch fixes it for me. Thanks!

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail] 2010-09-15 03:36:56 CDT ---
This bug also affects WoW 4.0.1 Build 12941, the current PTR client.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #11 from [e-mail] 2010-09-15 16:35:23 CDT ---
this is preventing me from running the 4.01 ptr and possible the next version
of the game launcher. I am a total command line newb so making a file from
source and patching this is really out of the question. IS this going to be
rolled into the next version of wine so i can just update it ? or can someone
point me to a patched version for Ubuntu 10.04 X64 ?

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #12 from Jerome Leclanche  2010-09-15 17:21:00 CDT ---
A patch has been sent, it should be in git soon and in the next version of Wine
(1.3.3) if nothing goes wrong.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Jerome Leclanche  2010-09-15 18:36:43 CDT ---
Fixed by 2637bb9de7feacf2df5a8c1528bd22dab2920174.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #14 from Robert Breithuber  2010-09-16 11:15:47 CDT ---
Created an attachment (id=30799)
 --> (http://bugs.winehq.org/attachment.cgi?id=30799)
log/backtrace

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Robert Breithuber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30799|application/octet-stream    |text/plain
          mime type|                            |

--- Comment #15 from Robert Breithuber  2010-09-16 11:21:17 CDT ---
(From update of attachment 30799)
does not work for me, see attched log/backtrace

using ubuntu lucid wine1.3-1.3.2 sources from ppa

i am sure i patched the file correctly, the section in the patched locale.c
looks like this:

INT WINAPI GetUserDefaultLocaleName(LPWSTR localename, int buffersize)
{
    LCID userlcid;

TRACE("%p, %d\n", localename,  buffersize);

userlcid = GetUserDefaultLCID();
    return LCIDToLocaleName(userlcid, localename, buffersize, 0);
}

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

--- Comment #16 from Juan Lang  2010-09-16 11:27:42 CDT ---
(In reply to comment #15)
> (From update of attachment 30799 [details])
> does not work for me, see attched log/backtrace
>
> using ubuntu lucid wine1.3-1.3.2 sources from ppa

This is an unrelated problem, already fixed in latest git.  Get source from
git, or wait for next release.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard  2010-09-18 13:06:16 CDT ---
Closing bugs fixed in 1.3.3.

[Bug 24332] WoW: Cataclysm crashes on startup (needs GetUserDefaultLocaleName impl)

http://bugs.winehq.org/show_bug.cgi?id=24332

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2637bb9de7feacf2df5a8c1528b
                   |                            |d22dab2920174