[Bug 20105] New: Fujiprint/Fotokasten fails to update due to unhandled xml type

http://bugs.winehq.org/show_bug.cgi?id=20105

Summary: Fujiprint/Fotokasten fails to update  due to unhandled
                    xml type
           Product: Wine
           Version: 1.1.29
          Platform: PC
               URL: http://www.fotokasten.de/index.php?ftkPage=static&ftkV
                    iew=ftksoftware
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Similar to bug #15625, wine's xml implementation misses some bits that causes
fujiprint's photo album software to fail.

When starting the software, I get:
> err:msxml:xmlnode_get_baseName Unhandled type 8

Using the native msxml3 does not give this behavior.
That error leads to the problem that it cannot update its price list from the
online store.

See also bug #20104 for the same software.

[Bug 20105] Fujiprint/Fotokasten fails to update

http://bugs.winehq.org/show_bug.cgi?id=20105

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
          Component|msxml3                      |-unknown
            Summary|Fujiprint/Fotokasten fails  |Fujiprint/Fotokasten fails
                   |to update  due to unhandled |to update
                   |xml type                    |

--- Comment #1 from Vitaliy Margolen   2009-09-20 11:13:46 ---
Please attach (as a plain text file) complete terminal output showing the
problem.

[Bug 20105] Fujiprint/Fotokasten fails to update

http://bugs.winehq.org/show_bug.cgi?id=20105

--- Comment #2 from Nikolay Sivov   2010-02-10 07:00:08 ---
Hi, Christian.

I doubt it's your problem:

---
err:msxml:xmlnode_get_baseName Unhandled type 8
---

Anyway it's silenced in current git and tested. Waiting for terminal output.

[Bug 20105] Fujiprint/Fotokasten fails to update

http://bugs.winehq.org/show_bug.cgi?id=20105

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|-unknown                    |msxml3
     Ever Confirmed|0                           |1

--- Comment #3 from Nikolay Sivov   2010-02-10 10:08:49 ---
With msxml3 and msxml4 set to native it goes further, but displays an internal
update server failure.
> From a +msxml log:

---
001e:trace:msxml:domattr_QueryInterface 0x1ab230
{2933bf80-7b36-11d2-b20e-00c04f983e60} 0x33f994
001e:trace:msxml:xmlnode_get_nodeType 0x1ab230 0x33f9d8
001e:trace:msxml:xmlnode_get_nodeType 0x1ab230 0x33fa48
001e:trace:msxml:xmlnode_get_nodeType 0x1ab230 0x33fa00
001e:trace:msxml:xmlnode_get_nodeValue 0x1ab230 0x33fa00
001e:trace:msxml:xmlnode_get_nodeValue 0x1ab230 returned L"Product Texts Prints
& Posters"
001e:trace:msxml:xmlnode_get_nodeType 0x1ab230 0x33fa1c
001e:trace:msxml:xmlnode_put_nodeValue 0x1ab230 type(2)
001e:trace:msxml:xmlnode_put_nodeValue new value (L"Product Texts Prints &
Posters")
error : unterminated entity reference         Posters
---

So libxml2 is unhappy about '&' in new attribute string value we're trying to
put.
The cause is in improper usage of xmlNodeSetContent() call we do in
IXMLDOMNode_put_nodeValue(). According to documentation we need to perform
string escaping before this call.

A patch like this:
-- patch --
diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index da9afd2..3d5a06e 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -351,13 +351,21 @@ static HRESULT WINAPI xmlnode_put_nodeValue(
     case XML_COMMENT_NODE:
     case XML_PI_NODE:
     case XML_TEXT_NODE:
-      {
+    {
+        xmlChar *escaped;
+
+        TRACE("new value (%s)\n", debugstr_w(V_BSTR(&string_value)));
+
         str = xmlChar_from_wchar(V_BSTR(&string_value));
-        xmlNodeSetContent(This->node, str);
+        escaped = xmlEncodeEntitiesReentrant(This->node->doc, str);
         heap_free(str);
+
+        xmlNodeSetContent(This->node, escaped);
+        xmlFree(escaped);
+
         hr = S_OK;
         break;
-      }
+    }
     default:
         /* Do nothing for unsupported types. */
         break;
-- patch --

fixed libxml2 error but doesn't help for update process.

Anyway this found should be fixed. Changing component.

[Bug 20105] Fujiprint/Fotokasten fails to update

http://bugs.winehq.org/show_bug.cgi?id=20105

--- Comment #4 from Nikolay Sivov  2010-11-05 13:56:52 CDT ---
Special chars escaping is fixed with 8f976c5d5350c46a7b52e9096fb1b6dc849e82e0.
Next problem with missed support of DTD nodes is fixed with
e9e58f07d2ca688bd14c27ec0b37d567416456ed.

Will figure out what is a next problem.

[Bug 20105] Fujiprint/Fotokasten fails to update

http://bugs.winehq.org/show_bug.cgi?id=20105

--- Comment #5 from Nikolay Sivov  2010-11-07 15:48:33 CST ---
Actually with native msxml3/msxml4 I'm still not able to use update function.

[Bug 20105] Fujiprint/Fotokasten fails to update

http://bugs.winehq.org/show_bug.cgi?id=20105

--- Comment #6 from [e-mail] 2013-06-27 12:29:55 CDT ---
This ticket has not been updated for over 900 days.

Is this still an issue in wine version 1.6-rc3 or higher or is this to be
closed as abandoned ?

[Bug 20105] Fujiprint/Fotokasten fails to update (msxml3 missing support for special characters escaping and DTD nodes)

https://bugs.winehq.org/show_bug.cgi?id=20105

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e9e58f07d2ca688bd14c27ec0b3
                   |                            |7d567416456ed
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED
            Summary|Fujiprint/Fotokasten fails  |Fujiprint/Fotokasten fails
                   |to update                   |to update (msxml3 missing
                   |                            |support for special
                   |                            |characters escaping and DTD
                   |                            |nodes)

--- Comment #7 from Anastasius Focht  ---
Hello folks,

resolving 'fixed' with last commit sha1 mentioned.

https://source.winehq.org/git/wine.git/commitdiff/e9e58f07d2ca688bd14c27ec0b...

Reusing the ticket over and over again for multiple issues should be avoided.

Yes, the app still suffers from msxml3 insufficiencies but that should
potentially go into new tickets since the normal app startup is also affected.
Be sure to check for duplicates (very likely) before creating new tickets.

Regards

[Bug 20105] Fujiprint/Fotokasten fails to update (msxml3 missing support for special characters escaping and DTD nodes)

https://bugs.winehq.org/show_bug.cgi?id=20105

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.52.