[Bug 21238] New: Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

Summary: Stranded II: Bitmap loading errors
           Product: Wine
           Version: 1.1.35
          Platform: x86
               URL: http://appdb.winehq.org/objectManager.php?sClass=versi
                    on&iId=10876
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Some bitmaps in Stranded II are messed up with WINE, but work fine in windows.
For example, the mouse-cursor and title in main-menu are wrapped wrong. The
left part is cut off and added on the right side. Here's an image:
http://appdb.winehq.org/appimage.php?iId=17662

I tried around a bit and found something about that. The mousecursor and title
bitmaps (in mods/s2/sys/gfx/) are messed up ingame and both non-power-of-two
textures. The "shoot"-cursor is 64x64 and looks ok. I resized them to make
their width a power-of-two one. The title looks okay and the menu-cursor did
too.
Then I made the shoot-cursor 63x63 and tested again. It was messed up then.

I will attach the bitmaps I used. You can download the game for free here:
http://stranded.unrealsoftware.de/s2_download.php (I suggest zip-download on
the bottom of the page)

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

John Haywards  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #1 from John Haywards   2010-01-03 09:10:14 ---
Created an attachment (id=25518)
 --> (http://bugs.winehq.org/attachment.cgi?id=25518)
Bitmaps I used

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #2 from John Haywards   2010-01-03 09:11:40 ---
Created an attachment (id=25519)
 --> (http://bugs.winehq.org/attachment.cgi?id=25519)
log using wine .35

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #3 from John Haywards  2010-09-14 04:59:35 CDT ---
Still in wine 1.3.2

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #4 from GyB  2011-10-23 10:12:25 CDT ---
Created attachment 37080
  --> http://bugs.winehq.org/attachment.cgi?id=37080
screenshot, comparison between 0.9.38 and 0.9.39

The problem is still present in Wine-1.3.31.
Besides the mouse pointer and the title, it affects several objects in the
game: the needle of the compass in the upper right corner and the user
interface in the lower right corner. There is a strange, diagonal artefact in
the diary (as if the pages were cut in half).

I found out that Wine-0.9.38 displayed those items correctly and regression
testing ended with

6e5a5d2736922b7411668b5081e05b7a4100ebb6 is the first bad commit
commit 6e5a5d2736922b7411668b5081e05b7a4100ebb6
Author: Stefan Dösinger 
Date:   Fri Jun 8 22:28:04 2007 +0200

wined3d: DDraw surfaces are QWORD aligned.

:040000 040000 7ef9b91372f0382feeaac98f8a17b2f4df59ce6a
0bc04d7266db161637845167e83017e3d0e1ebed M    dlls

Fedora 15 x86
Nvidia 250 / driver 280.13
X.Org X Server 1.10.4

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                URL|http://appdb.winehq.org/obj |http://www.strandedonline.d
                   |ectManager.php?sClass=versi |e/s2_download.php
                   |on&iId=10876                |
           Keywords|                            |regression
          Component|-unknown                    |directx-d3d
                 CC|                            |[e-mail],
                   |                            |[e-mail]
     Ever Confirmed|0                           |1
    Regression SHA1|                            |6e5a5d2736922b7411668b5081e
                   |                            |05b7a4100ebb6

--- Comment #5 from GyB  2011-10-23 10:14:49 CDT ---
Added Stefan to CC and filling some fields.

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Stefan Dösinger  2011-11-13 16:20:40 CST ---
It looks like sysmem surfaces have a 4-byte aligned pitch, while video memory
surfaces have higher alignment, most likely card/driver dependent. This is true
in d3d9 as well. My Radeon X5700 has 32 byte aligned DEFAULT pool surfaces in
d3d9 on Windows 7.

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #7 from Stefan Dösinger  2012-02-02 09:14:07 CST ---
Additional testing shows that the current behavior is correct for ddraw, all
surface types are 8 byte aligned. However, the game creates the surfaces
causing the issue with a manually specified lpSurface and lPitch member:

trace:file:wine_nt_to_unix_file_name L"\??\C:\Programme (x86)\Stranded
II\mods\Stranded II\sys\gfx\title.bmp"
...
trace:ddraw:CreateSurface  (0x136728) Requesting surface desc :
trace:ddraw:DDRAW_dump_members  - DDSD_CAPS : DDSCAPS_OFFSCREENPLAIN
DDSCAPS_SYSTEMMEMORY 
trace:ddraw:DDRAW_dump_members  - DDSD_HEIGHT : 239
trace:ddraw:DDRAW_dump_members  - DDSD_WIDTH : 539
trace:ddraw:DDRAW_dump_members  - DDSD_PITCH : 2156
trace:ddraw:DDRAW_dump_members  - DDSD_LPSURFACE : 0x830116c
trace:ddraw:DDRAW_dump_members  - DDSD_PIXELFORMAT : ( DDPF_ALPHAPIXELS
DDPF_RGB , RGB bits: 32,  R 00ff0000 G 0000ff00 B 000000ff A ff000000)

Currently we don't honor the pitch set by the app.

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #8 from GyB  2012-07-08 10:09:30 CDT ---
Still a bug in Wine 1.5.8

Fedora 17 x86
Nvidia 250 / driver 295.59
X.Org X Server 1.12.2

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #9 from Bruno Jesus  2013-06-03 22:06:29 CDT ---
Still in wine 1.5.31.

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #10 from Henri Verbeet  2013-06-13 07:33:12 CDT ---
Created attachment 44786
  --> http://bugs.winehq.org/attachment.cgi?id=44786
patch

The attached patch should help.

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

--- Comment #11 from Bruno Jesus  2013-06-13 07:55:37 CDT ---
(In reply to comment #10)
> The attached patch should help.

Yes, it fixes the issue =)

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4de77fa23f1c41dbafdcf8382dc
                   |                            |b5daf39b6b5c8
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Henri Verbeet  2013-06-15 01:44:22 CDT ---
Should be fixed by commit 4de77fa23f1c41dbafdcf8382dcb5daf39b6b5c8.

[Bug 21238] Stranded II: Bitmap loading errors

http://bugs.winehq.org/show_bug.cgi?id=21238

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2013-06-21 13:32:58 CDT ---
Closing bugs fixed in 1.6-rc3.