http://bugs.winehq.org/show_bug.cgi?id=23214
Summary: WM Desktop Alert crashes immediately after being run Product: Wine Version: 1.2-rc3 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: killzenator@gmail.com
Right after being run the WM Desktop Alert crashes before it can fetch the latest deal from the site or display any kind of notification
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #1 from Pat killzenator@gmail.com 2010-06-16 10:44:03 --- Created an attachment (id=28890) --> (http://bugs.winehq.org/attachment.cgi?id=28890) Log of "wine ./WM-Desktop-Alert.exe"
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #2 from Juan Lang juan_lang@yahoo.com 2010-06-16 11:14:57 --- Does 'winetricks gdiplus' work around the problem?
http://bugs.winehq.org/show_bug.cgi?id=23214
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW URL| |http://images.whiskeymiliti | |a.com/docs/bin/wm/WMDesktop | |Alert.exe Component|-unknown |windowscodecs Ever Confirmed|0 |1
--- Comment #3 from Andrew Nguyen arethusa26@gmail.com 2010-06-18 02:38:20 --- It does, but some tracing suggests that it's not the real cause of the failure. After adding some traces to dlls/windowscodecs/bmpdecode.c and turning on the +gdiplus,+wincodecs debug channels I see:
trace:gdiplus:GdipCreateBitmapFromFile (L"C:\Program Files\WhiskeyMilitia\Desktop Alert\Skins\WM\background.bmp") 0x32f0f8 trace:gdiplus:GdipCreateStreamOnFile (L"C:\Program Files\WhiskeyMilitia\Desktop Alert\Skins\WM\background.bmp", 2147483648, 0x32f088) trace:gdiplus:GdipCreateBitmapFromStream 0x18c6f0 0x32f0f8 trace:gdiplus:GdipLoadImageFromStream (0x18c6f0, 0x32f0f8) ... trace:gdiplus:GdipCreateBitmapFromScan0 440 168 0 0x22009 (nil) 0x32ef68 trace:gdiplus:GdipCreateBitmapFromScan0 <-- 0x18ca58 trace:gdiplus:GdipBitmapLockBits 0x18ca58 (nil) 2 0x22009 0x32ef2c trace:wincodecs:BmpFrameDecode_CopyPixels (0x18c7fc,0x32ef1c,1760,1760,0x3820000) trace:wincodecs:BmpFrameDecode_ReadRLE8 0x18c7f8 trace:wincodecs:BmpFrameDecode_ReadRLE8 hr = 0x00000000 trace:wincodecs:BmpFrameDecode_ReadRLE8 hr = 0x00000000, bytesread = 1024, palettesize = 1024 trace:wincodecs:BmpFrameDecode_ReadRLE8 hr = 0x00000000 trace:wincodecs:BmpFrameDecode_ReadRLE8 hr = 0x00000000, bytesread = 12642, rlesize = 73922 trace:wincodecs:BmpFrameDecode_CopyPixels hr = 0x80004005 trace:gdiplus:decode_image_wic hr = 0x80004005 ...
So, the WIC BMP decoder is having trouble with the supplied background.bmp image. Using either native gdiplus or native windowscodecs is sufficient to get the app to start.
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #4 from Pat killzenator@gmail.com 2010-06-18 19:34:04 --- True winetricks gdiplus does get the app to run but when the notification scrolls up on desktop it is definitely slower popping up than on windows..not that it matters all that much I just thought Id mention it.
Thanks for the suggestion I was really missing this :P Will re-submit test results with rc4
http://bugs.winehq.org/show_bug.cgi?id=23214
Pat killzenator@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|WM Desktop Alert crashes |WM Desktop Alert crashes |immediately after being run |immediately after being | |run, without native gdiplus
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #5 from Vincent Povirk madewokherd@gmail.com 2010-07-13 14:57:10 --- It'd be nice if someone could post that background.bmp file somewhere.
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #6 from Andrew Nguyen arethusa26@gmail.com 2010-07-13 18:38:31 --- I've simply tossed the image onto filebin:
http://filebin.ca/phbato/background.bmp
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #7 from Vincent Povirk madewokherd@gmail.com 2010-07-16 12:01:17 --- Created an attachment (id=29632) --> (http://bugs.winehq.org/attachment.cgi?id=29632) patch to make WIC ignore rle size for rle8 bitmaps
Here's a patch that allows the bitmap to load.
I'm not sure if this is the right approach. It will fail to load a bitmap that doesn't end by moving the cursor to the row after the last row or explicitly ending the rle data.
Perhaps I should compare it with the RLE bitmap loading code in other parts of Wine.
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #8 from Vincent Povirk madewokherd@gmail.com 2010-07-16 12:06:33 --- Hmm, X11DRV_DIB_SetImageBits_RLE8 will actually overrun the buffer in the case where my patch would introduce a failure. So it's probably OK.
http://bugs.winehq.org/show_bug.cgi?id=23214
--- Comment #9 from Vincent Povirk madewokherd@gmail.com 2010-07-16 13:46:59 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2010-July/090516.html
http://bugs.winehq.org/show_bug.cgi?id=23214
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #10 from Andrew Nguyen arethusa26@gmail.com 2010-07-19 23:11:43 --- The patch was committed as 4dfcf843aa9a3057622d384cf905dbd13967b707, marking fixed.
http://bugs.winehq.org/show_bug.cgi?id=23214
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #11 from Alexandre Julliard julliard@winehq.org 2010-07-30 12:58:08 --- Closing bugs fixed in 1.3.0.
https://bugs.winehq.org/show_bug.cgi?id=23214
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |4dfcf843aa9a3057622d384cf90 | |5dbd13967b707 CC| |focht@gmx.net
-
wine-bugs＠winehq.org