[Bug 44091] New: The Witcher: Enhanced Edition crashes during gameplay

https://bugs.winehq.org/show_bug.cgi?id=44091

Bug ID: 44091
           Summary: The Witcher: Enhanced Edition crashes during gameplay
           Product: Wine
           Version: 2.22
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 67926ec8c344db4250f1e74a5943d0b8a536e950
      Distribution: ---

Created attachment 59807
  --> https://bugs.winehq.org/attachment.cgi?id=59807
terminal output

I tested this bug with the GOG.com version of the game.
https://www.gog.com/game/the_witcher

The game loads to the menu properly, but it crashes frequently during gameplay.
Crashes occur:
- when starting a new game
- on area transitions
- when loading a previously saved game (some saved games load correctly though)
- when the Witcher enters Meditation mode (e.g. by a campfire).

The game works properly in Wine 2.22, this regression appears in the git
version.
Reverting the following commit fixes the problem for me:

commit 67926ec8c344db4250f1e74a5943d0b8a536e950
Author: Piotr Caban 
Date:   Tue Nov 28 19:48:33 2017 +0100

msvcrt: Set errno when close() is called on already closed fd.

wine-2.22-47-g6f790606c0
Arch Linux x86_64

[Bug 44091] The Witcher: Enhanced Edition crashes during gameplay

https://bugs.winehq.org/show_bug.cgi?id=44091

--- Comment #1 from Béla Gyebrószki  ---
Created attachment 59808
  --> https://bugs.winehq.org/attachment.cgi?id=59808
game error log

After crashing, the game creates a minidump and and errlog.txt file. Not sure
if it helps at all but I'm attaching the error.log file here because some
callstacks appear in it.

[Bug 44091] The Witcher: Enhanced Edition crashes during gameplay

https://bugs.winehq.org/show_bug.cgi?id=44091

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Piotr Caban  ---
I've sent a patch that is meant to fix this bug. Could you please give it a
try?
https://source.winehq.org/patches/data/139076

[Bug 44091] The Witcher: Enhanced Edition crashes during gameplay

https://bugs.winehq.org/show_bug.cgi?id=44091

--- Comment #3 from Béla Gyebrószki  ---
(In reply to Piotr Caban from comment #2)
> I've sent a patch that is meant to fix this bug. Could you please give it a
> try?
> https://source.winehq.org/patches/data/139076

The patch fixes the crashes that I observed earlier, thank you.

[Bug 44091] The Witcher: Enhanced Edition crashes during gameplay

https://bugs.winehq.org/show_bug.cgi?id=44091

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |96584d858a75ed0fc627ab9912b
                   |                            |ec815511596cb
             Status|NEW                         |RESOLVED

--- Comment #4 from Béla Gyebrószki  ---
Fixed with
https://source.winehq.org/git/wine.git/commit/96584d858a75ed0fc627ab9912bec8...

[Bug 44091] The Witcher: Enhanced Edition crashes during gameplay

https://bugs.winehq.org/show_bug.cgi?id=44091

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 3.0-rc1.