http://bugs.winehq.org/show_bug.cgi?id=1347
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source URL|http://appdb.winehq.org/app |http://sourceforge.net/proj |view.php?appId=1029 |ects/virtualdub/files/virtu | |aldub-win/1.7.0.25854/Virtu | |alDub-1.7.0.zip/download Severity|normal |major
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major
Ronny Standtke Ronny.Standtke@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |Ronny.Standtke@gmx.net
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor
Stephen Eilert spedrosa@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |spedrosa@gmail.com
Saulius K. saulius2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2@gmail.com
Carlton Hobbs carlton.hobbs@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carlton.hobbs@gmail.com
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #13834|0 |1 is obsolete| |
G.vorr bugs.glenn+wine@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.glenn+wine@gmail.com
--- Comment #44 from Ken Sharp kennybobs@o2.co.uk 2009-04-28 15:21:28 --- *** Bug 18212 has been marked as a duplicate of this bug. ***
--- Comment #45 from Ken Sharp kennybobs@o2.co.uk 2009-08-10 19:32:23 --- A lot of people reporting the same problem for a lot of apps - moving to major. Source available for VirtualDub.
--- Comment #46 from Vitaliy Margolen vitaliy@kievinfo.com 2009-08-10 21:44:44 --- This is a trivial GUI problem nothing major about it.
--- Comment #47 from Ken Sharp kennybobs@o2.co.uk 2009-08-11 06:02:29 --- S103, VirtualDub 1.7 and Quicktime are unusable, the make all the other apps on a system unusable too. Certainly not minor.
--- Comment #48 from Ronny Standtke Ronny.Standtke@gmx.net 2009-08-11 07:12:25 --- The definition of major is: "Major loss of functionality for a wide range of applications", see http://bugs.winehq.org/page.cgi?id=fields.html#importance
I can confirm that a wide range of applications is broken because of this issue, e.g. every application where Quicktime is used destroys the user desktop. Unfortunately, there are a lot of such applications.
--- Comment #49 from Stefan Dösinger stefandoesinger@gmx.at 2009-08-11 08:10:17 --- The apps that blank the screen that way are broken in some form - what they're doing is not compatible with composited desktops. Vista disables Aero in that case.
A workaround for those apps that are still maintained, like QuickTime, is to set winver=vista - that way they'll use an alternate, more sane codepath. QuickTime for example uses d3d9 for drawing instead of DirectDraw rendering to the desktop window.
--- Comment #50 from Vitaliy Margolen vitaliy@kievinfo.com 2009-08-11 08:47:55 --- Minor - For minor loss of functionality, or other problem where an *easy workaround is present* (virtual desktop). Trivial - For a UI glitch that doesn't affect running of a program Does "blanking the screen" affect running the actual program? - No.
--- Comment #51 from Austin English austinenglish@gmail.com 2009-08-11 10:41:48 --- (In reply to comment #50)
Minor - For minor loss of functionality, or other problem where an *easy workaround is present* (virtual desktop). Trivial - For a UI glitch that doesn't affect running of a program Does "blanking the screen" affect running the actual program? - No.
Not all programs have a workaround. E.g., programs that haven't made a Vista version.
--- Comment #52 from B. Wong winehq.org@wongs.net 2009-08-11 11:53:07 --- (In reply to comment #50)
Minor - For minor loss of functionality, or other problem where an *easy workaround is present* (virtual desktop). Trivial - For a UI glitch that doesn't affect running of a program Does "blanking the screen" affect running the actual program? - No.
Actually, switching virtual desktops in order to refresh the screen does not work well enough to call it a workaround. Many of the applications affected by this are unusable if one must constantly switch virtual desktops. This isn't a minor loss of functionality; this is a total loss. The only "workaround" is to simply not run the applications.
I believe Ken Sharp was correct to change this bug to MAJOR.
--- Comment #53 from Stefan Dösinger stefandoesinger@gmx.at 2009-08-11 11:54:35 ---
What´s going to be broken by the fix then?
That'd be a better question for Stefand. I haven't noticed anything broken on my end, but I haven't tested it extensively.
1) Any app that locks the front buffer without a rect limiter and expects this to be fast.
2) Any app that locks the front buffer and passes in a limiting rectangle, but doesn't clip properly will still black out the screen
3) The !(Flags & DDLOCK_WRITEONLY) is a condition that has nothing to do with the problem, it just happens that all QuickTime locks that work properly and require fast performance have this flag set by chance.
4) If apps do a non-writeonly lock once, then a number of full-screen writeonly locks, we'll write the old screen content back. The screen won't be black, it will have outdated content.
(1) Is not much of a problem - those apps would black out the screen right now (2) isn't much of a problem either. Its just no improvement (3) is worrysome. Do the apps still work properly if this WRITEONLY condition is taken away? Do quicktime videos play with proper performance? (This WRITEONLY check is a performance hack on top of the readback hack) (4) Can cause troubles for the user because you could read outdated content in your Linux apps and don't know it.
Alexandre rejected the basic idea of reading the screen content. We have the following options:
*) Move ddraw into the X server. Not going to happen. It was called DGA, and dropped.
*) use the GL ddraw implementation and allow a GL context to be set up against the desktop window(ie, NULL hwnd). We could implement that in winex11 by using a PBuffer and copying the screen into and out of the pbuffer. Still it would be hacky and break compiz. So we have to disable compiz in this case (like vista does), and hope for proper performance, and hope that all drivers support PBuffers(the open source ones don't)
*) Persuade AJ to accept the hack as-is
*) Close this bug as WONTFIX.
--- Comment #54 from Austin English austinenglish@gmail.com 2009-08-11 11:59:04 --- What about having including the hack, and allow it to be enabled/disabled by registry key.
WONTFIX seems a bit much for a bug affecting a lot of applications.
--- Comment #55 from Stefan Dösinger stefandoesinger@gmx.at 2009-08-11 17:10:12 --- (In reply to comment #54)
What about having including the hack, and allow it to be enabled/disabled by registry key.
Either we trust the hack, or we don't. I don't see a point in adding a registry key.
--- Comment #56 from Carlton Hobbs carlton.hobbs@gmail.com 2009-08-15 16:57:57 --- I'm not a programmer, could someone explain how to try the hack so I can see if bug 19733 is a duplicate? It is also a screen blanking problem in the freeware game Pendulumania.
--- Comment #57 from B. Wong winehq.org@wongs.net 2009-08-16 11:53:19 --- (In reply to comment #56)
I'm not a programmer, could someone explain how to try the hack so I can see if bug 19733 is a duplicate? It is also a screen blanking problem in the freeware game Pendulumania.
There is no easy way to try the hack, except to use CrossOver from CodeWeavers.com. There's a free demo you can download. If it doesn't work in CrossOver, then the bugs are separate. If it does work then you're back to recompiling Wine to figure out which patch fixed it.
--- Comment #58 from Austin English austinenglish@gmail.com 2009-08-16 14:12:49 --- Created an attachment (id=23118) --> (http://bugs.winehq.org/attachment.cgi?id=23118) rediffed hack
Works fine in current (1.1.27) wine. Tested against quicktime.
-
wine-bugs＠winehq.org