https://bugs.winehq.org/show_bug.cgi?id=35818
Bug ID: 35818 Summary: mscms/profile tests fail on Fedora Product: Wine Version: 1.7.14 Hardware: x86 URL: https://test.winehq.org/data/77bd74fa2515e8babb6cda265 3a12adad65191dc/linux_ae-fedora64/mscms:profile.html OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: austinenglish@gmail.com
I've noticed that mscms/profile fails consistently on my machine: profile.c:675: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:689: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:729: Test succeeded inside todo block: EnumColorProfilesW() failed (18) profile.c:742: Test succeeded inside todo block: EnumColorProfilesW() failed (18)
and looking at test.winehq.org, it also fails on Alasdair Sinclair's fedora machine.
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #1 from Hans Leidekker hans@meelstraat.net --- Please attach a +mscms trace. Are there any .icm files in c:\windows\system32\spool\drivers\color?
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #2 from Austin English austinenglish@gmail.com --- (In reply to Hans Leidekker from comment #1)
Please attach a +mscms trace. Are there any .icm files in c:\windows\system32\spool\drivers\color?
There are not: [austin@localhost wine-git]$ ls -al ~/.wine/drive_c/windows/system32/spool/drivers/color/ total 8 drwxrwxr-x. 2 austin austin 4096 Mar 19 18:56 . drwxrwxr-x. 5 austin austin 4096 Mar 19 18:56 ..
it's also important to note that make profile.ok doesn't show the issue: [austin@localhost tests]$ rm *ok ; make profile.ok ../../../tools/runtest -q -P wine -T ../../.. -M mscms.dll -p mscms_test.exe.so profile && touch profile.ok fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, 0x32eb18 ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, 0x32e910 ) stub
If I run the .so directly with wine, it does: [austin@localhost tests]$ ../../../loader/wine mscms_test.exe.so profile fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, 0x32eb18 ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, 0x32e910 ) stub profile.c:675: Test failed: EnumColorProfilesA() failed (2) profile.c:689: Test failed: EnumColorProfilesA() failed (2) profile.c:729: Test failed: EnumColorProfilesW() failed (2) profile.c:742: Test failed: EnumColorProfilesW() failed (2) profile: 76 tests executed (0 marked as todo, 4 failures), 0 skipped.
I'll attach a +mscms trace with the second method.
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #3 from Austin English austinenglish@gmail.com --- Created attachment 47830 --> https://bugs.winehq.org/attachment.cgi?id=47830 WINEDEBUG=mscms
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #4 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #2)
If I run the .so directly with wine, it does: [austin@localhost tests]$ ../../../loader/wine mscms_test.exe.so profile fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, 0x32eb18 ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, 0x32e910 ) stub profile.c:675: Test failed: EnumColorProfilesA() failed (2) profile.c:689: Test failed: EnumColorProfilesA() failed (2) profile.c:729: Test failed: EnumColorProfilesW() failed (2) profile.c:742: Test failed: EnumColorProfilesW() failed (2) profile: 76 tests executed (0 marked as todo, 4 failures), 0 skipped.
These lines are marked as todo_wine and it's expected to fail this way under Wine when WINETEST_PLATFORM is not set.
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #5 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #4)
(In reply to Austin English from comment #2)
If I run the .so directly with wine, it does: [austin@localhost tests]$ ../../../loader/wine mscms_test.exe.so profile fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileA ( 0x73524742, 0x32eb18 ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, (nil) ) stub fixme:mscms:SetStandardColorSpaceProfileW ( 0x73524742, 0x32e910 ) stub profile.c:675: Test failed: EnumColorProfilesA() failed (2) profile.c:689: Test failed: EnumColorProfilesA() failed (2) profile.c:729: Test failed: EnumColorProfilesW() failed (2) profile.c:742: Test failed: EnumColorProfilesW() failed (2) profile: 76 tests executed (0 marked as todo, 4 failures), 0 skipped.
These lines are marked as todo_wine and it's expected to fail this way under Wine when WINETEST_PLATFORM is not set.
It fails the same way when running from winetest: ./wine winetest -c -t ae-fedora64 -m austinenglish
profile.c:675: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:689: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:729: Test succeeded inside todo block: EnumColorProfilesW() failed (18) profile.c:742: Test succeeded inside todo block: EnumColorProfilesW() failed (18)
which to my knowledge, is supported. Or did I miss something?
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #6 from Dmitry Timoshkov dmitry@baikal.ru --- (In reply to Austin English from comment #5)
It fails the same way when running from winetest: ./wine winetest -c -t ae-fedora64 -m austinenglish
profile.c:675: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:689: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:729: Test succeeded inside todo block: EnumColorProfilesW() failed (18) profile.c:742: Test succeeded inside todo block: EnumColorProfilesW() failed (18)
which to my knowledge, is supported. Or did I miss something?
It looks like a winetest problem since when running 'make test' there is no failures.
https://bugs.winehq.org/show_bug.cgi?id=35818
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #7 from Austin English austinenglish@gmail.com --- (In reply to Dmitry Timoshkov from comment #6)
(In reply to Austin English from comment #5)
It fails the same way when running from winetest: ./wine winetest -c -t ae-fedora64 -m austinenglish
profile.c:675: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:689: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:729: Test succeeded inside todo block: EnumColorProfilesW() failed (18) profile.c:742: Test succeeded inside todo block: EnumColorProfilesW() failed (18)
which to my knowledge, is supported. Or did I miss something?
It looks like a winetest problem since when running 'make test' there is no failures.
Good point, thanks. That works in 1.2, git bisect is running a script now.
https://bugs.winehq.org/show_bug.cgi?id=35818
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression |
--- Comment #8 from Austin English austinenglish@gmail.com --- My mistake, it didn't work in 1.2.
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #9 from Hans Leidekker hans@meelstraat.net --- (In reply to Austin English from comment #8)
My mistake, it didn't work in 1.2.
I guess this could happen if there's a call to GetICMProfile when you run winetest. If Fedora associates a color profile with the X display then we'll generate an icm file for it in the color directory. Can you check that directory once more after running winetest?
Can you attach a +mscms,+icm,+file trace?
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #10 from Austin English austinenglish@gmail.com --- Created attachment 47835 --> https://bugs.winehq.org/attachment.cgi?id=47835 +mscms,+icm,+file trace
No .icm file there afterward.
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #11 from Hans Leidekker hans@meelstraat.net --- (In reply to Austin English from comment #10)
Created attachment 47835 [details] +mscms,+icm,+file trace
This log doesn't show any real failures because WINETEST_PLATFORM is not set (note that the error code is different). Can you get another trace with winetest.exe?
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #12 from Austin English austinenglish@gmail.com --- (In reply to Hans Leidekker from comment #11)
(In reply to Austin English from comment #10)
Created attachment 47835 [details] +mscms,+icm,+file trace
This log doesn't show any real failures because WINETEST_PLATFORM is not set (note that the error code is different). Can you get another trace with winetest.exe?
Doing: WINEDEBUG=+mscms,+icm,+file ./wine winetest -t ae-fedora64 -m austinenglish mscms:profile -o blah &>> log.txt
profile.c:675: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:689: Test succeeded inside todo block: EnumColorProfilesA() failed (18) profile.c:729: Test succeeded inside todo block: EnumColorProfilesW() failed (18) profile.c:742: Test succeeded inside todo block: EnumColorProfilesW() failed (18) profile: 76 tests executed (0 marked as todo, 4 failures), 0 skipped. mscms:profile done (4) in 0s
I'll attach log.txt
https://bugs.winehq.org/show_bug.cgi?id=35818
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #47830|0 |1 is obsolete| | Attachment #47835|0 |1 is obsolete| |
--- Comment #13 from Austin English austinenglish@gmail.com --- Created attachment 47839 --> https://bugs.winehq.org/attachment.cgi?id=47839 +mscms,+icm,+file trace
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #14 from Austin English austinenglish@gmail.com --- Created attachment 47840 --> https://bugs.winehq.org/attachment.cgi?id=47840 test output
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #15 from Hans Leidekker hans@meelstraat.net --- (In reply to Austin English from comment #13)
Created attachment 47839 [details] +mscms,+icm,+file trace
trace:file:FindFirstFileExW L"C:\windows\system32\spool\drivers\color\*.icm" 0 0x33e5b0 0 (nil) 0 ... trace:file:FindNextFileW returning L"ea2784d6492877e61c1085cc7141f0f2334d95a3.icm" (L"EA27~ZCL.ICM")
As I suspected, it does find a color profile in this case.
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #16 from Austin English austinenglish@gmail.com --- Created attachment 47841 --> https://bugs.winehq.org/attachment.cgi?id=47841 color profile
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #17 from Hans Leidekker hans@meelstraat.net --- Created attachment 47842 --> https://bugs.winehq.org/attachment.cgi?id=47842 patch
Can you try this patch?
https://bugs.winehq.org/show_bug.cgi?id=35818
--- Comment #18 from Austin English austinenglish@gmail.com --- (In reply to Hans Leidekker from comment #17)
Created attachment 47842 [details] patch
Can you try this patch?
With the patch: mscms:profile start dlls/mscms/tests/profile.c - profile.c:677: Test marked todo: EnumColorProfilesA() failed (2) profile.c:691: Test marked todo: EnumColorProfilesA() failed (2) profile.c:731: Test marked todo: EnumColorProfilesW() failed (2) profile.c:744: Test marked todo: EnumColorProfilesW() failed (2) profile: 76 tests executed (4 marked as todo, 0 failures), 0 skipped.
thanks
https://bugs.winehq.org/show_bug.cgi?id=35818
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5752d4835318e73b66e7e9ac3f6 | |22d35c7403080 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #19 from Hans Leidekker hans@meelstraat.net --- Fixed by 5752d4835318e73b66e7e9ac3f622d35c7403080.
https://bugs.winehq.org/show_bug.cgi?id=35818
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.16.
https://bugs.winehq.org/show_bug.cgi?id=35818
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net Component|-unknown |mscms
-
wine-bugs＠winehq.org