https://bugs.winehq.org/show_bug.cgi?id=44883
Bug ID: 44883 Summary: Commit b747d6f6ccdf1699a9242a570d681fa246de592e causes warframe to crash. resolved via overrides Product: Wine Version: 3.5 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: xaudio2 Assignee: wine-bugs@winehq.org Reporter: GloriousEggroll@gmail.com Distribution: ---
As mentioned in summary, after doing a bisect, I found commit b747d6f6ccdf1699a9242a570d681fa246de592e makes wine prefer builtin over native for xaudio2. This causes warframe to crash. I was able to get around it by setting all xaudio2_* overrides to native,builtin in winecfg, but I don't think this is ideal for other games that may have this problem.
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #1 from GloriousEggroll@gmail.com --- it should be noted that reverting this commit also fixes the issue
https://bugs.winehq.org/show_bug.cgi?id=44883
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #2 from Fabian Maurer dark.shadow4@web.de --- commit b747d6f6ccdf1699a9242a570d681fa246de592e Author: Andrew Eikum aeikum@codeweavers.com Date: Mon Mar 26 13:14:20 2018 -0500
xaudio2: Prefer builtin version.
Signed-off-by: Andrew Eikum aeikum@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
Seems like the builtin version always was faulty.
https://bugs.winehq.org/show_bug.cgi?id=44883
zefkerr zefkerrigan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zefkerrigan@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=44883
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|Commit |warframe crashes when |b747d6f6ccdf1699a9242a570d6 |builtin xaudio2 used. |81fa246de592e causes | |warframe to crash. resolved | |via overrides | Regression SHA1| |b747d6f6ccdf1699a9242a570d6 | |81fa246de592e CC| |aeikum@codeweavers.com, | |leslie_alistair@hotmail.com
https://bugs.winehq.org/show_bug.cgi?id=44883
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://store.steampowered.c | |om/agecheck/app/230410/ Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #3 from Andrew Eikum aeikum@codeweavers.com --- Thanks. Can you attach a debug log of the crash with the channels from https://wiki.winehq.org/Sound while using built-in xaudio2?
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #4 from GloriousEggroll@gmail.com --- Created attachment 60967 --> https://bugs.winehq.org/attachment.cgi?id=60967 output of WINEARCH=win64 WINEPREFIX=~/Games/warframe-clean WINEDEBUG=+sound wine64 Warframe.x64.exe -log:/Preprocessing.log -dx10:1 -dx11:1 -threadedworker:1 -cluster:public -language:en -fullscreen:0
this is the output of: WINEARCH=win64 WINEPREFIX=~/Games/warframe-clean WINEDEBUG=+sound wine64 Warframe.x64.exe -log:/Preprocessing.log -dx10:1 -dx11:1 -threadedworker:1 -cluster:public -language:en -fullscreen:0
without xaudio2 overrides
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #5 from Andrew Eikum aeikum@codeweavers.com --- (In reply to GloriousEggroll from comment #4)
WINEDEBUG=+sound
No, you need to use the list of channels at that wiki link in the "What to include when filing a bug" section. Like this:
WINEDEBUG=+tid,+seh,+mmdevapi,+winmm,+driver,+msacm,+midi,+dsound,+dsound3d,+xaudio2,+xapofx,+dmusic,+mci,+pulse,+oss,+alsa,+coreaudio,+timestamp
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #6 from GloriousEggroll@gmail.com --- (In reply to Andrew Eikum from comment #5)
(In reply to GloriousEggroll from comment #4)
WINEDEBUG=+sound
No, you need to use the list of channels at that wiki link in the "What to include when filing a bug" section. Like this:
WINEDEBUG=+tid,+seh,+mmdevapi,+winmm,+driver,+msacm,+midi,+dsound,+dsound3d, +xaudio2,+xapofx,+dmusic,+mci,+pulse,+oss,+alsa,+coreaudio,+timestamp
my apologies, here is the updated debug log. It was too large to attach here: https://gist.github.com/d6b9098b8f512bfe626d34a00f5451f0
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #7 from GloriousEggroll@gmail.com --- and apparently when using gist from commandline it cuts off if it exceeds the size limit.. so here we are again:
https://filebin.ca/3xBNYP5VyNbQ/log.txt
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #8 from Andrew Eikum aeikum@codeweavers.com --- Text files compress well. In the future you can use bzip2 to compress the log and upload it here.
Looking at your log, my guess is this wants operation set support. The last call it makes to xaudio2 stuff before crashing is IXAudio2Impl_CommitChanges, which returns E_NOTIMPL in Wine. Changing that to S_OK may be good enough to work around.
In the meantime, you can workaround by setting xaudio2_7 to native, as you already found.
https://bugs.winehq.org/show_bug.cgi?id=44883
GloriousEggroll@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #60967|0 |1 is obsolete| |
--- Comment #9 from GloriousEggroll@gmail.com --- Created attachment 60995 --> https://bugs.winehq.org/attachment.cgi?id=60995 full debug log
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #10 from GloriousEggroll@gmail.com --- Created attachment 60996 --> https://bugs.winehq.org/attachment.cgi?id=60996 xaudio2_7 patch
can confirm patching xaudio2_7 IXAudio2Impl_CommitChanges to S_OK resolves the issue. Alternatively overriding xaudio2_7 as native, builtin also fixes it in current 3.5. Have attached patch I made for convenience.
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #11 from GloriousEggroll@gmail.com --- update: while the patch allows you to get in game, there are multiple sound/failed sound bugs. additionally this gets spammed in terminal:
Snd [Error]: CreateSourceVoice failed (0x88890008)
no problems with override method
https://bugs.winehq.org/show_bug.cgi?id=44883
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #12 from GloriousEggroll@gmail.com --- this bug also affect FFXIV, Farcry 4, Farcry Primal
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #13 from GloriousEggroll@gmail.com --- Affect Fallout 4 as well (even with dsound patch)
https://bugs.winehq.org/show_bug.cgi?id=44883
cdoublejj cdoublejj@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cdoublejj@yahoo.com
--- Comment #14 from cdoublejj cdoublejj@yahoo.com --- So is this why modern games like GTA 5 has crappy sound and static? why don't they just take said patch back out since it breaks things?
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #15 from Andrew Eikum aeikum@codeweavers.com --- The patch from Comment 10 is not in Wine.
(In reply to GloriousEggroll from comment #11)
update: while the patch allows you to get in game, there are multiple sound/failed sound bugs. additionally this gets spammed in terminal:
Snd [Error]: CreateSourceVoice failed (0x88890008)
no problems with override method
This is Bug 39402.
https://bugs.winehq.org/show_bug.cgi?id=44883
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|warframe crashes when |warframe crashes with |builtin xaudio2 used. |builtin xaudio2, needs | |IXAudio2::CommitChanges
https://bugs.winehq.org/show_bug.cgi?id=44883
Ethan Lee flibitijibibo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |flibitijibibo@gmail.com
--- Comment #16 from Ethan Lee flibitijibibo@gmail.com --- Wine 4.3 has a new XAudio2 implementation that includes CommitChanges; mind you FAudio doesn't support batching either but it won't bail on you when a program attempts to batch. From Wine's perspective, this should be RESOLVED FIXED.
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #17 from Andrew Eikum aeikum@codeweavers.com --- Like Ethan said, we have support for CommitChanges now. Can an earlier reporter retest this with Wine and verify that it is fixed? To avoid the CreateSourceVoice problem, your FAudio needs to be built with WMA (ffmpeg) support.
https://bugs.winehq.org/show_bug.cgi?id=44883
--- Comment #18 from GloriousEggroll@gmail.com --- I can confirm this was fixed quite a long time ago when FAudio was introduced. I worked with Ethan regarding getting this resolved in Warframe before FAudio was added to wine. Additionally the wine-staging patch for this was disabled quite a long time ago when FAudio was introduced. This can be closed.
https://bugs.winehq.org/show_bug.cgi?id=44883
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #19 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Reported fixed.
https://bugs.winehq.org/show_bug.cgi?id=44883
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.0-rc1.
https://bugs.winehq.org/show_bug.cgi?id=44883
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3e390b1aafff47df63376a8ca42 | |93c515d74f4ba CC| |focht@gmx.net