[Bug 54887] New: Add support for SampleGrad() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54887

Bug ID: 54887
           Summary: Add support for SampleGrad() function
           Product: vkd3d
           Version: 1.7
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

This is used by MojoShader's HLSL emitter for the TEXLDD instruction.

Amusingly, there's a test in vkd3d already, it's just in binary form only!

https://gitlab.winehq.org/wine/vkd3d/-/blob/b46df551eba19ccf45ad907bef0e6223...

[Bug 54887] Add support for SampleGrad() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54887

--- Comment #1 from Henri Verbeet  ---
(In reply to Ethan Lee from comment #0)
> Amusingly, there's a test in vkd3d already, it's just in binary form only!

As you might have noticed, we have a bunch of those. Most of those predate HLSL
support in vkd3d-shader. We'd like to get rid of those embedded binary shaders
and replace them with their HLSL source, but it hasn't been a top priority so
far.

[Bug 54887] Add support for SampleGrad() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54887

--- Comment #2 from Ethan Lee  ---
Wrote the method implementation here:

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

However, this is blocked by what seems like a missing feature when parsing out
the function parameters; it currently asserts when the ddx/ddy parameters are
anything but literals.

[Bug 54887] Add support for SampleGrad() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54887

Ethan Lee  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |24d4ab7fb3ade55015d54ac1d6a
                   |                            |fd5311bb82d76
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Ethan Lee  ---
Fixed by
https://gitlab.winehq.org/wine/vkd3d/-/commit/24d4ab7fb3ade55015d54ac1d6afd5...

[Bug 54887] Add support for SampleGrad() function

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54887

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Nikolay Sivov  ---
Closing bugs fixed in 1.9.