[Bug 28582] New: MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

Bug #: 28582
           Summary: MOVE-ing a file with cmd to current directory should
                    be a no-op
           Product: Wine
           Version: 1.3.29
          Platform: x86-64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cmd
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

When using MOVE of a file/directory, bad things happen

'move file' or 'move file1' gives a confirmation dialog and deletes the file if
the move/overwrite is confirmed.

With directories, similar behaviour but you get an access denied and the dir
isn't deleted.

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Jason Edmeades  2012-09-05 18:32:38 CDT ---
Trivial patch...
http://www.winehq.org/pipermail/wine-patches/2012-September/117539.html

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

--- Comment #2 from Frédéric Delanoy  2012-11-09 19:07:39 CST ---
Still in 1.5.17

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

--- Comment #3 from Jason Edmeades  2013-06-11 16:29:54 CDT ---
Try 2: http://www.winehq.org/pipermail/wine-patches/2013-June/124725.html

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

http://bugs.winehq.org/show_bug.cgi?id=28582

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

https://bugs.winehq.org/show_bug.cgi?id=28582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
Not taking part of the correctness of the patch but it applies quite cleanly
against current git. Maybe someone could rework with this?

patch -p1 <move.patch 
patching file programs/cmd/builtins.c
Hunk #1 succeeded at 2859 (offset 1 line).
Hunk #2 succeeded at 2888 with fuzz 2 (offset 1 line).

wine 1.7.50(git)

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

https://bugs.winehq.org/show_bug.cgi?id=28582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

https://bugs.winehq.org/show_bug.cgi?id=28582

--- Comment #5 from [e-mail] ---
You should send the patch into wine-patches list for review. Patch sitting here
doesnt help anyone really...

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

https://bugs.winehq.org/show_bug.cgi?id=28582

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail] ---
patching file programs/cmd/builtins.c
Hunk #1 succeeded at 2901 (offset 43 lines).
Hunk #2 succeeded at 2930 with fuzz 2 (offset 43 lines).

Against wine 2.0rc4. So it's not committed.

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

https://bugs.winehq.org/show_bug.cgi?id=28582

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]           |[e-mail]

--- Comment #7 from Jason Edmeades  ---
Unassigning myself as I am not working on wine recently. The patch was
submitted but rejected on try 1 as name comparison was not sufficient, and I
changed to the try 2 version. I dont recall any rejection of it, although I may
be wrong, it may have just slipped between cracks. Feel free to resubmit / get
feedback and take it over, as I cant do so in the near-medium future

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=28582

Mayyjacc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Mayyjacc  ---
Created attachment 66161
  --> https://bugs.winehq.org/attachment.cgi?id=66161
Stupid ass bitch hit my car

HitMyCar

[Bug 28582] MOVE-ing a file with cmd to current directory should be a no-op

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=28582

--- Comment #9 from Alexandre Julliard  ---
The content of attachment 66161 has been deleted for the following reason:

spam