[Bug 27657] New: WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Summary: WoW 4.2 Launcher does not exit properly
           Product: Wine
           Version: 1.3.23
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Just wanted to try WoW Starter edition, downloaded installer, installed,
launcher started, download the whole game, but whenever I press Play or wants
to close the launcher properly, the window disappear, and that's all. Virtual
dasktop is hanging there with empty background, WoW.exe is not started.
Absolutely nothing in the console (well, just a lot of mshtml fixmes, but since
the window is rendered, the console spamming stops).

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Chris McIntyre  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christopher.mcintyre@gmail.
                   |                            |com

--- Comment #1 from Chris McIntyre  2011-10-23 17:37:09 CDT ---
You can get it to work if you directly run 'Wow.exe' rather than
'Launcher.exe'. This isn't a fix, just a work-around. If you need to update
WoW, just run 'Launcher.exe' until it is done and then close it and run
'Wow.exe'. Unfortunately, along with this bug is one where you cannot close
'Launcher.exe'. When you click play or try to close the launcher, it hangs. The
only way around this I've found is to kill the launcher process. I'll try to
get some output or error logs from the launcher in a bit, it's currently
downloading something now for me, unfortunately. I'm running a self-compiled
32-bit version of wine-1.3.30 on Debian Squeeze 64-bit.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #2 from Chris McIntyre  2011-10-28 18:15:12 CDT ---
Created attachment 37178
  --> http://bugs.winehq.org/attachment.cgi?id=37178
Error log

Error file for clicking the 'X' button to exit the launcher.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] 2011-11-28 23:18:36 CST ---
I have the same issue. The workround to run wow.exe directly does the job just
fine, except.. You can not patch.  The launcher seems to hang before actually
connecting to the network to download the new content.  I think the failure to
exit the launcher is related to the network.  Perhaps it is starting a thread
to download, which hangs. But that doesn't affect the rest of the UI, so you
can still change options and exit.  The application itself, however, won't
terminate until the thread does, so you have to manually terminate it.  Anyway,
in order for the "workaround" to, well, work, you must either boot to windows
or run a VM to run the launcher and patch.

Unfortunately, I updated Ubuntu to 11.10 the same day I last patched WoW, and
before I next played, Wine updated as well. Thus I don't know which of the
three is the culprit.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #4 from Chris McIntyre  2011-11-28 23:22:31 CST ---
If you run the "BackgroundDownloader.exe" in wine, you can download the patches
when they are available prior to patch day. Also, if you simply run WoW.exe on
or after the patch is needed, it will download and install them. Still is
annoying that the launcher doesn't work properly, though.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Todd Mokros  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Joshua  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Joshua  2012-02-13 14:23:27 CST ---
Starting a bisection to see where this started to become a problem, it works
fine with the stable 1.2.3 version so somewhere in 1.3 things went wrong..

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #6 from Joshua  2012-02-13 17:46:14 CST ---
The commit of cf72f406ec7cdfebbd5135ede6e45547ca82dae0 is what I found doing
git bisections and I also found that the same commit is causing problems with
Diablo 3 in the following bug http://bugs.winehq.org/show_bug.cgi?id=28898

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #7 from Joshua  2012-02-13 19:07:53 CST ---
seems that the patch to that bug: 
http://bugs.winehq.org/attachment.cgi?id=38723&action=diff
fixes the issues clicking play or closing out the launcher.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #8 from Erich Hoover  2012-02-13 19:33:52 CST ---
Created attachment 38864
  --> http://bugs.winehq.org/attachment.cgi?id=38864
ws2_32: Revise AcceptEx behavior to send completions for cancelled sockets
[v2].

(In reply to comment #7)
> seems that the patch to that bug: 
> http://bugs.winehq.org/attachment.cgi?id=38723&action=diff
> fixes the issues clicking play or closing out the launcher.

I've created a revised patch that I think might be reasonable for inclusion
(attached).  Please give it a try.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

James Eder  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from James Eder  2012-02-14 13:14:04 CST ---
With the attached patch, I could not get the launcher to crash by clicking the
X or Play buttons.  The patch works for me.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #10 from Erich Hoover  2012-02-21 14:36:33 CST ---
(In reply to comment #9)
> With the attached patch, I could not get the launcher to crash by clicking the
> X or Play buttons.  The patch works for me.

Great!  I submitted the patch for consideration, but it's been marked as
deferred.  Once Wine 1.4 comes out then I'll resubmit.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #11 from James Eder  2012-03-15 11:56:45 CDT ---
Erich, as I'm sure you know, 1.4 is out. If you have time, I would love it if
you could send the patch for inclusion again :)  Thanks!

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #12 from Erich Hoover  2012-03-15 12:09:55 CDT ---
(In reply to comment #11)
> Erich, as I'm sure you know, 1.4 is out. If you have time, I would love it if
> you could send the patch for inclusion again :)  Thanks!

I did already, it hasn't been looked at yet (not sure why):
http://source.winehq.org/patches/data/84146

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
          Component|-unknown                    |winsock
     Ever Confirmed|0                           |1

--- Comment #13 from Jerome Leclanche  2012-03-15 12:18:37 CDT ---
Confirming

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Austin English  2012-03-15 13:47:22 CDT ---
*** Bug 27652 has been marked as a duplicate of this bug. ***

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Chris McIntyre  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|christopher.mcintyre@gmail. |
                   |com                         |

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from [e-mail]  2012-03-31 14:16:06 CDT ---
This bug still persist in 4.3.3.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Erik  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38864|0                           |1
        is obsolete|                            |

--- Comment #16 from Erich Hoover  2012-04-23 16:40:12 CDT ---
Created attachment 39898
  --> http://bugs.winehq.org/attachment.cgi?id=39898
Revise socket completion behavior to allow completions for cancelled sockets
[v3].

Please try this new patch.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #17 from James Eder  2012-04-23 17:44:48 CDT ---
(In reply to comment #16)
> Created attachment 39898 [details]
> Revise socket completion behavior to allow completions for cancelled sockets
> [v3].
>
> Please try this new patch.

Works for me.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39898|0                           |1
        is obsolete|                            |

--- Comment #18 from Erich Hoover  2012-05-01 13:30:32 CDT ---
Created attachment 39989
  --> http://bugs.winehq.org/attachment.cgi?id=39989
Revise socket completion behavior to allow completions for cancelled sockets
[v4].

The last attempt was not accepted, I've been trying a lot of different things
and I think I might have finally found a good way to do this.  Please try the
attached patch, but note that if you're not running today's git then it will
fail to merge some of the tests (and that's ok).

If someone is interested in reviewing the patch then I'd love to hear your
feedback, I'm still trying to figure out why I had to add new "todo_wine" calls
to one of the test cases.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #19 from James Eder  2012-05-01 21:12:03 CDT ---
This patch also works.  Thanks!

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #20 from Erich Hoover  2012-05-02 01:29:53 CDT ---
(In reply to comment #19)
> This patch also works.  Thanks!

Well, I discovered that the test strangeness is due to a minor problem with my
tests.  Unfortunately, this problem indicates that the approach I was using is
incorrect.  I have some other thoughts though, so I'll see what I can do.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #21 from Erich Hoover  2012-05-04 12:46:08 CDT ---
(In reply to comment #20)
> Well, I discovered that the test strangeness is due to a minor problem with my
> tests.  Unfortunately, this problem indicates that the approach I was using is
> incorrect.  I have some other thoughts though, so I'll see what I can do.

Update: I've put a lot of effort into figuring out the best way to fix this
issue and I believe that I now have a good solution.  However, I am always
interested in any feedback that people can provide - it would be really great
to have this fixed before the Diablo III release.

[1/5] http://source.winehq.org/patches/data/86013
[2/5] http://source.winehq.org/patches/data/86014
[3/5] http://source.winehq.org/patches/data/86015
[4/5] http://source.winehq.org/patches/data/86016
[5/5] http://source.winehq.org/patches/data/86017

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #22 from Joshua  2012-05-05 01:28:34 CDT ---
(In reply to comment #21)
> (In reply to comment #20)
> > Well, I discovered that the test strangeness is due to a minor problem with my
> > tests.  Unfortunately, this problem indicates that the approach I was using is
> > incorrect.  I have some other thoughts though, so I'll see what I can do.
>
> Update: I've put a lot of effort into figuring out the best way to fix this
> issue and I believe that I now have a good solution.  However, I am always
> interested in any feedback that people can provide - it would be really great
> to have this fixed before the Diablo III release.
>
> [1/5] http://source.winehq.org/patches/data/86013
> [2/5] http://source.winehq.org/patches/data/86014
> [3/5] http://source.winehq.org/patches/data/86015
> [4/5] http://source.winehq.org/patches/data/86016
> [5/5] http://source.winehq.org/patches/data/86017

After patching the source no longer compiles for me, using the latest git and
only those patches you just listed..

gcc -m32 -c -I../../../git/dlls/ntdll -I. -I../../../git/include
-I../../include  -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe
-fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body
-Wignored-qualifiers -Wstrict-prototypes -Wtype-limits
-Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer
-Wpointer-arith -Wlogical-op -I/usr/include/freetype2    -g -O2  -o sync.o
../../../git/dlls/ntdll/sync.c
../../../git/dlls/ntdll/sync.c: In function ‘invoke_apc’:
../../../git/dlls/ntdll/sync.c:871:69: error: ‘const struct <anonymous>’ has no
member named ‘chandle’
../../../git/dlls/ntdll/sync.c:872:44: error: ‘const struct <anonymous>’ has no
member named ‘ckey’
make[1]: *** [sync.o] Error 1

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #23 from Joshua  2012-05-05 02:12:28 CDT ---
(In reply to comment #21)
> (In reply to comment #20)
> > Well, I discovered that the test strangeness is due to a minor problem with my
> > tests.  Unfortunately, this problem indicates that the approach I was using is
> > incorrect.  I have some other thoughts though, so I'll see what I can do.
>
> Update: I've put a lot of effort into figuring out the best way to fix this
> issue and I believe that I now have a good solution.  However, I am always
> interested in any feedback that people can provide - it would be really great
> to have this fixed before the Diablo III release.
>
> [1/5] http://source.winehq.org/patches/data/86013
> [2/5] http://source.winehq.org/patches/data/86014
> [3/5] http://source.winehq.org/patches/data/86015
> [4/5] http://source.winehq.org/patches/data/86016
> [5/5] http://source.winehq.org/patches/data/86017

Looks like the changes you made to the async_io struct defination in
server/protocol.def need to be shown in the type definition found in
include/wine/server_protocol.h as well

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #24 from Joshua  2012-05-05 09:26:43 CDT ---
Looks like the AcceptEX stuff was commited, I was able to run World of Warcraft
Beta Launcher without a hitch this morning

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #25 from Jerome Leclanche  2012-05-05 09:34:33 CDT ---
(In reply to comment #24)
No:
http://source.winehq.org/patches/

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #26 from James Eder  2012-05-05 10:36:57 CDT ---
The World of Warcraft Launcher still hangs (for me) with current, unpatched,
git.

Also, I'm experiencing the same as comment #22 WRT building with the new patch
set.

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #27 from Erich Hoover  2012-05-05 10:52:20 CDT ---
(In reply to comment #23)
> ...
> Looks like the changes you made to the async_io struct defination in
> server/protocol.def need to be shown in the type definition found in
> include/wine/server_protocol.h as well

Yes, sorry about that - you need to run (from the main Wine directory):
./tools/make_requests

Those patches are in the form for submission (which are not supposed to
included generated files).

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

--- Comment #28 from Joshua  2012-05-08 14:21:46 CDT ---
(In reply to comment #27)
> (In reply to comment #23)
> > ...
> > Looks like the changes you made to the async_io struct defination in
> > server/protocol.def need to be shown in the type definition found in
> > include/wine/server_protocol.h as well
>
> Yes, sorry about that - you need to run (from the main Wine directory):
> ./tools/make_requests
>
> Those patches are in the form for submission (which are not supposed to
> included generated files).

Thanks for that, things seem to work good with those patches applied, t-minus 7
days to diablo3 release

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #29 from Jerome Leclanche  2012-05-14 15:17:33 CDT ---
Dupe

*** This bug has been marked as a duplicate of bug 28898 ***

[Bug 27657] WoW 4.2 Launcher does not exit properly

http://bugs.winehq.org/show_bug.cgi?id=27657

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #30 from Frédéric Delanoy  2012-05-18 09:51:23 CDT ---
Closing DUPLICATE bugs.