[Bug 48056] New: Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

Bug ID: 48056
           Summary: Patch : "winex11: Match keyboard in Unicode" cause
                    invalid input key
           Product: Wine-staging
           Version: 4.19
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Using wine-4.19 + wine-staging 4.19 built from scratch.

Issue :

When hit 'i' key on French keyboard another character ('è' or 'é') is displayed
which is not expected.

Application tested : Starcraft II, Battle.net.

Reverting patch c6521c978cb60a1e7fdc70f794008a7dd0f37903 solve the issue.

I'll try to investigate and provide a patch if I found a solution.

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

--- Comment #1 from Alistair Leslie-Hughes  ---
(In reply to charles.gorand.dev from comment #0)
> Reverting patch c6521c978cb60a1e7fdc70f794008a7dd0f37903 solve the issue.

I cannot find this ID.  What patch did you revert?

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

--- Comment #2 from [e-mail] ---
Sorry :

cfbf5f7b8645a5f3a10da8fb572104afcb4bf70a (wine-staging tag)

Patch file :
patches/winex11-key_translation/0001-winex11-Match-keyboard-in-Unicode.patch

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Debian

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

Christopher König  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Christopher König  ---
I can confirm this issue.
For me its on a German keyboard, for example with v and ö.
Sometimes applications read v as ö, or ö as v. No consistant behavior to me.

Applications tested: Final Fantasy XIV and League of Legends.

(PS: I have no idea of the code base, I was just watching the bugs until
someone opened up one with a similar problem I had.)

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

--- Comment #4 from [e-mail] ---
Ok I'll figure what happening.

When I press 'i' I got 'é'

Ascii/Binary values :

i 01101001 69
é 11101001 E9

When I press real key "é" (or 2) : I got 'é' displayed (Ok)
When I press real key "i" : I got 'é' displayed too (Ko)

After puting some traces, I confirm issue is in static WORD
EVENT_event_to_vkey( XIC xic, XKeyEvent *e);

Here traces :

Press 'é' :
005e:trace:key:X11DRV_KeyEvent KeyPress : keysym=e9 (eacute), # of chars=1 /
"\xe9"
005e:trace:key:EVENT_event_to_vkey e->keycode = 11
005e:trace:key:X11DRV_KeyEvent keycode 11 converted to vkey 0x49 scan 17

Press 'i' :
005e:trace:key:X11DRV_KeyEvent KeyPress : keysym=69 (i), # of chars=1 / "i"
005e:trace:key:EVENT_event_to_vkey e->keycode = 31
005e:trace:key:X11DRV_KeyEvent keycode 31 converted to vkey 0x49 scan 17

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

--- Comment #5 from [e-mail] ---
Erratum, issue is in keyc2vkey initialization in X11DRV_InitKeyboard().

0014:trace:keyboard:X11DRV_InitKeyboard keycode 31 => vkey 0049
0014:warn:keyboard:X11DRV_InitKeyboard vkey 0049 is being used by more than one
keycode

Continuing investigation.

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |janpieter.sollie@kabelmail.
                   |                            |de

--- Comment #6 from Zebediah Figura  ---
*** Bug 49185 has been marked as a duplicate of this bug. ***

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

--- Comment #7 from jpsollie  ---
I do not know yet where the error is coming from, but this may give the
developers a hint:

On my report (https://bugs.winehq.org/show_bug.cgi?id=49185), i had the same
problem.

Because I could not find a solution, I booted into win2k19 and ran the
respondus browser from there.

When I used language "ENG/US" and keyboard layout "Belgian Azerty", the issue
was exactly the same compared to wine staging.
When I used language English/Belgium and keyboard "Belgian Azerty", the issue
was gone!
So I don't know whether this will be of any help, but I hope it does

[Bug 48056] Patch : "winex11: Match keyboard in Unicode" cause invalid input key

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Zebediah Figura  ---
*** Bug 49363 has been marked as a duplicate of this bug. ***

[Bug 48056] "winex11: Match keyboard in Unicode" causes some keys to be incorrectly mapped with non-US keyboards

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patch : "winex11: Match     |"winex11: Match keyboard in
                   |keyboard in Unicode" cause  |Unicode" causes some keys
                   |invalid input key           |to be incorrectly mapped
                   |                            |with non-US keyboards

[Bug 48056] "winex11: Match keyboard in Unicode" causes some keys to be incorrectly mapped with non-US keyboards

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

soredake  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|broaden_acid002@simplelogin |
                   |.com                        |

[Bug 48056] "winex11: Match keyboard in Unicode" causes some keys to be incorrectly mapped with non-US keyboards

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48056

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from [e-mail] ---
fixed since a long time.
Running Wine 9.X ++ and no more keyboard issues.