[Bug 40331] New: The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

Bug ID: 40331
           Summary: The Legend of Heroes Trails in the Sky SC crashes on
                    start with runtime error R6025
           Product: Wine
           Version: 1.9.6
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: f085be3028e86ebc6666d20a4802831bf7b3f3bc
      Distribution: Other

The Legend of Heroes Trails in the Sky SC crashes on start with runtime error
R6025.

--- system info ---
SolydK 8
Kernel: 3.16.0-4-amd64 x86_64 (64 bit)
Card: NVIDIA G80 [GeForce 8800 GTX]
GLX Renderer: GeForce 8800 GTX/PCIe/SSE2 GLX Version: 3.3.0 NVIDIA 340.76
--- system info ---

Bisecting returns:

--- snip ---
f085be3028e86ebc6666d20a4802831bf7b3f3bc is the first bad commit
commit f085be3028e86ebc6666d20a4802831bf7b3f3bc
Author: Piotr Caban 
Date:   Tue Mar 15 13:41:20 2016 +0100

msvcrt: Destroy exception object when frame storing it is unwound.

Thrown object was incorrectly freed in following situation:
    try {
         throw obj;
    } catch(object &obj) {
         try {
             throw 1;
         } catch(...) {}

//use object here
    }

Signed-off-by: Piotr Caban 
    Signed-off-by: Alexandre Julliard

:040000 040000 01fcdd5769307155786c609376bafcfb08aec222
86372853b0bd9c65d2cf021bee744b795897069a M      dlls
--- snip ---

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

Aexander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

--- Comment #1 from Aexander  ---
Created attachment 53993
  --> https://bugs.winehq.org/attachment.cgi?id=53993
console log

It's the game that crashes not wine if I wasn't clear.

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

--- Comment #2 from Piotr Caban  ---
Please attach a WINEDEBUG=tid,seh log.

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

--- Comment #3 from Aexander  ---
Created attachment 54008
  --> https://bugs.winehq.org/attachment.cgi?id=54008
1.9.6-seh log

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

--- Comment #4 from Piotr Caban  ---
Thank you for attaching the log. I can see where the problem is now. Hopefully
a fix for it will be ready tomorrow.

Note - there are 2 issues:
 - nested exception object needs to be registered before frames are unwinded
 - we should handle rethrown objects earlier

A code that demonstrates this issue is following:
try {
    try {
        throw obj;
    } catch(...) {
        throw;
    }
} catch(...) {
    printf("use obj here\n");
}

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

--- Comment #5 from Piotr Caban  ---
Created attachment 54014
  --> https://bugs.winehq.org/attachment.cgi?id=54014
register exception object before unwinding frames

This patch should fix the issue. Could you please give it a try?

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

--- Comment #6 from Aexander  ---
(In reply to Piotr Caban from comment #5)
> This patch should fix the issue. Could you please give it a try?

Yes it does. The game launches just fine now.

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |3a0b3c5bc89178d332dd1117348
                   |                            |d8785975afc18
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #7 from Piotr Caban  ---
The patch got into wine. Marking as fixed.

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

Alexander Jenisch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Alexander Jenisch  ---
*** Bug 40381 has been marked as a duplicate of this bug. ***

[Bug 40331] The Legend of Heroes Trails in the Sky SC crashes on start with runtime error R6025

https://bugs.winehq.org/show_bug.cgi?id=40331

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.7.