[Bug 16845] New: Radio buttons not being checked on focus

List overview All Threads

newer

older

[Bug 12527] New: radio button...

[Bug 11095] New: some keyboard...

wine-bugs＠winehq.org

8 Jan 2009 8 Jan '09

7:49 a.m.

http://bugs.winehq.org/show_bug.cgi?id=16845

Summary: Radio buttons not being checked on focus Product: Wine Version: CVS/GIT Platform: Other URL: http://www.chiark.greenend.org.uk/~sgtatham/putty/downlo ad.html OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: user32 AssignedTo: wine-bugs@winehq.org ReportedBy: munozferna@gmail.com

Current wine behavior is to just assign the focus to the radio button, however, Windows checks the radio button when it gets focus through the keyboard arrows.

Steps to reproduce:

1. Open putty 2. Click the Raw radio button 3. Press right arrow twice

Actual results * Port textbox stays at 23 * Rlogin radio button is not checked

Expected results (windows behavior) * Port textbox changes to 513 * Rlogin radio button is checked

I'm attaching a patch that I believe fixes this, comments about it would be appreciated.

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

8 Jan 8 Jan

7:50 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #1 from Fernando Muñoz munozferna@gmail.com 2009-01-08 01:50:54 --- Created an attachment (id=18574) --> (http://bugs.winehq.org/attachment.cgi?id=18574) Patch that fixes this problem

wine-bugs＠winehq.org

8:16 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Dmitry Timoshkov dmitry@codeweavers.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |1.1.12

wine-bugs＠winehq.org

8:27 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch

--- Comment #2 from Austin English austinenglish@gmail.com 2009-01-08 02:27:01 --- A testcase would help.

wine-bugs＠winehq.org

4:31 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #3 from Juan Lang juan_lang@yahoo.com 2009-01-08 10:31:16 --- You're also likely to get more comments on wine-devel than here. As Austin says, a test case would help a lot.

wine-bugs＠winehq.org

9 Jan 9 Jan

2:19 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #4 from Fernando Muñoz munozferna@gmail.com 2009-01-09 08:19:04 --- I was trying to create my own case test, but failed. Then I noticed that I could add a new test to the current user32/tests/dialog.c, since some tests there already check focus stuff on controls. I will try this approach, but I am no Win32 Api programmer, so it's gonna take a while. Also, on this patch I'm only checking for BS_AUTORADIOBUTTON, not sure if this behavior applies to BS_RADIOBUTTON aswell.

wine-bugs＠winehq.org

11:42 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Reece Dunn msclrhd@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |msclrhd@gmail.com

--- Comment #5 from Reece Dunn msclrhd@gmail.com 2009-01-09 17:42:19 --- With BS_RADIOBUTTON, the program is responsible for setting the radio button state; for BS_AUTORADIOBUTTON, Windows handles this automatically. That covers keyboard handling, radio button cycling and so forth.

wine-bugs＠winehq.org

10 Jan 10 Jan

7:06 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #6 from Fernando Muñoz munozferna@gmail.com 2009-01-10 13:06:09 --- This patch is wrong, it doesn't behave exactly as windows, it should select the radio buttons on keydown, because when you left the arrow key pressed and it keeps moving over the other controls, in the case of putty, windows selects all of them as they get focus, without needing the KEYUP event. So I tried moving my code to the WM_KEYDOWN case, however, that event doesn't seem to fire with the arrow keys.

wine-bugs＠winehq.org

8 Jun 8 Jun

10:14 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Austin English austinenglish@gmail.com changed:

--- Comment #7 from Austin English austinenglish@gmail.com 2009-06-08 17:14:28 --- Still present in git.

wine-bugs＠winehq.org

11 Dec 11 Dec

3:41 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Bruno Jesus 00cpxxx@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com

--- Comment #8 from Bruno Jesus 00cpxxx@gmail.com 2011-12-10 21:41:44 CST --- Still present in 1.3.34.

wine-bugs＠winehq.org

24 Apr 24 Apr

8:13 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

gat gatlinsullivan@yahoo.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |gatlinsullivan@yahoo.com

--- Comment #9 from gat gatlinsullivan@yahoo.com 2012-04-24 03:13:59 CDT --- Still present in Notepad++ 6.1.1 using Fedora 16 x86_64 with wine 1.5.1.

wine-bugs＠winehq.org

10 Mar 10 Mar

4:41 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #10 from gat gatlinsullivan@yahoo.com 2013-03-10 11:41:06 CDT --- Still present in Notepad++ 6.3 using Fedora 18 x86_64 with wine 1.5.25. Will somebody mark this as a duplicate of bug 12527?

wine-bugs＠winehq.org

11 Mar 11 Mar

7:36 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Simon swdevelop1981@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |swdevelop1981@gmail.com

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

22 May 22 May

12:39 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

Ken Sharp imwellcushtymelike@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial

--- Comment #11 from Ken Sharp imwellcushtymelike@gmail.com --- Does this still occur in Wine 1.7.19 or later?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

12:41 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

http://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #12 from Ken Sharp imwellcushtymelike@gmail.com --- *** Bug 12527 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

19 Mar 19 Mar

3:17 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #13 from gat gatlinsullivan@yahoo.com --- This is still present in Wine 1.9.5 with Fedora 23 using Notepad++ 6.9.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

27 Dec 27 Dec

10:58 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

winetest@luukku.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com

--- Comment #14 from winetest@luukku.com --- Still valid wine 2.0.rc3. And staging 2.0.rc3.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

13 Jan 13 Jan

9:58 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

--- Comment #15 from winetest@luukku.com --- Staging has a patch for this now. I already tested and it seems to fix this bug.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Jan 16 Jan

1:35 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Sebastian Lackner sebastian@fds-team.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

22 Jan 22 Jan

4:41 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Sylvain Petreolle spetreolle@yahoo.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |spetreolle@yahoo.fr

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4:45 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Sylvain Petreolle spetreolle@yahoo.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |thestig@google.com

--- Comment #16 from Sylvain Petreolle spetreolle@yahoo.fr --- *** Bug 11095 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

1 Jun 1 Jun

4:33 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

André H. nerv@dawncrow.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

28 Nov 28 Nov

5:44 a.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Dmitry Timoshkov dmitry@baikal.ru changed:

--- Comment #17 from Dmitry Timoshkov dmitry@baikal.ru --- Committed as b1b8fb77be5dd9a8754b04b2ef9f703bbe393d59.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7 Dec 7 Dec

6:14 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Alexandre Julliard julliard@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #18 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 4.0-rc1.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

22 Jan 22 Jan

11 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3 Mar 3 Mar

7:33 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Michael Stefaniuc mstefani@winehq.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |---

--- Comment #19 from Michael Stefaniuc mstefani@winehq.org --- Removing the 3.0.x milestone from bug fixes included in 3.0.5.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

WineHQ Bugzilla

30 Oct 30 Oct

7:24 p.m.

New subject: [Bug 16845] Radio buttons not being checked on focus

https://bugs.winehq.org/show_bug.cgi?id=16845

Anastasius Focht focht@gmx.net changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1151

Age (days ago)

5829

Last active (days ago)

wine-bugs@winehq.org

26 comments

2 participants

tags (0)

participants (2)

wine-bugs＠winehq.org
WineHQ Bugzilla