[Bug 55225] New: kernel32:thread - test_stack() gets an unexpected values for -2 & -3 indexes on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55225

Bug ID: 55225
           Summary: kernel32:thread - test_stack() gets an unexpected
                    values for -2 & -3 indexes on Windows
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]

kernel32:thread - test_stack() gets an unexpected stack[-2] value on Windows:

thread.c:1180: Test failed: wrong data 0358FFF8 = 00000000
thread.c:1181: Test failed: wrong data 0358FFF4 = 00000000

See https://test.winehq.org/data/patterns.html#kernel32:thread

Where the first value depends on the stack pointer and changes with every run,
thus causing false positives.

[Bug 55225] kernel32:thread - test_stack() gets an unexpected values for -2 & -3 indexes on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55225

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 55225] kernel32:thread - The 32-bit test_stack() gets an unexpected values for -2 & -3 indexes on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55225

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|kernel32:thread -           |kernel32:thread - The
                   |test_stack() gets an        |32-bit test_stack() gets an
                   |unexpected values for -2 &  |unexpected values for -2 &
                   |-3 indexes on Windows       |-3 indexes on Windows

--- Comment #1 from François Gouget  ---
This is specific to the 32-bit tests and the stack value may be non-zero:

thread.c:1192: Test failed: wrong data 01A6FFF0 = 00001234

[Bug 55225] kernel32:thread - The 32-bit test_stack() gets an unexpected values for -2 & -3 indexes on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55225

--- Comment #2 from François Gouget  ---
These failures have been systematic since 2023-07-10 which is when the GitLab
CI switched to Debian 12 to build the official WineTest binaries used by the
TestBot to run the tests on Windows.

Note that the TestBot still uses Debian 11 to build the test binaries so these
failures will not happen when submitting patches to the TestBot.

[Bug 55225] kernel32:thread - The 32-bit test_stack() gets an unexpected values for -2 & -3 indexes on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55225

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |d3dfed51b37838855c6bcd352a6
                   |                            |31cc87a4dac6b

--- Comment #3 from François Gouget  ---
This is fixed:

commit d3dfed51b37838855c6bcd352a631cc87a4dac6b
Author: Alexandre Julliard 
Date:   Fri Sep 1 16:01:57 2023 +0200

kernel32/tests: Remove tests for the exact value of the stack pointer.

Stack pointer is randomized on Windows.

[Bug 55225] kernel32:thread - The 32-bit test_stack() gets an unexpected values for -2 & -3 indexes on Windows

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55225

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 8.16.