[Bug 27133] New: WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

Summary: WiX 3.5 generates broken MSI files when 2 files of
                    identical size are added to the same installer
           Product: Wine
           Version: 1.3.19
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=34643)
 --> (http://bugs.winehq.org/attachment.cgi?id=34643)
test case

The attached test case will generate an installer that installs two files to
'ProgramFilesFolder\duplicate file test'.

when run on Windows, the installer works fine. When run under Wine, the
installer installs the contents of file1.txt into file2.txt.

This only happens with Wix 3.5. This version added a feature called "smart
cabbing" that detects duplicate files in an installer and only embeds one copy.
This may be going haywire when run under Wine.

To run the test case, you will need Mono
http://ftp.novell.com/pub/mono/archive/2.10.2/windows-installer/5/mono-2.10.2-gtksharp-2.12.10-win32-5.exe
and WiX 3.5 http://wix.codeplex.com/releases/view/60102#DownloadId=204417.
You
will need to put WiX's tools in Wine's PATH, or modify build.sh to give the
full path to the WiX tools when it invokes light and candle.

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

--- Comment #1 from Sam Morris  2011-05-11 12:00:12 CDT ---
Created an attachment (id=34644)
 --> (http://bugs.winehq.org/attachment.cgi?id=34644)
result of running test under Wine

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

--- Comment #2 from Sam Morris  2011-05-11 12:01:09 CDT ---
Created an attachment (id=34645)
 --> (http://bugs.winehq.org/attachment.cgi?id=34645)
result of running test in Windows

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

--- Comment #3 from Sam Morris  2011-05-11 12:09:38 CDT ---
I've opened both MSI files in Orca
https://encrypted.google.com/url?sa=t&source=web&cd=1&ved=0CBgQFjAA&url=http%3A%2F%2Fmsdn.microsoft.com%2Fen-us%2Flibrary%2Faa370557(v%3Dvs.85).aspx&ei=osHKTcLKJYe0hAewmOSoAg&usg=AFQjCNGXkoXpbTe5rXWb-zEuM71z1Ia8lg
and eyeballed them for differences.

The only difference I can see is in the MsiFileHash table; in the installer
generated by Wine, The HashPart1/2/3/4 columns all have the value 0 for both
files.

I also extracted the embedded sample.cab file and found that the contents of
file1.txt was used for file2.txt there as well.

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

Nathan Coulson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

--- Comment #4 from Nathan Coulson  2011-07-20 15:19:48 CDT ---
Created an attachment (id=35619)
 --> (http://bugs.winehq.org/attachment.cgi?id=35619)
+msi log running wine on wine 1.3.24

Same problem with wine 1.3.24 (running wix v3.5)

output of
WINEDEBUG=+msi wine light -nologo -sval test.wixobj

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

Sam Morris  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #5 from Sam Morris  2011-09-13 06:07:58 CDT ---
This is not a bug in Wine. If I use the Microsoft .NET runtime (as installed by
'winetricks dotnet20' then the generated MSI file has the correct hashes and
installs both files correctly.

[Bug 27133] WiX 3.5 generates broken MSI files when 2 files of identical size are added to the same installer

http://bugs.winehq.org/show_bug.cgi?id=27133

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Austin English  2011-09-22 13:31:30 CDT ---
Closing.

[Bug 27133] WiX 3.5 with Mono 2.10 generates broken MSI packages when 2 files of identical size are added to the same installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=27133

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|WiX 3.5 generates broken    |WiX 3.5 with Mono 2.10
                   |MSI files when 2 files of   |generates broken MSI
                   |identical size are added to |packages when 2 files of
                   |the same installer          |identical size are added to
                   |                            |the same installer
                 CC|                            |[e-mail]
                URL|                            |https://web.archive.org/sav
                   |                            |e/https://raw.githubusercon
                   |                            |tent.com/CasaDeRobison/wixt
                   |                            |oolset-codeplex/master/arch
                   |                            |ived-stable-versions/WiX%20
                   |                            |Toolset%20v3.5%20Stable/Wix
                   |                            |35.msi

[Bug 27133] WiX 3.5 with Mono 2.10 generates broken MSI packages when 2 files of identical size are added to the same installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=27133

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |---
           Keywords|                            |Installer, source, testcase
                 CC|                            |[e-mail]
          Component|-unknown                    |mscoree
             Status|CLOSED                      |REOPENED
     Ever confirmed|0                           |1

--- Comment #7 from Damjan Jovanovic  ---
(In reply to Austin English from comment #6)
> Closing.

We don't CLOSE/INVALID bugs just because they're in Mono/Wine-Mono, we set them
to Component="mscoree" don't we?

[Bug 27133] WiX 3.5 with Mono 2.10 generates broken MSI packages when 2 files of identical size are added to the same installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=27133

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #8 from Damjan Jovanovic  ---
Retesting this with Wine > 6.10, wine-mono 6.20, and WiX 3.5, I cannot
reproduce this problem: the built and installed file1.txt and file2.txt are
different and match the original files. Thus I am re-resolving this bug as
FIXED. Thank you for your bug report.

[Bug 27133] WiX 3.5 with Mono 2.10 generates broken MSI packages when 2 files of identical size are added to the same installer

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=27133

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 6.12.