[Bug 29981] New: Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Bug #: 29981
           Summary: Galactic Civilizations 2 is unplayable due to possible
                    severe memory leak
           Product: Wine
           Version: 1.4-rc4
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Since several wine versions I can not play GalCiv2:Twilight of the Arnor game.
After a several dozens of turns the game interface freezes and all text in it
disappears. If I'm enabling autosave then I also get the "Out of memory"
message (possibly caused by autosaving attempt).

I've made some testing and found that initially the game uses ~600 MiB of RAM
but after each turn the memory consumption increases significantly (more than
30 MiB each turn even when playing on small maps) and when it reaches ~1.7 GiB
the game stops responding.

If it matters I use 64-bit openSuSe Linux 12.1, Core 2 Duo E8500, 6GiB RAM and
nVidia GTX 460 1GB video card with latest stable nVidia proprietary driver.

These are the wine packages I have currently installed:

wine-1.3.38_1.4rc4-1.2.x86_64
wine-mp3-1.1.39-12.4.i586
wine-32bit-1.3.38_1.4rc4-1.2.x86_64
wine-gecko-1.4-24.1.noarch

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
           Severity|normal                      |minor

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #1 from Austin English  2012-02-23 12:46:07 CST ---
If this is a regression, please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #2 from olelukoie  2012-02-25 00:52:37 CST ---
bisecting gave me the following:

f04b6b2fc87ac902d1147f1e5e94d9ef575619a1 is the first bad commit
commit f04b6b2fc87ac902d1147f1e5e94d9ef575619a1
Author: Aric Stewart 
Date:   Tue Jan 3 06:51:27 2012 -0600

usp10: Replace GSUB_get_feature with GSUB_GetFontFeatureTags.

:040000 040000 00956be2381454db479297395982cb051d866442
93c731f8919677e9d78903b027c0d410109a25e4 M      dlls

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #3 from Dmitry Timoshkov  2012-02-25 01:17:10 CST ---
Does reverting that patch help?

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #4 from olelukoie  2012-02-25 01:39:44 CST ---
I don't know would reverting patch help but I've made replacement of usp10.dll
with native one (in winecfg, the native dll comes with the game) and the
problem disappeared and memory consumption returned to normal level. So I think
the problem is really in wine implementation of this dll.

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |usp10
    Regression SHA1|                            |f04b6b2fc87ac902d1147f1e5e9
                   |                            |4d9ef575619a1

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #5 from olelukoie  2012-02-25 02:03:39 CST ---
BTW reverting the patch is not possible:

$ git show f04b6b2fc87ac902d1147f1e5e94d9ef575619a1 | patch -p1 -R
patching file dlls/usp10/shape.c
Hunk #1 FAILED at 349.
Hunk #2 FAILED at 768.
Hunk #3 FAILED at 1161.
3 out of 3 hunks FAILED -- saving rejects to file dlls/usp10/shape.c.rej
patching file dlls/usp10/usp10.c
Hunk #1 succeeded at 984 (offset 51 lines).
patching file dlls/usp10/usp10_internal.h
Hunk #1 succeeded at 130 with fuzz 2 (offset 3 lines).
Hunk #2 succeeded at 161 (offset 5 lines).

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #6 from Aric Stewart  2012-02-25 22:12:09 CST ---
Could i get a +uniscribe log to help?

thanks!
-aric

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #7 from olelukoie  2012-02-26 03:26:01 CST ---
+uniscribe log has 380 MiB in size just for one game turn (start game->load
saved game->do one turn->quick save->quit game). After compressing win bzip2 it
has ~5.5 MiB so I still cannot attach it here. Where should I upload it for
you?

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #8 from Aric Stewart  2012-02-26 09:27:56 CST ---
(In reply to comment #7)
> +uniscribe log has 380 MiB in size just for one game turn (start game->load
> saved game->do one turn->quick save->quit game). After compressing win bzip2 it
> has ~5.5 MiB so I still cannot attach it here. Where should I upload it for
> you?

e-mail the gziped filed to me.  [e-mail]

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #9 from Aric Stewart  2012-02-27 07:26:12 CST ---
Created attachment 39106
  --> http://bugs.winehq.org/attachment.cgi?id=39106
possible fix

Please try applying this patch.

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

--- Comment #10 from olelukoie  2012-02-27 12:26:45 CST ---
Well, the patch seems to fix the problem. At least there is no such enormous
memory eating on every game turn. The memory usage steadily grows a little but
I think it's normal as I've played ~40 turns and memory usage remained less
than 800 MiB (beginning with ~700 MiB) while unpatched 1.4-rc5 ate additional
400 MiB for just ~20 turns.

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9af6b11808e92857985015ded9c
                   |                            |65b1a2b83f991
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Alexandre Julliard  2012-02-29 04:58:15 CST ---
Fixed then.

[Bug 29981] Galactic Civilizations 2 is unplayable due to possible severe memory leak

http://bugs.winehq.org/show_bug.cgi?id=29981

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2012-03-02 13:02:46 CST ---
Closing bugs fixed in 1.4-rc6.