https://bugs.winehq.org/show_bug.cgi?id=41595
Bug ID: 41595 Summary: Photoshop Palettes Remain Above All X11 Windows Product: Wine Version: 1.8.5 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs@winehq.org Reporter: amartin@avidandrew.com Distribution: ---
Created attachment 55934 --> https://bugs.winehq.org/attachment.cgi?id=55934 demonstrates problem behavior when using Chromium
Photoshop palettes (layers, navigator, history, etc) remain above all X11 windows when you switch from Photoshop to another program (e.g. Chrome). Someone in bug report 29871 reported that if you run `xwininfo` and hover over the palette windows, you can see that Override Redirect State: yes, which explains why they stay on top of everything.
The desired behavior is that these windows behave like the rest of Photoshop and do not remain above other X11 applications.
This has been reported in multiple (probably all) versions of Photoshop - my particular test case is with CS5.
https://bugs.winehq.org/show_bug.cgi?id=41595
Fincer fincer89@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fincer89@hotmail.com
https://bugs.winehq.org/show_bug.cgi?id=41595
Jay Hilliard jaydhilliard@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jaydhilliard@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=41595
Chituc Georgian dianaxxyyzz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dianaxxyyzz@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #1 from Chituc Georgian dianaxxyyzz@gmail.com --- When photoshop Tool window is opened from Windows->Tools , it create 3 windows . All have a style WS_POPUP . The first and second window are containers , the last show the tools.
But when the photoshop main window is minimized , only the last from the 3 windows receive the SW_HIDE message .
For example if i open in photoshop Windows ->Tools ,it create the next windows with next hwnds :
static BOOL send_message() hwnd: 0x808fa static BOOL send_message() hwnd: 0x8049c static BOOL send_message() hwnd: 0x808f6
But when I click the photoshop minimize buton , in photoshop main window ,
static BOOL send_message() is called with info->msg == WM_SHOWWINDOW just for the last hwnd , 0x808f6 ;
I think also the first hwnd (0x808fa) must receive this message too.
Wine must minimze all windows of photoshop when minimize button is pressed , no matter this have 'Override Redirect State: yes' .
https://bugs.winehq.org/show_bug.cgi?id=41595
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #2 from winetest@luukku.com --- Based on comment 1
something needs to be fixed here
http://source.winehq.org/git/wine.git/blob/55be713d76bef86ba7577c810a9dbdfb0...
Any ideas?
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #3 from winetest@luukku.com --- I just installed photshop CS2 and I can't reproduce the issue.
But I don't have the same versiona as you.
wine 2.0rc6.
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #4 from Chituc Georgian dianaxxyyzz@gmail.com --- That's great ,how is the tooltips ?Did they fixed it ?or they still steal focus?
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #5 from winetest@luukku.com --- (In reply to Chituc Georgian from comment #4)
That's great ,how is the tooltips ?Did they fixed it ?or they still steal focus?
Actually I had to retest because I assumed the tools would show on wrong z-order at desktop like the splash screen.
I am not sure at all that this verson can be tested against your bug report.
Now when I do Window-->Tools.
It just closes one of the tools thats already opened by default. Clicking again tools activates it.
I don't get 3 tools from that menu. So the behaviour must have changed between photoshop versions.
If I just minimize the main program and open it again from taskbar I don't see anything weird.
I don't know how to test the tooltips part. I just moved mouse over some tools and received a tooltip and I don't see nothing wrong with it.
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #6 from Chituc Georgian dianaxxyyzz@gmail.com --- Thanks for infos .It would be great it they were fixed .
Here is exactly how to test windows and tools .
Detach tools windows from photoshop , so they to be 2 separate windows , drag the tool window outside the photoshop main window . Now if you minimize photoshop , the tools window must to dissapear too.
To test tooltips you have to open the File-> Save For Web , dialog and move mouse to see some tooltips appearing , if the dialog do not become grey and all is functional inside it , tooltips works . If the dialog become grey when a tooltips appear , they something is wrong.
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #7 from Chituc Georgian dianaxxyyzz@gmail.com --- I tested latest crossover 16 witch have wine 1.9.21 and all bugs are still there.
I was 90% sure bugs are still there , so for now ( maybe 20 + years more) , I will stay with my patched wine ,that have the patches I made and works graet!
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #8 from winetest@luukku.com --- (In reply to Chituc Georgian from comment #7)
Well if you would show how you fixed the issue it would be easier to get it merged into wine and no more patched wine.
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #9 from Fincer fincer89@hotmail.com --- Meanwhile, I appreciate the work done by Chituc Georgian and will patch my Wine as well using the patches until they'll be merged into the official Wine branch.
Only thing I still notice is that "Tools" window may hover above everything else if it's undocked.
Chituc, may you discuss about the patches with a developer who responsible for implementing new features into the DLL components you've patched?
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #10 from Chituc Georgian dianaxxyyzz@gmail.com --- Hello ,
The patches I did for wine so photoshop to work better was posted at : https://bugs.winehq.org/show_bug.cgi?id=29871 . Some ppls said they are just ugly hacks that do not deserver to go into main wine . I said from beginning that I'm not a wine developer ,and I know they are not perfect patches :) . But for me just works and I tried to be sure do not ruin another apps . If they work for me I just said other ppls want the patches , so I said just to be a good guy and tried to help . My big problem with photoshop was the tooltips that do not dissapear from screen , and the ones who steal focus and make the Save for Web dialog grey. That was resolved .And everybody have the patches at that link . If the top wine developers will inspire and make a spuper patch that will go into main wine , will be fine , if not .. then is not up to me . Sorry .
Regarding the "Photoshop Palettes Remain Above All X11 Windows" I found out that photoshop windows that have "Override Redirect State: yes" are not managed by the window manager and they stay on top of all windows (Chrome ,Firefox etc ) , even if you minimize photoshop main window .
So being inspired from this phyton script I found on web :
-------------------------------------------------------------- #! /usr/bin/env python
# Kill tooltips and similar override-redirect windows. # Copyright 2011 by Akkana Peck -- share and enjoy under the GPLv2 or later.
# Empirically, tooltips have these properties: # - mapped # - override_redirect # - transient_for # wm_name may be the content of the tooltip or may be blank. # Sadly, menus have all those properties too, so this will also hide # any menus that happen to be open at the time. # But most well-behaved programs will remap their menus just fine # the next time you ask for them.
# Can't import just Xlib and use Xlib.display, sigh from Xlib import display
# Next line prints: Xlib.protocol.request.QueryExtension # There doesn't seem to be a way to suppress that, so just ignore it. dpy = display.Display() screen = dpy.screen() root = screen.root tree = root.query_tree()
for w in tree.children : att = w.get_attributes() if att.map_state and att.override_redirect and w.get_wm_transient_for(): print "%d %d %35s %s" % (att.map_state, att.override_redirect, w.get_wm_transient_for(), w.get_wm_name()) w.unmap() dpy.flush() print "now map_state is", w.get_attributes().map_state w.map() dpy.flush() print "now map_state is", w.get_attributes().map_state
#dpy.flush() ------------------------------------------------------------------------ I modified wine so it to unmap all windows that have "Override Redirect State: yes" ,when their parents lose focus . And to remap when they gain again focus .
It works well , I can not find the C source code ,so that I posted the phyton script I inspired from . It has to be somewere but even If I post it here I'm sure that will also not merge into main wine . So this is the ideea .
Have a great day all!
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #11 from Fincer fincer89@hotmail.com --- That sounds great! Can you post the actual modifications you made in Wine source code, it would help a lot!
You truly make great work here, among other Wine contributors/codeweavers' ppl.
You find my email as a link in my nick name, unless you'd like to publish them publically. :)
And for the rest of the people, sorry for this off-topic.
https://bugs.winehq.org/show_bug.cgi?id=41595
--- Comment #12 from Ken Sharp imwellcushtymelike@gmail.com --- Please try again in Wine 5.6 or later.
-
wine-bugs＠winehq.org -
WineHQ Bugzilla