New subject: [Bug 19562] Guitar Hero World Tour crashes after dinput GetProperty

4 Aug 2009

http://bugs.winehq.org/show_bug.cgi?id=19562
Summary: Guitar Hero World Tour crashes after dinput
                    GetProperty
           Product: Wine
           Version: 1.1.26
          Platform: PC
               URL: http://worldtour.guitarhero.com/uk/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dinput
        AssignedTo: wine-bugs@winehq.org
        ReportedBy: andras@csevego.net
After I set a fake paging file in regedit, game will crash after this line:
warn:dinput:IDirectInputDevice2AImpl_GetProperty Unknown property <guid-0x0018>
The problem is, we return DI_OK instead of an error code.
It can be fixed with this:

diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c
index 941206c..cb66b03 100644
--- a/dlls/dinput/device.c
+++ b/dlls/dinput/device.c
@@ -888,6 +896,7 @@ HRESULT WINAPI IDirectInputDevice2AImpl_GetProperty(
         }
         default:
             WARN("Unknown property %s\n", debugstr_guid(rguid));
+            return DIERR_INVALIDPARAM;
             break;
     }
-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.


    

[Bug 19562] New: Guitar Hero World Tour crashes after dinput GetProperty