[Bug 49391] New: Star Trek Armada crashes on start on Wine 5.6 but not Wine 5.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49391

Bug ID: 49391
           Summary: Star Trek Armada crashes on start on Wine 5.6 but not
                    Wine 5.5
           Product: Wine
           Version: 5.6
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 67459
  --> https://bugs.winehq.org/attachment.cgi?id=67459
WINEDEBUG=+ddraw

The problem is reproducible with both the free demo and the full version.
Console output with WINEDEBUG=+ddraw is attached. `git bisect` said:

d0ff5e66a7611511426a8ff902a95ab22c545f78 is the first bad commit
commit d0ff5e66a7611511426a8ff902a95ab22c545f78
Author: Paul Gofman 
Date:   Fri Mar 27 23:31:41 2020 +0300

ddraw: Reserve extra space for video memory surfaces in compatibility mode.

Some old apps write surface data past the end of locked space. That
    used to work on early ddraw hardware as locked surface provided
    direct access to video memory mapped to CPU address space and such
    access could often go without issues. Currently ddraw on Windows
    allocates bigger buffers for video memory surfaces when 8 or 16 bit
    display mode is requested.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48788
    Signed-off-by: Paul Gofman 
    Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

dlls/ddraw/ddraw_private.h |  2 ++
 dlls/ddraw/surface.c       | 61 +++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 60 insertions(+), 3 deletions(-)

And indeed, after reverting that commit, the game works flawlessly.

$ sha256sum armada_demo.exe 
2b8a04fefe6725bfdaf826e86e1a79dfb3bbb72377aeaaef4afa446ec6eface7

[Bug 49391] Star Trek Armada crashes on start on Wine 5.6 but not Wine 5.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49391

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=48788
                 CC|                            |[e-mail],
                   |                            |[e-mail]
    Regression SHA1|                            |d0ff5e66a7611511426a8ff902a
                   |                            |95ab22c545f78
                URL|                            |https://download.cnet.com/S
                   |                            |tar-Trek-Armada-demo/3000-2
                   |                            |095_4-10044363.html
           Keywords|                            |download, regression

[Bug 49391] Star Trek Armada crashes on start on Wine 5.6 but not Wine 5.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49391

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |422e05d84436092b4648153bacc
                   |                            |e8cc9ddc1d6c6

--- Comment #1 from Alex Henrie  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/422e05d84436092b4648153bac...

Thanks Paul!

[Bug 49391] Star Trek Armada crashes on start on Wine 5.6 but not Wine 5.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49391

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 5.11.