[Bug 56174] New: Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

Bug ID: 56174
           Summary: Forza Horizon 4 crashes with
                    concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@de
                    tails@Concurrency@@QEAA_NXZ
           Product: Wine
           Version: 9.0-rc5
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

With reverted bd89ab3040e30c11b34a95072d88f635ade03bdc (bug 55397)

wine: Call from 00006FFFFF463DC7 to unimplemented function
concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ,
aborting

[Bug 56174] Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
Translates to
public: bool __cdecl
Concurrency::details::_Cancellation_beacon::_Confirm_cancel(void) __ptr64

AFAIK this should just return true if it really is cancelled. Not sure why this
would be done, but I don't see what else it would do.

[Bug 56174] Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Vijay Kamuju  ---
Created a MR for this, implemented a stub which returns TRUE
https://gitlab.winehq.org/wine/wine/-/merge_requests/4863

[Bug 56174] Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

--- Comment #3 from Fabian Maurer  ---
This stub is enough for it to work? Or maybe just return "beacon->cancelling"?
I dunno.

[Bug 56174] Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |bcda5979bec20702d9773d8e387
                   |                            |37bf51da25d80
             Status|NEW                         |RESOLVED

--- Comment #4 from Vijay Kamuju  ---
Implemented, will be the in Wine 9.1 release
Commit - bcda5979bec20702d9773d8e38737bf51da25d80

[Bug 56174] Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 9.1.

[Bug 56174] Forza Horizon 4 crashes with concrt140.dll.?_Confirm_cancel@_Cancellation_beacon@details@Concurrency@@QEAA_NXZ

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56174

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.0.x