https://bugs.winehq.org/show_bug.cgi?id=51215
Bug ID: 51215 Summary: Logos Bible Software Crash selecting book in library Product: Wine Version: 6.9 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: johnpgoodman@gmail.com Distribution: ---
Created attachment 70087 --> https://bugs.winehq.org/attachment.cgi?id=70087 terminal output from crash
This is a regression, I have updated to wine 6.9 and now have a crash when I select a book in the library. Terminal output attached.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #1 from m0rvj johnpgoodman@gmail.com --- Still present in 6.10
https://bugs.winehq.org/show_bug.cgi?id=51215
Nick nick.andrewes@phonecoop.coop changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nick.andrewes@phonecoop.coo | |p
--- Comment #2 from Nick nick.andrewes@phonecoop.coop --- Created attachment 70128 --> https://bugs.winehq.org/attachment.cgi?id=70128 terminal output
I can confirm this bug (very easily; twice from two attempts).
Logos: 9.5.0.0019
Wine: wine-6.10 (Staging)
Distribution: Debian Bullseye
Installation via command line rather than script.
This used not to be a problem.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #3 from wine@redemption.studio --- Created attachment 70144 --> https://bugs.winehq.org/attachment.cgi?id=70144 Error when opening Logos Library Panel or Factbook
https://bugs.winehq.org/show_bug.cgi?id=51215
wine@redemption.studio changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine@redemption.studio
--- Comment #4 from wine@redemption.studio --- Can confirm:
Wine: wine-6.9 Logos: 9.5.0.0014 Distro: Manjaro
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #5 from m0rvj johnpgoodman@gmail.com --- Please note this seriously inhibits the usefulness of the app.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #6 from m0rvj johnpgoodman@gmail.com --- I'm not sure how to do a git bisect but I have a suspicion this is our problem? https://source.winehq.org/git/wine.git/commit/454712a94d62849324d20014c786b0...
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |454712a94d62849324d20014c78 | |6b0e7c452bf61
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|454712a94d62849324d20014c78 |f041eeab266bb6e7955fad7675c |6b0e7c452bf61 |61ca0c2981b25
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #7 from m0rvj johnpgoodman@gmail.com --- Grateful to T H Wright who has done the bisect. Bisecting: 0 revisions left to test after this (roughly 1 step) [f041eeab266bb6e7955fad7675c61ca0c2981b25] msvcrt: Import nextafter implementation from musl.
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #8 from T. H. Wright thwright@redemption.studio --- My apologies as I sent m0rvj the wrong info. Here's the git bisect results:
1dc3aa808fc65347fb12d32b05194c05748110be is the first bad commit commit 1dc3aa808fc65347fb12d32b05194c05748110be Author: Piotr Caban <REDACTED> Date: Fri May 14 16:11:55 2021 +0200
msvcrt: Import nextafterf implementation from musl.
Signed-off-by: Piotr Caban piotr@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
dlls/msvcrt/math.c | 40 +++++++++++++++++++++++++++++++++++++--- dlls/msvcrt/unixlib.c | 9 --------- dlls/msvcrt/unixlib.h | 1 - 3 files changed, 37 insertions(+), 13 deletions(-)
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |msvcrt
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Logos Bible Software Crash |MSVCRT Math regression |selecting book in library |affecting Logos Bible | |Software Library view and | |no doubt others apps.
https://bugs.winehq.org/show_bug.cgi?id=51215
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major CC| |o.dierick@piezo-forte.be Regression SHA1|f041eeab266bb6e7955fad7675c |1dc3aa808fc65347fb12d32b051 |61ca0c2981b25 |94c05748110be
https://bugs.winehq.org/show_bug.cgi?id=51215
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|MSVCRT Math regression |Logos Bible Software |affecting Logos Bible |crashes when opening |Software Library view and |Library View or Factbook |no doubt others apps. | Severity|major |normal Ever confirmed|0 |1 CC| |piotr.caban@gmail.com Status|UNCONFIRMED |NEW
--- Comment #9 from Gijs Vermeulen gijsvrm@gmail.com --- Rewording title, CC'ing Piotr.
Do note that until another app is reported to have issues because of this commit, the severity is normal.
If there is a free and legal download to test this with, that would help as well.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #10 from m0rvj johnpgoodman@gmail.com --- Thanks, your help is much appreciated!
The app is a bit like kindle in so much as the engine is free but the resources cost so there is a free download. Unlike kindle it has many advanced research features and books link together etc. The main app is free but there are paid features, resources and subscriptions. To use the app you need a free account https://www.logos.com/product/194909/logos-9-basic. It uses a downloader app which last I tried doesn't work with wine. The actual msi link is https://downloads.logoscdn.com/LBS9/Installer/9.6.0.0024/Logos-x64.msi
Manual Install Procedure: 1 Install wine 6 or newer 2 winetricks corefonts 3 winetricks settings fontsmooth=rgb 4 winetricks dotnet48 5 winetricks settings renderer=gdi (you might need to set the reg key manually) 6 Install the Logos.msi download but don't run it. 7 wine64 reg add "HKCU\Software\Wine\AppDefaults\LogosIndexer.exe" /v Version /t REG_SZ /d vista /f 8 Run Logos and sign in with your free account.
There is a script which downloads a preconfigured wine bottle and sets it all up in $USER/Logos_BibleP directory which you can then easily remove etc. https://github.com/ferion11/LogosLinuxInstaller/releases Choose fast install without wine AppImage.
https://bugs.winehq.org/show_bug.cgi?id=51215
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|1dc3aa808fc65347fb12d32b051 |854a3cab4c136d3e2292bcd9c42 |94c05748110be |c530e56cef7e9
--- Comment #11 from Piotr Caban piotr.caban@gmail.com --- I can reproduce it only by clicking on Facebook tab (Library works here). Since the _nextafter and _nextafterf functions are not called at all (both when clicking on Library and on Facebook in the toolbar) I guess that bisect was done incorrectly. I've rerun it, here's my result:
854a3cab4c136d3e2292bcd9c42c530e56cef7e9 is the first bad commit commit 854a3cab4c136d3e2292bcd9c42c530e56cef7e9 Author: Piotr Caban piotr@codeweavers.com Date: Fri May 14 16:11:48 2021 +0200
msvcrt: Import neabyint implementation from musl.
Signed-off-by: Piotr Caban piotr@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
I'll update the regression commit.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #12 from m0rvj johnpgoodman@gmail.com --- The crash happens as you select a resource in the library view. Not as you open the library. thanks
https://bugs.winehq.org/show_bug.cgi?id=51215
m0rvj johnpgoodman@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Logos Bible Software |Logos Bible Software |crashes when opening |crashes when selecting a |Library View or Factbook |resource in Library View or | |Factbook
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #13 from m0rvj johnpgoodman@gmail.com --- Sorry I've corrected the title. I didn't notice it was changed by someone else.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #14 from m0rvj johnpgoodman@gmail.com --- Technically possible we have 2 separate bugs here. One when the crash is from selecting a resource in the library view and one when opening the factbook.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #15 from Piotr Caban piotr.caban@gmail.com --- It should be fixed by https://source.winehq.org/patches/data/209926
Could you please retest it with the patch?
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #16 from m0rvj johnpgoodman@gmail.com --- Created attachment 70327 --> https://bugs.winehq.org/attachment.cgi?id=70327 terminal output from crash with patch
Unfortunately we aren't there yet, I've applied the patch and tested. Sadly both crashes are still present. I've attached the terminal output from the crash when selecting a book in the Library view. Once again thanks for your help with this.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #17 from Piotr Caban piotr.caban@gmail.com --- Created attachment 70333 --> https://bugs.winehq.org/attachment.cgi?id=70333 add debug fixme's
Could you please attach terminal output of running Logos Bible Software with the patch? The patch contains fix for nearbyint function and adds some more debug traces.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #18 from Piotr Caban piotr.caban@gmail.com --- (In reply to Piotr Caban from comment #17)
Created attachment 70333 [details] add debug fixme's
I forgot to mention, the patch is generated on top of wine 6.13.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #19 from m0rvj johnpgoodman@gmail.com --- Created attachment 70336 --> https://bugs.winehq.org/attachment.cgi?id=70336 Terminal output crash on load with newest patch
I used wine 6.13 and applied the patch, built the package, installed, tested. The result is Logos Bible Software won't load. It crashes while the splash screen is still showing. Terminal output attached.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #20 from m0rvj johnpgoodman@gmail.com --- This also happens with the unpatched 6.13 so probably needs to be the subject of a new regression bug report. I've just asked a couple of others to try it to confirm.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #21 from Piotr Caban piotr.caban@gmail.com --- (In reply to m0rvj from comment #20)
It starts for me in 6.13 (I can see the Library/Facebook crash without fesetenv patch). I've used the script from https://github.com/ferion11/LogosLinuxInstaller/releases to setup WINEPREFIX. I'm also using vanilla wine (not Staging).
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #22 from m0rvj johnpgoodman@gmail.com --- I've removed and installed winehq-devel=6.13 a couple of times (vanilla) and found launching I got crashes. After about 4 goes it finally loaded. Notably once loaded it is noticeably faster at loading resources - what a bonus! I'm not sure if the crashes on startup are an intermittent bug or the result of the program needing to resolve some artefact of the crash? After it was working I forced a crash by attempting to watch a video (separate bug due to incomplete evr implementation) after which it was then my 3rd attempt before I could load it again.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #23 from m0rvj johnpgoodman@gmail.com --- Can't get the patch to work. Now I've rebuilt the package with the second patch. I did: apt-get source winehq-devel patch ./wine-6.13~hirsute/dlls/msvcrt/math.c ./debug.patch sudo dpkg-source --commit (didn't save the log) sudo dpkg-buildpackage cd .. sudo apt install wine-devel-i386 (which was a missing dependency) sudo dpkg -i *.deb
After installing the patched version of 6.13 I couldn't get beyond crashing during startup. I tried about 10 times. Since it works for you, am I building it wrong? Not an expert, just followed a guide.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #24 from Piotr Caban piotr.caban@gmail.com --- (In reply to m0rvj from comment #23)
Since it works for you, am I building it wrong?
The build steps are looking good. There might be lots of reasons for difference in behavior. One of them is e.g. how the wine prefix was created: I have used the script, the Windows version is set to Windows 7 in my case and to Windows 10 in yours.
The patch is also applying to wine 6.9 (with some offsets, but the files are patched correctly). You may try collecting terminal output with patched wine 6.9 if it's easier for you.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #25 from m0rvj johnpgoodman@gmail.com --- Did you submit the patch to staging? In 6.14 staging it works ok again? Interestingly there is a big performance boost on opening resources. It's a nice upgrade 6.14 staging.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #26 from Piotr Caban piotr.caban@gmail.com --- (In reply to m0rvj from comment #25)
Yes, the nearbyint fix is in wine-staging 6.14. I didn't try with wine-staging but it works for me in 6.14.
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #27 from m0rvj johnpgoodman@gmail.com --- Great presumably we can close this bug then?
https://bugs.winehq.org/show_bug.cgi?id=51215
--- Comment #28 from m0rvj johnpgoodman@gmail.com --- and thanks so so much!
https://bugs.winehq.org/show_bug.cgi?id=51215
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |67c7c40351741ce3ceecddc22eb | |1e298af170eb2 Status|NEW |RESOLVED
--- Comment #29 from Piotr Caban piotr.caban@gmail.com --- Marking as fixed.
https://bugs.winehq.org/show_bug.cgi?id=51215
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #30 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.15.
-
WineHQ Bugzilla