http://bugs.winehq.org/show_bug.cgi?id=17397
Summary: Ventrilo 3.0.4 won't initialize GSM 6.10 codec stream Product: Wine Version: 1.1.15 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msadp32 AssignedTo: wine-bugs@winehq.org ReportedBy: willw@litany.me.uk
Ventrilo 3.0.4 with wine-1.1.15 is no longer able to use the GSM 6.10 audio codec. Speex codec still works.
Pop-up dialogue box contains:
----8<---- Failed to get encoder for specified Codec.
Unable to initialize outbound codec (GSM 6.10 - 22 KHz, 16 bit): Unable to open codec stream. Code = 512 ----8<----
git-bisect shows that the offending commit is 'wine-1.1.14-384-gc262d5b' (msadp32: ADPCM allows other sample rates other than 8000, 11025, 22050 and 44100.)
To reproduce without connecting to a server, bring up the Setup dialog, select the 'GSM 6.10' codec in the 'Test with' section, and click the 'Test' button.
http://bugs.winehq.org/show_bug.cgi?id=17397
--- Comment #1 from William Waghorn willw@litany.me.uk 2009-02-18 00:14:37 --- Created an attachment (id=19523) --> (http://bugs.winehq.org/attachment.cgi?id=19523) Patch which fixes the issue
It seems that the ADPCM driver is making a mess of things because it doesn't properly refuse to convert to the GSM610 format. The attached patch checks the format hint in ADPCM_FormatSuggest(), and will report NOTPOSSIBLE if it isn't in PCM or ADPCM format.
http://bugs.winehq.org/show_bug.cgi?id=17397
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Austin English austinenglish@gmail.com 2009-02-18 09:51:37 --- Please send patches to wine-patches@winehq.org
http://bugs.winehq.org/show_bug.cgi?id=17397
Trey trey.bastian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |trey.bastian@gmail.com
--- Comment #3 from Trey trey.bastian@gmail.com 2009-02-25 00:15:05 --- I fixed this by adding the full windows path into the system.ini file.
MSACM.msgsm610=C:\windows\system32\msgsm32.acm
hope this helps
http://bugs.winehq.org/show_bug.cgi?id=17397
execrable@gmail.com execrable@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |execrable@gmail.com
--- Comment #4 from execrable@gmail.com 2009-02-26 18:46:43 ---
I fixed this by adding the full windows path into the system.ini file.
MSACM.msgsm610=C:\windows\system32\msgsm32.acm
hope this helps
This didn't eliminate the error for me.
http://bugs.winehq.org/show_bug.cgi?id=17397
--- Comment #5 from William Waghorn willw@litany.me.uk 2009-02-26 20:54:32 ---
This didn't eliminate the error for me.
Don't see how it could. The problem is clearly in the msadp32/ADPCM driver. Try the patch.
As for wine-patches, I did submitted the patch, but it never made its way into the winehq git repository.
I'll re-submit, and cross my fingers.
http://bugs.winehq.org/show_bug.cgi?id=17397
Thodoris Greasidis thgreasi@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #6 from Thodoris Greasidis thgreasi@gmail.com 2009-03-06 02:22:15 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=17397
Eric Sandall sandalle@sourcemage.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sandalle@sourcemage.org
http://bugs.winehq.org/show_bug.cgi?id=17397
Synthuir wsynthuir@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wsynthuir@gmail.com
--- Comment #7 from Synthuir wsynthuir@gmail.com 2009-03-16 18:51:01 --- I have been having the same problem. Unfortunately, I do not know what you are supposed to do with the patch; it's all text and coded in a language that I don't understand. I would appreciate if someone told me specifically, "Add those lines of code into Ventrilo.xxx." Thank you.
http://bugs.winehq.org/show_bug.cgi?id=17397
--- Comment #8 from William Waghorn willw@litany.me.uk 2009-03-16 19:56:25 --- Patches get applied to the source, then you compile your own special version of wine from this patched source. Easiest way to do this is to use 'git' to obtain and manage Wine's source.
Unfortunately, my patch no longer works with wine-1.1.17. I was wondering why my patch wasn't accepted - looks like I've approached the problem from the wrong end.
http://bugs.winehq.org/show_bug.cgi?id=17397
--- Comment #9 from Synthuir wsynthuir@gmail.com 2009-03-16 21:04:21 --- I appreciate your helpful comments, however an error is returned when attempting to compile Wine with the patch:
walter@walter-desktop-ubuntu:~/.wine$ patch -p0 <../winepatch1.diff can't find file to patch at input line 14 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |commit 5159838b4719efa02673f1057e6c2369cf4b37b8 |Author: William Waghorn willw@litany.me.uk |Date: Tue Feb 17 21:33:01 2009 -0800 | | msadp32: Must refuse unknown destination format hint | | ADPCM_FormatSuggest must check that destination format hint is | WAVE_FORMAT_PCM or WAVE_FORMAT_ADPCM. | |diff --git a/dlls/msadp32.acm/msadp32.c b/dlls/msadp32.acm/msadp32.c |index 7a66207..dcc086c 100644 |--- a/dlls/msadp32.acm/msadp32.c |+++ b/dlls/msadp32.acm/msadp32.c --------------------------
http://bugs.winehq.org/show_bug.cgi?id=17397
--- Comment #10 from Vitaliy Margolen vitaliy@kievinfo.com 2009-03-16 22:03:59 --- (In reply to comment #9)
walter@walter-desktop-ubuntu:~/.wine$ patch -p0 <../winepatch1.diff
Need "-p1" not "-p0".
http://bugs.winehq.org/show_bug.cgi?id=17397
--- Comment #11 from Max Loparev laplandersan@gmail.com 2009-03-17 07:26:21 --- (In reply to comment #1)
Created an attachment (id=19523)
--> (http://bugs.winehq.org/attachment.cgi?id=19523) [details]
Patch which fixes the issue
It seems that the ADPCM driver is making a mess of things because it doesn't properly refuse to convert to the GSM610 format. The attached patch checks the format hint in ADPCM_FormatSuggest(), and will report NOTPOSSIBLE if it isn't in PCM or ADPCM format.
Thank you. Patch works perfectly on wine-1.1.16. ventrilo-3.0.4
http://bugs.winehq.org/show_bug.cgi?id=17397
Max Loparev laplandersan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |laplandersan@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=17397
William Waghorn willw@litany.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #19523|0 |1 is obsolete| |
--- Comment #12 from William Waghorn willw@litany.me.uk 2009-03-17 18:59:44 --- Created an attachment (id=20005) --> (http://bugs.winehq.org/attachment.cgi?id=20005) patch for wine-1.1.17
Attached a new pair of patches, which use a slightly different and simpler approach to fix the problem for wine-1.1.17 - as suggested by one of the regular wine contributors. I'll submit them separately to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=17397
William Waghorn willw@litany.me.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #13 from William Waghorn willw@litany.me.uk 2009-04-11 18:10:16 --- Fix was accepted into wine 1.1.18.
http://bugs.winehq.org/show_bug.cgi?id=17397
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #14 from Alexandre Julliard julliard@winehq.org 2009-04-24 12:19:27 --- Closing bugs fixed in 1.1.20.
-
wine-bugs＠winehq.org