[Bug 16749] New: kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

Summary: kernel32/tests: wrong char type
           Product: Wine
           Version: 1.1.12
          Platform: Macintosh
        OS/Version: Linux
            Status: NEW
          Keywords: source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

gcc -c -I. -I. -I../../../include -I../../../include   -D_REENTRANT -fPIC -Wall
-pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wtype-limits -Wpointer-arith  -g -O2  -o codepage.o codepage.c
codepage.c: In function ‘test_string_conversion’:
codepage.c:228: warning: comparison is always false due to limited range of
data type
codepage.c:244: warning: comparison is always false due to limited range of
data type

changing mbc to be a signed char rather than char seems the obvious solution,
but that breaks things further:
codepage.c:226: warning: pointer targets in passing argument 5 of
‘WideCharToMultiByte’ differ in signedness
codepage.c:233: warning: pointer targets in passing argument 5 of
‘WideCharToMultiByte’ differ in signedness
codepage.c:242: warning: pointer targets in passing argument 5 of
‘WideCharToMultiByte’ differ in signedness
codepage.c:251: warning: pointer targets in passing argument 5 of
‘WideCharToMultiByte’ differ in signedness
codepage.c:262: warning: pointer targets in passing argument 5 of
‘WideCharToMultiByte’ differ in signedness
codepage.c:328: warning: pointer targets in passing argument 5 of
‘WideCharToMultiByte’ differ in signedness

[Bug 16749] kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

--- Comment #1 from Austin English   2009-08-30 14:58:35 ---
Still present in git.

[Bug 16749] kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Macintosh                   |ppc32

[Bug 16749] kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

--- Comment #2 from Austin English  2010-12-02 16:10:46 CST ---
Still in wine-1.3.8-153-g27d2b9b

[Bug 16749] kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from André H.  2013-04-21 06:39:14 CDT ---
maybe that's fixed meanwhile?
64c6c08e088d1d53d9f038d7167c6531f2ce365a is related

[Bug 16749] kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |64c6c08e088d1d53d9f038d7167
                   |                            |c6531f2ce365a
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Austin English  2013-04-22 22:18:54 CDT ---
(In reply to comment #3)
> maybe that's fixed meanwhile?
> 64c6c08e088d1d53d9f038d7167c6531f2ce365a is related

I don't have easy access to a powerpc32 machine, so let's assume so.

[Bug 16749] kernel32/tests: wrong char type

http://bugs.winehq.org/show_bug.cgi?id=16749

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-04-26 13:16:10 CDT ---
Closing bugs fixed in 1.5.29.